From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iF4lF4yeZmE1qAAAgWs5BA (envelope-from ) for ; Wed, 13 Oct 2021 10:53:32 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id eCTYEoyeZmGWewAA1q6Kng (envelope-from ) for ; Wed, 13 Oct 2021 08:53:32 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B5DC31B98E for ; Wed, 13 Oct 2021 10:53:31 +0200 (CEST) Received: from localhost ([::1]:60584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maa0w-00069m-Qq for larch@yhetil.org; Wed, 13 Oct 2021 04:53:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42576) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maa0U-000694-U2 for guix-patches@gnu.org; Wed, 13 Oct 2021 04:53:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46533) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1maa0U-000615-K4 for guix-patches@gnu.org; Wed, 13 Oct 2021 04:53:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1maa0U-0003p7-Ie for guix-patches@gnu.org; Wed, 13 Oct 2021 04:53:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50756] [PATCH] gnu: Add lttng-tools. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 13 Oct 2021 08:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50756 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen Cc: Olivier Dion , 50756@debbugs.gnu.org Received: via spool by 50756-submit@debbugs.gnu.org id=B50756.163411514714584 (code B ref 50756); Wed, 13 Oct 2021 08:53:02 +0000 Received: (at 50756) by debbugs.gnu.org; 13 Oct 2021 08:52:27 +0000 Received: from localhost ([127.0.0.1]:58062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maZzu-0003nA-Ly for submit@debbugs.gnu.org; Wed, 13 Oct 2021 04:52:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maZzl-0003mn-ND for 50756@debbugs.gnu.org; Wed, 13 Oct 2021 04:52:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50058) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maZzf-0005AW-P5; Wed, 13 Oct 2021 04:52:11 -0400 Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:53865 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maZzf-0007tp-Fk; Wed, 13 Oct 2021 04:52:11 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210923124004.3164-1-olivier.dion@polymtl.ca> <87mto2jbkl.fsf@yoctocell.xyz> <87tuia2ehj.fsf@laura> <875yunk70l.fsf@yoctocell.xyz> Date: Wed, 13 Oct 2021 10:52:08 +0200 In-Reply-To: <875yunk70l.fsf@yoctocell.xyz> (Xinglu Chen's message of "Sun, 26 Sep 2021 11:42:18 +0200") Message-ID: <87zgrds3wn.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634115211; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=KcmiP1j0XJGHzAWythnlijl+52DOu5P5mipvXIiwkh8=; b=mKfYaWXqgGdNHO2YHopDPBEz0w4/LkACkBSaqMx4pY6Aq6xslSaaq7ELVI+Dio3y8C2KCl c30IM/hRtZ0qxFwNV0gHyXj+3xRIOldUgfgyue7bTRYD/TfSxb0rfDSxLpzr/bj/dxWs1f tFyAM/2ym0AHszsVdg0UTWF0rP0A7UHbm9PbvFKJ+eLveY7NaLwXVIdVDVkbGfONrtmO4I o2GqbDa3FwNpYhUAq/K8Qfn5A+2HnVeiwjCRc47P+XRyiSd6juQbHQ8EfcbnULsEij9Ilv 49EpfaeZXB2s9kX5LkQVNRv0//3qsnMejC0XN+vT5lW922ZJvj9MbsHBjw07DA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634115211; a=rsa-sha256; cv=none; b=qppfk230hWq9yTnvoqoiZyz+nTHGBaFGOUnPc0SefMfCUkGTS9selfdvafAkDPSKjuQkX8 OIQbqxlkGST/xhb+p6Z911joREOGRqjyJvRDZcbamkNnov0GawHD5FPnxJ8e3uULpKjZLA NDcAjpYVQ0EllRTY8T2xUEzeXHnufI7taP/FZTX80jqp9VtUQBmZmOVJuw5RHL5xonOe6U N3ev4kGMBWcUe+qY3qCs3RK03SJSwD6MMZ7vr4MIghy944sZhSczxZe5ZHTG+RDg4xSuFf w7YcspD9CclNgxTNp1cbGOyFBKLRrTwTP96Gq5bgY3chwYr+2oegESPpB4oGRQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.91 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: B5DC31B98E X-Spam-Score: -2.91 X-Migadu-Scanner: scn0.migadu.com X-TUID: MOnJETWBcLLG Hi Olivier, Did you have a chance to look into this? https://issues.guix.gnu.org/50756 TIA! Ludo=E2=80=99. Xinglu Chen skribis: > On Fri, Sep 24 2021, Olivier Dion via Guix-patches via wrote: > >> On Fri, 24 Sep 2021, Xinglu Chen wrote: >>> On Thu, Sep 23 2021, Olivier Dion via Guix-patches via wrote: >> >>>> +(define-public lttng-tools >>>> + (package >>>> + (name "lttng-tools") >>>> + (version "2.12.5") >>> >>> Version 2.13 is available; any reason for not using it? >> >> Would require to bump version of lttng-ust also I think. I prefer to do= all of this >> in another patch. > > Ah, OK. > >>>> + (arguments >>>> + `(#:tests? #f >>>> + #:parallel-tests? #f >>> >>> There is no need to set #:parallel-tests? if #:tests? is set to #f. >> >> During my testing, I noticed that test in parallel are not working >> because of how the lttng-daemon works. So I disable the parallel option >> in order to not forget it when testing will work in the future. I >> should probably add a comment to explain the rationale here. >> >>>> + (propagated-inputs >>>> + `(("libkmod" ,kmod) >>>> + ("modprobe" ,module-init-tools))) >>> >>> Any reason for the labels not being the same as the package? >> >> I follow the naming convention in the description of the project's README >> so it's easier to map the dependencies described by it to Guix's >> packages. I can change this, but I find it more clear that way. > > The name of the label is usually the same as the package, so I would > change them to =E2=80=9Ckmod=E2=80=9D and =E2=80=9Cmodule-init-tools=E2= =80=9D respectively. > >>> >>>> + (native-inputs >>>> + `(("pkg-config" ,pkg-config) >>>> + ("perl" ,perl) >>>> + ("libpfm4" ,libpfm4) >>>> + ("python" ,python-3) >>> >>> While running the configure script, I get >>> >>> configure: You may configure with --enable-python-bindings if you wan= t Python bindings. >>> >>> So you would have to pass the =E2=80=98--enable-python-bindings=E2=80= =99 flag, and >>> Python would be needed during runtime as well. >> >> Does it tho? Bindings can be generated at build time. While you would >> require python-3 at runtime to use the bindings, you don't require >> python-3 to use the other tools of the project. I don't mind adding it >> to the inputs, I'm just asking. > > True, the user can install always install Python in their profile > themselves.