From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GBDNAJiuwGHdZgAAgWs5BA (envelope-from ) for ; Mon, 20 Dec 2021 17:26:00 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id WPBCOJeuwGFWeAAA1q6Kng (envelope-from ) for ; Mon, 20 Dec 2021 16:25:59 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AC52D27494 for ; Mon, 20 Dec 2021 17:25:59 +0100 (CET) Received: from localhost ([::1]:47088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mzLU6-0003ci-QB for larch@yhetil.org; Mon, 20 Dec 2021 11:25:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52126) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzKb1-00067S-Gs for guix-patches@gnu.org; Mon, 20 Dec 2021 10:29:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39601) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mzKb0-000315-LE for guix-patches@gnu.org; Mon, 20 Dec 2021 10:29:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mzKb0-0003QE-GZ for guix-patches@gnu.org; Mon, 20 Dec 2021 10:29:02 -0500 Subject: bug#52603: [PATCH 0/2] Flag missing netmasks early on Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Mon, 20 Dec 2021 15:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 52603 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 52603-done@debbugs.gnu.org Mail-Followup-To: 52603@debbugs.gnu.org, ludo@gnu.org, ludo@gnu.org Received: via spool by 52603-done@debbugs.gnu.org id=D52603.164001409813076 (code D ref 52603); Mon, 20 Dec 2021 15:29:02 +0000 Received: (at 52603-done) by debbugs.gnu.org; 20 Dec 2021 15:28:18 +0000 Received: from localhost ([127.0.0.1]:51146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzKaI-0003Oq-6W for submit@debbugs.gnu.org; Mon, 20 Dec 2021 10:28:18 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:41918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzKaE-0003ON-67 for 52603-done@debbugs.gnu.org; Mon, 20 Dec 2021 10:28:17 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id DA8C51DF; Mon, 20 Dec 2021 16:28:07 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5987Pn-arSfr; Mon, 20 Dec 2021 16:28:07 +0100 (CET) Received: from ribbon (unknown [IPv6:2001:660:6102:320:e120:2c8f:8909:cdfe]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 9260718E; Mon, 20 Dec 2021 16:28:06 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20211218170227.19999-1-ludo@gnu.org> <87fsqpt0s4.fsf@gnu.org> Date: Mon, 20 Dec 2021 16:28:05 +0100 In-Reply-To: <87fsqpt0s4.fsf@gnu.org> (Mathieu Othacehe's message of "Sun, 19 Dec 2021 10:13:47 +0100") Message-ID: <87zgovgut6.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-Rspamd-Server: hera X-Rspamd-Queue-Id: DA8C51DF X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640017559; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=f+oK8tBanqgoR8gI83PK1P2XaGz4fsMrOlXunT1n3kE=; b=qy9hkTbe0LuDCLKqMAKOAeU3QRv86qM0hnrJu5AgVpB4PaayGpLYqwj/7MMrFxyzc1PC0z K0y7o4vP9zDr5VLoXxgsd0CJvl2bAWyhRnakcar8ygwrcJM1YpTrNVzCJZD/L2pTrN45A3 kXhvcEhkRux2HH4S85Zy8f9p8S/oZQQU/DQcxbJbyFPFF1g/xJOimuSFSwb5Eih6mgf5Yh txXLsySsW2jGbnQGnodFStZ9Eld55A1y+6iPFpQFxgubt3rwrfieeWwwt4uOJo1QYHF2Hf zbhpvduHRpkW0gviLCxUzYfANjU9HudHje08fdf4Ylz2TuYiXZWe4OcZgoxo1Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640017559; a=rsa-sha256; cv=none; b=s36fAG1CUtKYiosN8oeW7qs/ZabPWB7r0csbh6hxmAQXTfyxLsjZBCRf/HYsjKREvhqFSw X0pfdoyoQoPpbqdaWBL3QvRVqPjH4EMjLACa/PyfDohvamXeLi+nUNh27lrsvh66O99GGr Ji3MLI1FMipiVRVxdvlFzGFyTD7VEeHhX12fjCyjJt26Mzk2VRxOQNfgy8kWomouoDZIqc 2CmDYDfZSmdZrv4X/QuWcCMEMLL5htJv4ExBKJ+oQXLwDTZWufDpOPG8yJ27x3YxWg7yoc Pjm/w+SNaRfADLa0z8uxHO1F5uIZRPziPonQh64z5xVFu0ZaLJYWGQVaKCQbbw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.82 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: AC52D27494 X-Spam-Score: -2.82 X-Migadu-Scanner: scn0.migadu.com X-TUID: BdUXkuJPL1Y4 Hi, Mathieu Othacehe skribis: >> To avoid this, this patch flags it at expansion time (if possible) or >> at run time, before the machine configuration is built. >> >> Did I go overboard with =E2=80=98define-compile-time-procedure=E2=80=99?= I don=E2=80=99t think >> so :-), I think it will serve us more than once. > > I tested this series, works fine! It is still possible to pass incorrect > netmasks (negative, > 32 for IPv4), but they should be way less frequent > than forgetting to add a netmask. Yeah=E2=80=A6 Pushed as 4df584aeac56fb6575ba43bc94f60f04522caf88, thanks for testing! Ludo=E2=80=99.