Maxime schrieb am Sonntag der 06. Februar 2022 um 14:17 +01:

> Xinglu Chen schreef op zo 06-02-2022 om 14:00 [+0100]:
>> +      (($ <git-reference> url commit recursive?)
>> +       (and-let* ((updated-commit (if (string=? old-version commit)
>> +                                      version
>> +                                      (update-url commit old-version version))))
>
> When does the URL of a git-reference include a version?

It doesn’t, but the tag usually does; I should probably rename the
‘update-url’ procedure to something else, maybe ‘update-version’?

>> +         (list (git-reference
>> +                (url url)
>> +                (commit updated-commit)
>> +                (recursive? recursive?)))))
>
> (guix upstream) expects a single git-reference, not a list of git-
> references.

Oops, noted.

> Also, depending on the order of fields here doesn't seem great, I' do
> something like
>
> ((? git-reference? reference)
>  (git-reference
>     (inherit reference)
>     (commit updated-commit)))
>
> instead.

Then I can drop the first patch of the series too.  :-)