From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MPhXG39wJmIDkQAAgWs5BA (envelope-from ) for ; Mon, 07 Mar 2022 21:52:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id wExYGH9wJmJCaQEAauVa8A (envelope-from ) for ; Mon, 07 Mar 2022 21:52:15 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0229041CB4 for ; Mon, 7 Mar 2022 21:52:14 +0100 (CET) Received: from localhost ([::1]:48230 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nRKL0-00034T-21 for larch@yhetil.org; Mon, 07 Mar 2022 15:52:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58316) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRKKo-00032E-2i for guix-patches@gnu.org; Mon, 07 Mar 2022 15:52:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60800) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nRKKn-0004p2-Qm for guix-patches@gnu.org; Mon, 07 Mar 2022 15:52:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nRKKn-0003wH-O7 for guix-patches@gnu.org; Mon, 07 Mar 2022 15:52:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53472] [PATCH] gnu: Add emacs-nim-mode Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 07 Mar 2022 20:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53472 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: paren@disroot.org Cc: 53472@debbugs.gnu.org, Nicolas Goaziou Received: via spool by 53472-submit@debbugs.gnu.org id=B53472.164668629315103 (code B ref 53472); Mon, 07 Mar 2022 20:52:01 +0000 Received: (at 53472) by debbugs.gnu.org; 7 Mar 2022 20:51:33 +0000 Received: from localhost ([127.0.0.1]:54697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRKKL-0003vV-0t for submit@debbugs.gnu.org; Mon, 07 Mar 2022 15:51:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRKKJ-0003vI-Oi for 53472@debbugs.gnu.org; Mon, 07 Mar 2022 15:51:32 -0500 Received: from [2001:470:142:3::e] (port=51660 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRKKD-0004go-T6; Mon, 07 Mar 2022 15:51:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=4V+gQi8Zuc1zuVNVO3ZwSivZZUmS+HgJJtLbVvX7p5o=; b=BNv4F8rwIUiDeAEtDwSc JRbpbGNSUJ3cdMdPzfIpVNTenIrScOngTGqT3HPRYUBgkdTSXOCGJrdfHjfhgEXY31/QiRqMprAXJ P6VvdGJz5sjmp0Am2o13dSHfX7dP6D8oHjpWH8HR9AnTf0c5y6/q7fNVp55pI0CIf6B9V7pvaz8H2 nLj4qVx9o+Cv6fa90oxb55GH4d1ur8WNsTPKcDX798LftvJVncAwRuvwgepMoJq2cSWf+iIa63t4c Din35sd6aJxJGL+sn7MomDX2J0ZiWqnG7wTHdTHc7l+IYR1D7SGqBv3JSRIKCmOiufjZxjTel6w6e E05+DH0/PeZzdg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:58571 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRKKD-0000TG-FP; Mon, 07 Mar 2022 15:51:25 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220123133837.1035-1-paren@disroot.org> <20220124201247.30159-1-paren@disroot.org> <877dakxpjl.fsf@nicolasgoaziou.fr> Date: Mon, 07 Mar 2022 21:51:23 +0100 In-Reply-To: <877dakxpjl.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Fri, 28 Jan 2022 08:55:26 +0100") Message-ID: <87zgm1a3lg.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1646686335; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=4V+gQi8Zuc1zuVNVO3ZwSivZZUmS+HgJJtLbVvX7p5o=; b=gAlMKwNffEuxR5e01tYYaTnYRjeaplPwYQ2QFDbIjIHep0sYb5IE5zrZeBHt/i40PK8RE8 JsyMv7Bu00mgTBmPWv1KRlCcj6U9BVm+rCfsfdekDdlhp+6zSlVEvZf5b2Ic/zNMYvw6O2 BDfvTFGNKg4DlBOPu0tG1dJRK1+N8ve01PYv44LugVgowYSoFGGkNkMoBJ0dzjVHjtylcz ciAtvYtX6bMaP4PX8OIsP3wNQcObDwDPjPYPMLP6H32+WxVurWUnsx0O93tYTiaCX1Vk21 OgORRCeEIh/KAvWArI5NlrQvjIWC7a8FxTaH6wrh0Q+nzHXA9PS6EBKpFOMQNQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1646686335; a=rsa-sha256; cv=none; b=Oy+BRpw0h7e8C7HN291M8LsEGMNO9JpKj6xX0AdQzZXRPE2X/4jlUCoW8Eq6j09dn5RKoB nz65uMeZK8KvkVe6VWowU/Sqf1lAGHRSJgmMMh5xsjSimPRWOSxi9qfBjnL6uyW8Y14I7W 0NUaDbcwO3Zgk0s0u/Lxe2fU/qmOkhbMZWBpZsfARLBiz1wOZp068YRipT2XV6glEimJim F0iJyHfyOaNcm3isNwEYn3WSNCK4Oovflv/+fA6tkWQ5zbhTiN02AX0dPqTi1J/uhcM6Pr p9aTF4RTOMmV3ALZ6OIsEZkAI3LPPChLgzL7aqUL93akILn46UZ5wkjXSKlLug== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=BNv4F8rw; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.72 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=BNv4F8rw; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0229041CB4 X-Spam-Score: -4.72 X-Migadu-Scanner: scn0.migadu.com X-TUID: pDyakDlqmCHr Hi unmatched-parenthesis, I know it=E2=80=99s been a while already, but did you have a chance to look= into making the changes Nicolas suggested? https://issues.guix.gnu.org/53472 TIA, Ludo=E2=80=99. Nicolas Goaziou skribis: > Hello, > > "(unmatched-parenthesis via Guix-patches" via > writes: > >> * gnu/packages/emacs-xyz.scm(emacs-nim-mode): New variable. > > Thank you. > > You add both emacs-nim-mode and emacs-commenter. Could you split the > patch into two parts? >> + (uri (string-append "https://github.com/yuutayamada/commenter/ar= chive/refs/tags/v" version ".tar.gz")) > > These URI are not stable. You should use git-fetch with commit > (string-append "v" version) instead. > >> + (sha256 >> + (base32 "1n9m8f4gflb0c3nh98nkmsqzscyf5d1p1gcz8apskkmf7z0z0q2j")= ))) >> + (build-system emacs-build-system) >> + (home-page "https://github.com/yuutayamada/commenter") >> + (synopsis "Allows you to set both single and multi line comment var= iables like @code{comment-start} or @code{comment-end} etc.") > > The synopsis is too long: > > "Set both single- and multi-line comment variables in Emacs" > >> + (description "This package allows you to set both single and multi = line comment variables like @code{comment-start} or @code{comment-end} etc.= ") > > I suggest to drop the "etc." since there is "like" before. > > "This Emacs package sets both single- and multi-line comment variables = like @code{comment-start} or @code{comment-end}." > >> +(define-public emacs-nim-mode >> + (let ((commit "744e076f0bea1c5ddc49f92397d9aa98ffa7eff8") >> + (revision "0")) > > Since you're not using a tagged commit, could you put a comment above > the let binding explaining why? > >> + (synopsis "Major mode for editing Nim source code") > > I would add "Emacs": "Emacs major mode for editing Nim source code" > >> + (description "This package provides major modes for Nim: >> ++@itemize >> ++@item Syntax highlighting for Nim code, Nimble configuration files, an= d nim.cfg >> ++@item `M-x nim-compile`, which can also be invoked with `C-c C-c` insi= de a Nim source file >> ++@item File outline by procedures >> ++@item Indentation and line breaking (alpha) >> ++@item Integration with nimsuggest, the Nim linting and completion serv= er (alpha, both nimsuggest-mode and nimsuggest itself are currently VERY un= stable and may make emacs much less responsive) >> ++@end itemize") > > I suggest: > > This package includes major modes for Nim. In particular, it provides > syntax highlighting for Nim code, Nimble configuration files, and > @file{nim.cfg}, outlining features, a dedicated compilation command, > indentation and line breaking. > > It also implements integration with @code{nimsuggest}, the Nim linting > and completion server, although this is currently unstable. >=20=20 >> + (license license:gpl3+)))) > > Could you send an updated patch? > > Regards,