From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GP7qOlZgS2KMEwAAgWs5BA (envelope-from ) for ; Mon, 04 Apr 2022 23:17:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id kPpBM1ZgS2J05AAAG6o9tA (envelope-from ) for ; Mon, 04 Apr 2022 23:17:10 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 603A232FBA for ; Mon, 4 Apr 2022 23:17:10 +0200 (CEST) Received: from localhost ([::1]:59978 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nbU4T-0006hM-GB for larch@yhetil.org; Mon, 04 Apr 2022 17:17:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53634) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbU4M-0006h1-RE for guix-patches@gnu.org; Mon, 04 Apr 2022 17:17:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59305) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nbU4M-0001fE-Ie for guix-patches@gnu.org; Mon, 04 Apr 2022 17:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nbU4M-0003ym-EA for guix-patches@gnu.org; Mon, 04 Apr 2022 17:17:02 -0400 Subject: bug#54393: [PATCH 0/2] Add 'guix manifest' to "translate" commands to manifests Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Mon, 04 Apr 2022 21:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 54393 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 54393-done@debbugs.gnu.org Mail-Followup-To: 54393@debbugs.gnu.org, ludo@gnu.org, ludo@gnu.org Received: via spool by 54393-done@debbugs.gnu.org id=D54393.164910698315214 (code D ref 54393); Mon, 04 Apr 2022 21:17:02 +0000 Received: (at 54393-done) by debbugs.gnu.org; 4 Apr 2022 21:16:23 +0000 Received: from localhost ([127.0.0.1]:53201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nbU3i-0003xJ-Un for submit@debbugs.gnu.org; Mon, 04 Apr 2022 17:16:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nbU3h-0003wy-HH for 54393-done@debbugs.gnu.org; Mon, 04 Apr 2022 17:16:21 -0400 Received: from [2001:470:142:3::e] (port=43052 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbU3c-0001Rc-Ac; Mon, 04 Apr 2022 17:16:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=Oy488Z+3qUDhDv6t1DE9wBNkMAe5m05b0Tc6CiPR7v4=; b=FwSSTltqtsCQXX+w+y3K qCnbTS8hY6+QMrSlAsa/Zo+pzKx2wH2I8dUALZsCJy++re0z4zR2Yr4wXh6K2a1VisIs2sWfkIalz BXpHZtNf/VEpSJSgV5ZbQgl/oIRUcslbWfTTW4uXoXfwN+RmZ8JohHkMHFoeKkGKYwzMwWQmMriMu s5lyQvyhuMnWGL3RcG6mjP+Hv/BuPgi6eGrwDQevIagZkW6TOlG6EApQHSmgurGqVnG1sMN8G8tTa 1jhn+jPTx6SMrPdT+cp7aCff/o7QKTtZNikCF4lU3MPml/6dDERyQO9/3c4P2MstiwXnQE6eSshar wQxBPC06/YdnbQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:60036 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbU3b-0007Et-SJ; Mon, 04 Apr 2022 17:16:16 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87r173huph.fsf@gnu.org> <20220331110957.31829-1-ludo@gnu.org> <20220331110957.31829-3-ludo@gnu.org> <87sfqszzh5.fsf_-_@gmail.com> Date: Mon, 04 Apr 2022 23:16:13 +0200 In-Reply-To: <87sfqszzh5.fsf_-_@gmail.com> (Maxim Cournoyer's message of "Mon, 04 Apr 2022 10:37:26 -0400") Message-ID: <87zgl0r1lu.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1649107030; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Oy488Z+3qUDhDv6t1DE9wBNkMAe5m05b0Tc6CiPR7v4=; b=E4oQ/neJLSUGNjYcrK724wAiGYTiixbiMVunRyIyY3F/P3j71hKmzWP1uh0ZMaks8e8YiM dRZokDTLM30wp58o2qpGR0zlEx/4AFttsQSuoXK+RCxEaJSfBy5wYJ97JIuvQBUIzn1zKH VAou0rF030pTz5TWpqwZGdoysoZs56iiG7cL6zYLArm4XbATc0OTjvveVWhEZ7Tn6MklJo ZaFxmU/FfrolskcGDrpGSzvdalFMMAIU/rIFSqmVCRdKHRZ2rYbcTyBJ9S0iC6TQdL0LMr gowLROoWJ+SJFBjg6nqJSnbiBq4JhzaPz/PKwwXhtp6tAuCncc9ef6iR1eaAfw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1649107030; a=rsa-sha256; cv=none; b=UOtaiy5k3D67jBrS5AtSLYpCUdXM1wWqRdhyc9HOT4N0GsX8gE47m/iteD6JRbj4+bE3Co z4rckw5hqI941sYoREIDwLZ/jssp9grdZW8hzy/TPLqHW9tUuaJrbHpKaCj4a5X4o7enI1 SgoRsmZhufpywntXRMpkcxumz1XlO31olfeSj2SHHJYOi/+G2kWYvp7T1iGWD5aXSIRBS8 3siXjiGRRV3cUiTLhupyisHP9HuPkhw91AwVZnliBkGXcG5zzeROWkHnQ0ySRtQhc+DlXN xcS7bUAD3tam4DyhWH9tXLx6kYTnR6gi6BNHXcbYQTJSVK7sKltumKAJhE/zuA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=FwSSTltq; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.38 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=FwSSTltq; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 603A232FBA X-Spam-Score: -4.38 X-Migadu-Scanner: scn0.migadu.com X-TUID: OjhOihXN06Vf Hi! Maxim Cournoyer skribis: [...] >> +(define (manifest->code* manifest extra-manifests) >> + "Like 'manifest->code', but insert a 'concatenate-manifests' call that >> +concatenates MANIFESTS, a list of expressions." >> + (if (null? (manifest-entries manifest)) >> + (match extra-manifests >> + ((one) one) >> + (lst `(concatenate-manifests ,@extra-manifests))) >> + (match (manifest->code manifest >> + #:entry-package-version >> + manifest-entry-version-prefix) >> + (('begin exp ... last) >> + `(begin >> + ,@exp >> + ,(match extra-manifests >> + (() last) >> + (_ `(concatenate-manifests >> + (list ,last ,@extra-manifests))))))))) > > Should an "else" clause be added here with a more useful error message > that the default 'no match for x' or similar? If that'd be totally > unexpected and a bug, then it's fine as-is. Yes, it would be a bug. >> + (define (validated-spec spec) >> + ;; Return SPEC if it's validate package spec. > > As this is an action (proc), perhaps it should be named "validate-spec". > The comment doc should also be worded as "if SPEC is a valid package > spec" or similar. I fixed the comment but kept the name =E2=80=98validated-spec=E2=80=99, whi= ch is an attempt at suggesting that it=E2=80=99s returns a meaningful value (whereas =E2=80=98validate-spec=E2=80=99 sounds like it=E2=80=99s called for effect = and returns *unspecified*). > Thank you for addressing the suggestion to reuse an existing sub-command > to try to keep things neatly organized instead of extending the already > large set of them :-). Heheh, thanks! Pushed as b1e7e64f351fa03a66ce1f9776f9ba84cf2c6294 together with a news entry. Ludo=E2=80=99.