From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id UNHfEkp2rGIAHgEAbAwnHQ (envelope-from ) for ; Fri, 17 Jun 2022 14:40:42 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id QGaXEkp2rGI2agAAauVa8A (envelope-from ) for ; Fri, 17 Jun 2022 14:40:42 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 03699575F for ; Fri, 17 Jun 2022 14:40:42 +0200 (CEST) Received: from localhost ([::1]:39100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o2BHE-0006j0-12 for larch@yhetil.org; Fri, 17 Jun 2022 08:40:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53244) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2BGd-0006hh-4B for guix-patches@gnu.org; Fri, 17 Jun 2022 08:40:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50300) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o2BGc-00053H-Rb for guix-patches@gnu.org; Fri, 17 Jun 2022 08:40:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o2BGc-0005fY-Mf for guix-patches@gnu.org; Fri, 17 Jun 2022 08:40:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55845] [PATCH 0/1] Improve pager selection logic when less is not installed Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 17 Jun 2022 12:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55845 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Taiju HIGASHI Cc: 55845@debbugs.gnu.org, me@tobias.gr, Maxime Devos Received: via spool by 55845-submit@debbugs.gnu.org id=B55845.165546958821765 (code B ref 55845); Fri, 17 Jun 2022 12:40:02 +0000 Received: (at 55845) by debbugs.gnu.org; 17 Jun 2022 12:39:48 +0000 Received: from localhost ([127.0.0.1]:44197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2BGO-0005ey-IF for submit@debbugs.gnu.org; Fri, 17 Jun 2022 08:39:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o2BGM-0005el-RD for 55845@debbugs.gnu.org; Fri, 17 Jun 2022 08:39:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57972) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2BGG-0004LE-C3; Fri, 17 Jun 2022 08:39:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=CXX4CmYVf2CgNqXPCq2/9FtL8H1Uv9o3V/ul0laG5KA=; b=EZN3T8nYMbuTktQw6BBh yB/UCixRqnM6azXmub3AhmR7yw1ckxwvGFr3+Y9xskZGyZxK/pZbirxzdW3VpWpkqmjSDiveft9UM 5r5cWvZ8sTMD8kVs35mGtxGpVuMtTY3asAidJXSbtPc0M+Z+7OpOW9JoiXPuWdKT6zel4/+/jIZdG +rY6hvHN3Et45fC8EaV0n5rJvch21wNGfM2x8JYWQjfTJv6okfHSlv95wNu338iI///0C0CkG5Qfg QHsv180oCt5ZTgwO9IcCVgVRl5/UUIOpOexV1YAWo6nK+zUCEzqQywYKtuOm6IMkVygQJyS+uGMSz UyVSOn9Hcqt75w==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=33148 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2BGF-0003OT-U2; Fri, 17 Jun 2022 08:39:40 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220608102124.14865-1-higashi@taiju.info> <20220608102257.15042-1-higashi@taiju.info> <87leu72sbo.fsf@taiju.info> <55fe6cdbed891707aca419ff4eedd7c37ef3eb03.camel@telenet.be> <87fskexiyc.fsf@taiju.info> <874k0uxhif.fsf@taiju.info> <5ccb68a4dc80a02baaf6d19fd782145b6b62e7b5.camel@telenet.be> <87a6alwdvn.fsf@taiju.info> <87r13wvrlz.fsf@taiju.info> <8250aad90dcf563aba4103127df95084a25fbd5d.camel@telenet.be> <87bkuzsap7.fsf@taiju.info> <87a6acjncd.fsf_-_@gnu.org> <8735g4nmyv.fsf@taiju.info> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Nonidi 29 Prairial an 230 de la =?UTF-8?Q?R=C3=A9volution, ?= jour de la Pivoine X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 17 Jun 2022 14:39:37 +0200 In-Reply-To: <8735g4nmyv.fsf@taiju.info> (Taiju HIGASHI's message of "Fri, 17 Jun 2022 09:38:16 +0900") Message-ID: <87zgibh3au.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655469642; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=CXX4CmYVf2CgNqXPCq2/9FtL8H1Uv9o3V/ul0laG5KA=; b=ZlaxvT7Sf5Gvs2In+p4USr6NwjPVBrGo6BXdYZTAA6AcQnLwy2fFxxa7xsGh1QxfJKAGSc y/Utdc0DLCfhJ3YoPhTYeDKZTmYydsr3Q6oIDrxj4oDGH1JOR3EBvC0BFa2JdKCmHevqoJ Lu2nBQXW3WcEhD8rT5PdeViZLGEZuxHDdchLitxbmnZ99Wvy+9HB1S9LbOICcfCudoM3f5 APZ5nxyGXMHA4P6V34GGMqpiDRE05R8Q7sbhcBdnMWe72l3Y8AuBVHgQHCg0JpiEp9IxEY oQ+OH6PTMVUb+bM8Z/703KjFcmClaKgCR9aYrS9H3GF7iRL5D4/+DPABO0c3wA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655469642; a=rsa-sha256; cv=none; b=YH7i1RlQuFnNi0XtWkMqXlcBXOb0OhrzC9p5u3NPxSqMJlu/lmnAgqeQm7AhCXaiUBYS18 JpmCe7GgXeZVfKmJy0IOnuc+NT6J3htAq+VcHlCkW7Y87yiqPiI5K7UlLbWPyienbCLoRR 1ewQA4zPzpQYqInFsAiX1qfBJ8WnDyL+iDAVN5Aw5NjwI1JNbj016fJGJk58W+/OEiurCG lYsmtWo5BHKqpAuNYqd5jeUwl7CUifEAyR537xayIlXzXboUUBz9PJfWTqs6508tzoN1ba 1bDAdReFGyeShyk1pBmDY/5c0fRwe5PSTln6pLca3fKtKScuycDxRmOeDDgm6w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=EZN3T8nY; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.89 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=EZN3T8nY; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 03699575F X-Spam-Score: -3.89 X-Migadu-Scanner: scn1.migadu.com X-TUID: sPPbXVJzGmrK Hello, Taiju HIGASHI skribis: > I only discovered the problem, I was able to implement it mostly thanks > to Maxime and Tobias! > The code review experience was so good that I even posted the following > :) > https://fosstodon.org/web/@taiju/108458633893022791 > https://fosstodon.org/web/@taiju/108458643302758263 Heh, good to know that it was a positive experience! > I'd like to know for future contributions. > I like functional programming and I love compose, (ice-9 > curried-definitions), and SRFI 26 in my programs, but should I use them > less in the code I put in Guix? Probably. It=E2=80=99s tempting to use these if you come with a Haskell background, say. But in some cases, they make things less readable; that=E2=80=99s the case with the way =E2=80=98make-dummy-file=E2=80=99 was = written IMO. Guix code uses SRFI-26 in some places; I think (ice-9 curried-definitions) is not used anywhere but I think it=E2=80=99s fine to = use it if it helps. Thanks, Ludo=E2=80=99.