* Re: 04/07: guix: Add compression module.
[not found] ` <20220911120929.95761C04F09@vcs2.savannah.gnu.org>
@ 2022-09-11 20:55 ` Ludovic Courtès
2022-09-12 7:38 ` Mathieu Othacehe
0 siblings, 1 reply; 2+ messages in thread
From: Ludovic Courtès @ 2022-09-11 20:55 UTC (permalink / raw)
To: guix-devel, Mathieu Othacehe
Hi Mathieu,
That’s a long-overdue factorization, but…
guix-commits@gnu.org skribis:
> +(define-module (guix compression)
> + #:use-module (guix gexp)
> + #:use-module (guix ui)
> + #:use-module ((gnu packages compression) #:hide (zip))
… a (guix …) module Should Not refer to a (gnu …) module¹. When it
really has to, it should be via lazy-loading at run time, as is done in
(guix build-system …).
While I agree this should be factorize, I wonder if this should be
promoted to (guix compression). The module name intuitively is a better
fit for the compression-related things currently in (guix utils).
Not sure, maybe (gnu compression) would make more sense?
Ludo’.
¹ For questions of abstraction layering, and also because that’d break
“make as-derivation”.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: 04/07: guix: Add compression module.
2022-09-11 20:55 ` 04/07: guix: Add compression module Ludovic Courtès
@ 2022-09-12 7:38 ` Mathieu Othacehe
0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Othacehe @ 2022-09-12 7:38 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel
Hey Ludo,
> While I agree this should be factorize, I wonder if this should be
> promoted to (guix compression). The module name intuitively is a better
> fit for the compression-related things currently in (guix utils).
>
> Not sure, maybe (gnu compression) would make more sense?
Thanks for noticing that. I moved this module to (gnu compression),
checked that make as-derivation is working and updated the wip-image
branch accordingly.
Mathieu
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-12 7:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <166289816138.13336.500773351208601134@vcs2.savannah.gnu.org>
[not found] ` <20220911120929.95761C04F09@vcs2.savannah.gnu.org>
2022-09-11 20:55 ` 04/07: guix: Add compression module Ludovic Courtès
2022-09-12 7:38 ` Mathieu Othacehe
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.