From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yClLE4rFNWNTcgEAbAwnHQ (envelope-from ) for ; Thu, 29 Sep 2022 18:19:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id qKcpE4rFNWNf3QAA9RJhRA (envelope-from ) for ; Thu, 29 Sep 2022 18:19:22 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 14C4F2B55B for ; Thu, 29 Sep 2022 18:19:22 +0200 (CEST) Received: from localhost ([::1]:34070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odwFt-00009b-5f for larch@yhetil.org; Thu, 29 Sep 2022 12:19:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37786) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odupW-0007hp-HM for bug-guix@gnu.org; Thu, 29 Sep 2022 10:48:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40167) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1odupW-0008Ff-9a for bug-guix@gnu.org; Thu, 29 Sep 2022 10:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1odupW-0007Zs-53 for bug-guix@gnu.org; Thu, 29 Sep 2022 10:48:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#58084: guix deploy fails, leaving the newly installed system generation active Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 29 Sep 2022 14:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58084 X-GNU-PR-Package: guix X-GNU-PR-Keywords: notabug To: Maxim Cournoyer Cc: 58084@debbugs.gnu.org Received: via spool by 58084-submit@debbugs.gnu.org id=B58084.166446284428992 (code B ref 58084); Thu, 29 Sep 2022 14:48:02 +0000 Received: (at 58084) by debbugs.gnu.org; 29 Sep 2022 14:47:24 +0000 Received: from localhost ([127.0.0.1]:39245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oduou-0007XY-IR for submit@debbugs.gnu.org; Thu, 29 Sep 2022 10:47:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oduos-0007XH-6M for 58084@debbugs.gnu.org; Thu, 29 Sep 2022 10:47:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59880) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oduom-0008BK-VI; Thu, 29 Sep 2022 10:47:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=8h9OxXEx7lAlwgXKyzUHqibO4XqJTkfsQDAQg4M96M0=; b=evEqpg/Ab2yYGwZUAVPT tLrc+1VySCCdfkqiUj84V30ExHjXNENyHJ4oyHDbISVB2RSTRlIoJyrSXEUndPSUWLNIYYgpW56bY BFtUP9dq2PBGsWGsjBv+3gwQmWh7EYsrB1hYtpnrD9xYdyqACWu0o8Uboh59v95H0YIsSM+wI1p3E bG4GBF9UpzgB6rVbAH8yYKo0rUFyYT6mCwOOHvtWdB8j92e7C4nDC8f+r85A4wkeVS/4OEnpeLvGf qi750cg2lnwFdzH07U0YFQftgPUqHmdN6R0Wtq0tq/wxoU35VTljbmF202RdDyF3JE/14cm3iS9OY MeLIvsYOeyu15w==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:58714 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oduom-0007uu-Gc; Thu, 29 Sep 2022 10:47:16 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <8735ce7tdv.fsf@gmail.com> <87h70ukuuz.fsf@gnu.org> <87h70uyqoj.fsf@gmail.com> <87a66myqlg.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Octidi 8 =?UTF-8?Q?Vend=C3=A9miaire?= an 231 de la =?UTF-8?Q?R=C3=A9volution,?= jour de l'Amarante X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 29 Sep 2022 16:47:15 +0200 In-Reply-To: <87a66myqlg.fsf@gmail.com> (Maxim Cournoyer's message of "Mon, 26 Sep 2022 13:48:11 -0400") Message-ID: <87zgei9r0s.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664468362; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=8h9OxXEx7lAlwgXKyzUHqibO4XqJTkfsQDAQg4M96M0=; b=GXM/iV5XeT4qiqufcHI1yZVd88cILKtFveeooKgYdda7qEGnhCGlZ/T1RvwZ1bAY8xd0wy CMxBJqpiMByLgW/BjLCyH5bZl1Q+4oyvUYtQ462Bch7p+v46l/pthQ2pkTx8HZvzwOxXcS yYj1ummFaSwB9APwpNE0tci4Y7251BfDDGPF5XRB8e52UKB7WvgBZ5AjEb3AL79t+jEyVN ZArUwkjQb75rAsWaRT35LuXD7N2JBLicy9dUYGBOi6H/IWsfrfUrZJuN3W1PdK+hn9P5AY 0n9SA5iJevMuOEbMVkliJ62wgtyIpumO1dE3tskrRzJvPSacWLmYBD+RmoS2ng== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664468362; a=rsa-sha256; cv=none; b=C/V1yH449GyKT0YojeYAZzhLdlNUM6vwIMETYbH8SbWYaQ2ppJN+IVibSXliENj288X1Xs TCpnWym/l7wkJuFUrF/+MLY8PUtO5HDvP1o3DXrryzup1Lg/WAglHlAzg5OoU1QYOlQ7g5 nSdlaMsQEWHRpryS7CzIonTto9tX+6muplI/DudOD7UMcK7sbjriAGQiM0ENjea9UYd+d7 l7h/v2d41ZVjbkqPC4hXcFUImo0uLPxNumlWtdFguHXf+pVdhjc/76bwTv+xQD/qty7+fY YEanlYxpcnyHtIhw4DgwRXGI1nqiQl0cqNiMC5L/+OUr0eOC58dm0hgl1SM+cg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="evEqpg/A"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.54 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="evEqpg/A"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 14C4F2B55B X-Spam-Score: -2.54 X-Migadu-Scanner: scn0.migadu.com X-TUID: 0hZ78TmoHOV3 Hi, Maxim Cournoyer skribis: > Maxim Cournoyer writes: > > [...] > >>> =E2=80=A6 which is fine, except that there was already a pre-existing >>> /etc/modprobe.d directory (coming from openSuSE, the distro that was >>> initially installed on this machine), which caused this activation code >>> to break: >> >> Oh wow! Should we be extra careful and always rm files before linking to >> their location? Or define our own 'symlink' procedure that'd take care >> of it? That's not very elegant but better than obscure crashes like >> this. > > I just had a better idea: fail and report that an unexpected file was > found there, leaving the user to inspect it and choose a proper action. Yeah, that=E2=80=99d be nice. It=E2=80=99s really a corner case that you= =E2=80=99ll only hit when installing on a non-empty file system, but gracefully handling it would be nice for sure. Ludo=E2=80=99.