From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id kKYtD2DXQ2MLuAAAbAwnHQ (envelope-from ) for ; Mon, 10 Oct 2022 10:27:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 2LBTD2DXQ2MMQQEA9RJhRA (envelope-from ) for ; Mon, 10 Oct 2022 10:27:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E4BF3A66D for ; Mon, 10 Oct 2022 10:27:11 +0200 (CEST) Received: from localhost ([::1]:37270 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oho7y-0005dJ-WB for larch@yhetil.org; Mon, 10 Oct 2022 04:27:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohnje-000867-Pp for bug-guix@gnu.org; Mon, 10 Oct 2022 04:02:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46725) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohnje-0006aL-EQ for bug-guix@gnu.org; Mon, 10 Oct 2022 04:02:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ohnje-00062n-18 for bug-guix@gnu.org; Mon, 10 Oct 2022 04:02:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#25018: GC incorrectly removes the temporary root file of the calling process Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 10 Oct 2022 08:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25018 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxim Cournoyer Cc: h.goebel@crazy-compilers.com, Eelco Dolstra , 25018-done@debbugs.gnu.org Received: via spool by 25018-done@debbugs.gnu.org id=D25018.166538888923193 (code D ref 25018); Mon, 10 Oct 2022 08:02:01 +0000 Received: (at 25018-done) by debbugs.gnu.org; 10 Oct 2022 08:01:29 +0000 Received: from localhost ([127.0.0.1]:45803 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohnj6-000621-Uj for submit@debbugs.gnu.org; Mon, 10 Oct 2022 04:01:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohnj5-00061n-5J for 25018-done@debbugs.gnu.org; Mon, 10 Oct 2022 04:01:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55040) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohniw-0006Rj-0g; Mon, 10 Oct 2022 04:01:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=F387zBzV1EZHUmrtfp59kmZu0clPy8pDK848XD5x17Y=; b=OzjOJNXNLo3TxYbuTc0H cHU/qdUUMcTZTd55qsAaZn/Q4KqyW9XLoJAwEw5p5koxPxyE60mTVO2Bid5vevJT3VkjYQo+kL79P 6jzCS/QVp/k5CtedxoEMhj78L4ooeCBGfh4XnpQw88XZ127sl99EfgF02dytkOCB9XNiw8buwuTnZ K6o+RO6xDlAUCVXvS6Px0yM3cNDovnYo/FDTBunWGnssJ+lEHCIhjhgGeZB4FnApSyeqtJOw5/awi +l2NmUXvzze6O+FVgWkvV20qeZM7yM4Qes8uMZ6PX4I9LAwKB4HIT5l7zjQo/x3Zdvwfubps8QQAG 8N2wh6IqL1mNaQ==; Received: from [193.50.110.253] (port=38668 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohnii-0008Ou-2E; Mon, 10 Oct 2022 04:01:07 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87d1hl55ur.fsf@gnu.org> <87pmf34afr.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Nonidi 19 =?UTF-8?Q?Vend=C3=A9miaire?= an 231 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Tournesol X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 10 Oct 2022 10:01:01 +0200 In-Reply-To: <87pmf34afr.fsf@gmail.com> (Maxim Cournoyer's message of "Fri, 07 Oct 2022 16:59:20 -0400") Message-ID: <87zge43y6a.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665390431; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=F387zBzV1EZHUmrtfp59kmZu0clPy8pDK848XD5x17Y=; b=JGRGSR8kpSEhJHGnRGcrnQNIekuvqVs2BRN9BJLn/h2eJ/M1+KNz7fUHmZpnikjyrFp5vo hNkKNHbXWFWTmlexECvchfhGIFqBUuBaahxAjBREPquVbX/bzyq4Wvn9bMz6hsHMiaBNF8 ONgMbnSkAtMjFc2Ggnc+tk1vq5DVTtTnGOVtHwBTxq3UqKX20Fr+0xtr446jOtneIKlFfb njjcUlQKAbYjv0fUqvdJQXIolqfmz0jiev4HkmX0AXdO5BdSKon9IJVb1n8PVoIoM1P8GG dcjDAvU02JdS0arzIn83/GW4ABaPSSzWEXJz3vmrOCI9cqPelaVoOgwwOWmwPA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665390431; a=rsa-sha256; cv=none; b=iwhgMxILwrcqVGm0oTIHuNsyVdeazg/znyyUbZQaSIAhmCeLAY2CcRiY430q2FGY0T/+fW 81Mw4XCX21iXg6Bchb7YwRZmDYL7tiynu62s4uJvI4o8aucUpaMnGYwPIeMl4lRJjxkIsj SfeIGCn7B5Azaid4ZHWXKfN1za29FcKecDY3P8eqCghvpKtzKd3DsVUnaCkVeykWQnCJPW FjN/kEPV7NKWdU0XkRFpSL9NN/fP/LKkN80a+Wgn/daI8YraONxvxSBCmFdzx0wB3Pz4SJ 7hIY8yWAeK3eParIuoxEVzDtiiUtmtEXt4M3ymzlL9Wcoqh4zoNE+PXWh4WFKw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=OzjOJNXN; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.28 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=OzjOJNXN; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E4BF3A66D X-Spam-Score: -2.28 X-Migadu-Scanner: scn1.migadu.com X-TUID: ht70braidCNt Hi Maxim, Maxim Cournoyer skribis: > I'm not Eelco, but your change LGTM. Note that the upstream version > still uses the original code [0]. Right. > I've installed the change, tested that it had the expected result: > > reading temporary root file `/var/guix/temproots/8386' > waiting for read lock on `/var/guix/temproots/8386' > got temporary root `/gnu/store/0siy93lggjw7sfdg8gsvrzafaa974h2d-foo' > considering whether to delete `/gnu/store/0siy93lggjw7sfdg8gsvrzafaa974h2= d-foo' > | cannot delete `/gnu/store/0siy93lggjw7sfdg8gsvrzafaa974h2d-foo' becau= se it's a root > | cannot delete `/gnu/store/0siy93lggjw7sfdg8gsvrzafaa974h2d-foo' becau= se it's still reachable > ice-9/boot-9.scm:1685:16: In procedure raise-exception: > ERROR: > 1. &store-protocol-error: > message: "cannot delete path `/gnu/store/0siy93lggjw7sfdg8gsvrzafaa= 974h2d-foo' since it is still alive" > status: 1 > > and pushed! Thank you! (Your bug triage work is much appreciated!) We could turn the example here in a unit test; the only downside is that running the GC in a test is expensive. Ludo=E2=80=99.