From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id qFDtFEqTe2NMsgAAbAwnHQ (envelope-from ) for ; Mon, 21 Nov 2022 16:03:38 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 6MTKFEqTe2N8CwEAauVa8A (envelope-from ) for ; Mon, 21 Nov 2022 16:03:38 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1B2EE1641E for ; Mon, 21 Nov 2022 16:03:38 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ox8K9-0000HA-4K; Mon, 21 Nov 2022 10:03:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ox8K7-0000Gk-DG for guix-patches@gnu.org; Mon, 21 Nov 2022 10:03:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ox8K6-0001OM-9a for guix-patches@gnu.org; Mon, 21 Nov 2022 10:03:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ox8K6-0008FD-4u for guix-patches@gnu.org; Mon, 21 Nov 2022 10:03:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#58812] [bug#59164] Coding style: similarly-named variables Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 21 Nov 2022 15:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58812 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 59164@debbugs.gnu.org, 58812@debbugs.gnu.org Received: via spool by 58812-submit@debbugs.gnu.org id=B58812.166904296931654 (code B ref 58812); Mon, 21 Nov 2022 15:03:02 +0000 Received: (at 58812) by debbugs.gnu.org; 21 Nov 2022 15:02:49 +0000 Received: from localhost ([127.0.0.1]:48448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox8Js-0008ET-LR for submit@debbugs.gnu.org; Mon, 21 Nov 2022 10:02:48 -0500 Received: from mail-wr1-f54.google.com ([209.85.221.54]:34633) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox8Ji-0008Do-7e; Mon, 21 Nov 2022 10:02:42 -0500 Received: by mail-wr1-f54.google.com with SMTP id s5so3058051wru.1; Mon, 21 Nov 2022 07:02:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=I4Y6SfsgqjKChPZM8JJeYtcbXRrdExtrTZ1SAk97xoQ=; b=jqo95tjL0rm+nb+inIiT/pdbIQWh2gJsuSfpvcAOUQ/XPDhkpntSkePrprpPj96iVK P9G+xXU58QJ7rHls84deosP9BWhB90JI1vtg48Rkz2vsqx062MyxIxz5zF6pMi9sQy2z 3CzTUZ/o9smUZLhgKnTSws4H/cv4fAr8akrM9saNrRjjHjfWK999nhwhCllAkdMXD8Po UbHs4xpssvX6bqZjza5Nnyo60Mvjop8eCojulgWAUFa8DUgFSAEjnTMwEsBBhlc+lF8V ahjL64SgfDTF4LTCJRzX2HQUcxcwESPDhx2ecioWxYaRjFm+CEGXcqIwH7VR+LDpR8cl vu6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I4Y6SfsgqjKChPZM8JJeYtcbXRrdExtrTZ1SAk97xoQ=; b=ATL8H4o8sCcmpwR1uqaSfdvIhTvbQX2HxAVJLsaz/KruJF19CqtcMF9kDbud3GbQPa /H0Q+E8fPM2eSgG9nzERcAwmup7eMN973pwPgXjcztsZp3Q2OX50FXM8O1/soAyLUIEG ELc5rl/Btb/G6gylPX+DrN+esbUcBMNRIonU8Rrq8cVoTriOehtunCO76gZxtmB75wG7 4u4W3BhPrBS0D6GbQLE233T56qwH7kgudWA/RyK5WjqlJUG2cZlI1LezlrXMrb31NXl+ qEDHIi0bfZnDaq+3XIVahOnXmiTsA9J7IDu5ocULB1dS9Nv1RHptijQTA8pMc8PVzWFr Rhmg== X-Gm-Message-State: ANoB5pmc1bwJiiYxhBIb/DM3mpJ9UCm7/+BRb8H3/VcRe0C3OEvLBgS+ XBrvJTZUqBpjAFSSv+0fVQWak6RdPYM= X-Google-Smtp-Source: AA0mqf60WhkqmdZgsN4dUJbgKn9DWFwH+FcURRsEzmkipBxaQDRUgTnQmoEnC0kIDbmcLrN9GMOkuQ== X-Received: by 2002:adf:f8ca:0:b0:241:c933:4b0e with SMTP id f10-20020adff8ca000000b00241c9334b0emr4613716wrq.48.1669042946973; Mon, 21 Nov 2022 07:02:26 -0800 (PST) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id f3-20020a5d4dc3000000b0022e57e66824sm13111119wru.99.2022.11.21.07.02.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 07:02:26 -0800 (PST) From: zimoun In-Reply-To: <87y1s82o23.fsf@gmail.com> References: <20221027035100.28852-1-maxim.cournoyer@gmail.com> <20221027035100.28852-3-maxim.cournoyer@gmail.com> <87leojon1z.fsf_-_@gnu.org> <877d03xywl.fsf@gmail.com> <87sfihfpng.fsf_-_@gnu.org> <86zgcpju9p.fsf@gmail.com> <87y1s82o23.fsf@gmail.com> Date: Mon, 21 Nov 2022 16:02:19 +0100 Message-ID: <87zgckwdtw.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1669043018; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=I4Y6SfsgqjKChPZM8JJeYtcbXRrdExtrTZ1SAk97xoQ=; b=R6nE/s4zh8QYTrNyowTKEClGrZ8zOfkwS+B0cJG/7hS9G2UMmHzPnoLI/vZcr5p8cYhkNZ A8h4YY0SOxj60/BXE8XdybSsZ4FvKOWcVJkbQPPRvsQlNbWujoV5gte+TERlAI+OTvLRzw Zb19LHXVSZi2EtJ51ivyrT1VjIL7htXZUbQYAY4jwgjgEga5gL4MTmCVTlepn4YyGICdQr TUCNNFBOvcbgvs/w4wICYiCYE4jHvg+utOKY9JGcWzlnuFj1pffCdsrBNEL/UNOiPbs9Y4 p/QTIsQdZk4GqgMU4u9fw+EAqphzMjaVdp66GXPm5SXz573wNI2E0Qwf9fJ9qg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1669043018; a=rsa-sha256; cv=none; b=fHGGoGGx9lEB01k3DPxdwTbKIZxlZLr+Xt9HYGPI4lALkVzvO35EcrW6ILS6cXwvmZrUDg jWorMent7j4SgLLD0/WEEMARENI1fJJttBDVRIdEdtD1I8f/2qj4Z3rxP2po12MI9SH5JI Sq5CbnsEAZBS+F+ugJlymIy2VmgMbdYyHbETkfhTVXyJDyk+pme6athGqIQNZzRYODLhS+ bcJ5WYC3IUt+G/Pq/DfeysKo3yMROz8kTRUQowKYPhv8EP54LQpu7d9rrEUsC7S6GhkPax J3DcIFizvvFwGFs6MWzYIdpUbU/ER6kTcg/L0Z6brq6A9fcvLPtO46rTvt0wXw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=jqo95tjL; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.49 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=jqo95tjL; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 1B2EE1641E X-Spam-Score: 7.49 X-Migadu-Scanner: scn0.migadu.com X-TUID: nW/jhNJq5aAQ Hi Maxim, On Fri, 18 Nov 2022 at 12:02, Maxim Cournoyer w= rote: > The intent was to keep away from the following imperative style, which > hurts both readability and debuggability in my opinion: > > --8<---------------cut here---------------start------------->8--- > (let* ((my-target "something") > (my-target (mutate-once my-target)) > (my-target (mutate-twice my-target))) > (do-something-with my-target)) > --8<---------------cut here---------------end--------------->8--- Well, =E2=80=99mutate-*=E2=80=99 is not really mutating. Maybe I miss some= thing and from my understanding, this =E2=80=99let*=E2=80=99reads, --8<---------------cut here---------------start------------->8--- (let ((my-target "something")) (let ((my-target (mutate-once my-target))) (let ((my-target (mutate-twice my-target))) (do-something-with my-target)))) --8<---------------cut here---------------end--------------->8--- and not, --8<---------------cut here---------------start------------->8--- (begin (define my-target "something") (set! my-target (mutate-once my-target)) (set! my-target (mutate-twice my-target)) (do-something-with my-target)) --8<---------------cut here---------------end--------------->8--- Well, the former is =E2=80=99lexical-scope=E2=80=99d so the 3 =E2=80=99my-t= arget=E2=80=99 are not truly an imperative style, I guess. Back to the pattern, you are suggesting to write, --8<---------------cut here---------------start------------->8--- (let* ((my-target "something") (my-target* (mutate-once my-target)) (my-target** (mutate-twice my-target*))) (do-something-with my-target**)) --8<---------------cut here---------------end--------------->8--- well, I am not convinced it helps for readibility. And I think, the pattern is manually doing what =E2=80=99let*=E2=80=99 is already doing for = you. Cheers, simon