all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Phil <phil@beadling.co.uk>
Cc: Wojtek Kosior <koszko@koszko.org>,
	 Philip McGrath <philip@philipmcgrath.com>,
	 guix-devel@gnu.org
Subject: Re: RFC: libgit2 is slow/inefficient; switch to git command?
Date: Wed, 23 Nov 2022 23:04:23 +0100	[thread overview]
Message-ID: <87zgche3a0.fsf@gnu.org> (raw)
In-Reply-To: <87k03mu1w5.fsf@beadling.co.uk> (phil@beadling.co.uk's message of "Tue, 22 Nov 2022 21:15:22 +0000")

Hi,

Phil <phil@beadling.co.uk> skribis:

> In particular we were forced to make this change to our local guix build
> to ensure that guix behaved inline with git:
> https://github.com/guix-mirror/guix/commit/473954dd92bbb84693b6fa3f007752eb53c804db
>
> An explanation of why, was raised with libgit2:
> https://github.com/libgit2/libgit2/issues/6183
>
> The original guix-devel discussion here:
> https://lists.gnu.org/archive/html/guix-devel/2022-03/msg00021.html

I didn’t follow that but perhaps there’s something we should do in Guix
proper?  Maybe not exactly this change though, because it might be a
performance hit, but it’s worth discussing.

> This particular issue is somewhat niche - but it demonstrates well the
> danger of assuming the libgit2 and git behave in the same way!

Whichever implementation we use is going to behave differently from Git
in some cases (unless we use Git, that is).  But I think that’s okay, we
can smooth out issues.

Thanks,
Ludo’.


  parent reply	other threads:[~2022-11-23 22:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-22  2:21 RFC: libgit2 is slow/inefficient; switch to git command? Maxim Cournoyer
2022-11-22 15:39 ` zimoun
2022-11-22 16:49   ` Philip McGrath
2022-11-22 17:51     ` Wojtek Kosior via Development of GNU Guix and the GNU System distribution.
2022-11-22 21:15       ` Phil
2022-11-23  9:57         ` zimoun
2022-11-23 22:04         ` Ludovic Courtès [this message]
2022-11-23 22:16 ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgche3a0.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=koszko@koszko.org \
    --cc=phil@beadling.co.uk \
    --cc=philip@philipmcgrath.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.