From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SGEmCBjcgGMvaQEAbAwnHQ (envelope-from ) for ; Fri, 25 Nov 2022 16:15:36 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id KHzWBxjcgGOpIwEAauVa8A (envelope-from ) for ; Fri, 25 Nov 2022 16:15:36 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D09971E011 for ; Fri, 25 Nov 2022 16:15:35 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyaQ2-0003Lv-Jh; Fri, 25 Nov 2022 10:15:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyaQ1-0003Ll-2C for guix-devel@gnu.org; Fri, 25 Nov 2022 10:15:09 -0500 Received: from mail-qt1-x835.google.com ([2607:f8b0:4864:20::835]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyaPz-0001yY-1c; Fri, 25 Nov 2022 10:15:08 -0500 Received: by mail-qt1-x835.google.com with SMTP id c15so2677753qtw.8; Fri, 25 Nov 2022 07:15:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=Wy6Y8dYrsU+pxnK6ir+7/eOFU+rMvXOjSdJelaUtV54=; b=ThXwoC1lH3U4ZRH7bkHwNix9yZE8pKHj4EFuX6AL5ULqAORaSCCZ5Jinx7PVCXf4eO jk0qJNR7Lqz+Y5qYexyviGmQL6mpUbZLCe/cxNd4m2IDvyiYY6hU71SyjNBFSLuJCZiS UA78mE/j9++jcSXj4YHONAU4eAsOjb/VgsU+gW4XfzbtB1thTDrfsW8wl8QXLfnT13JF x/eC0jX2v9fBquCQ0I0jeCrQtpDORa9Y6B+xlrbSu+SpDEx/BnP1lF08HZvui/Qr5l/U SHG2983iqYxKQZxZOlL4r+24ob32fjQVC67JyBAefVerxF9B3IxyxMA64GFnLpZj4ASv X63g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Wy6Y8dYrsU+pxnK6ir+7/eOFU+rMvXOjSdJelaUtV54=; b=Kem4ztReNpKLhPdi5xFajjx0V7UvT+eAXH20t2ahIXeJboVn5G0D5S7syt9LuHBYu4 SKRqu7yZyx7EOZ1c70qYbxqubVgLkHWJ8FGwpMP/C3E6Nn3o4AhSGdx1W2dwbMiUiaDL B49BLYASO4+6vEB/WEudXdBQNBCPuGFIJihb8hvIFOonL8lzuDeIgE/WgDAfw9F7pggB Wj5pfnUpQ2b8z423/WB7NqyMG9Cw4elVt6kg/NGSVPt9otw2ErruZeGK1HtuLcs0E+pE 4fSXjs1k6qUvknw65S7AfKsHWwZv1eK066KqJ51NJCr+UybpUpUg7fEtyGkeVBonLNz7 gUzA== X-Gm-Message-State: ANoB5pmNvhW86qHsTpe+Kg79g/XJ52R8T2WdlWvilclZL/ymrjMhbfwv CnDbvcTlks9r4of1dgI8DZHbIXlVBoLvBg== X-Google-Smtp-Source: AA0mqf5+9anufe0Q8PhGlScz0elJ1fcL2WMOmcLTYUzalTQXaksCG0QsjzozuR/jUZ8KFJB4hKBdIA== X-Received: by 2002:ac8:604e:0:b0:3a2:9fcd:59c8 with SMTP id k14-20020ac8604e000000b003a29fcd59c8mr21751696qtm.273.1669389304708; Fri, 25 Nov 2022 07:15:04 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1003]) by smtp.gmail.com with ESMTPSA id az36-20020a05620a172400b006fc3fa1f589sm2874876qkb.114.2022.11.25.07.15.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Nov 2022 07:15:04 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Subject: Re: Layout of =?utf-8?Q?=E2=80=98define-configuration=E2=80=99?= records References: <20221029034716.11125-1-maxim.cournoyer@gmail.com> <20221029041649.12144-1-maxim.cournoyer@gmail.com> <87zgcpdx6q.fsf_-_@gnu.org> <8735ag43ga.fsf@gmail.com> <87zgckli8u.fsf@gnu.org> <87edtwqa87.fsf@gmail.com> <874jupfi70.fsf@gnu.org> Date: Fri, 25 Nov 2022 10:15:02 -0500 In-Reply-To: <874jupfi70.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Wed, 23 Nov 2022 22:56:51 +0100") Message-ID: <87zgcfjcax.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::835; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x835.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1669389335; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=Wy6Y8dYrsU+pxnK6ir+7/eOFU+rMvXOjSdJelaUtV54=; b=AXGFfcXBu+JwCk3a9GedGZDeN4SyAKXBC7gIoCO0JFfTDaI7YyqR2fCkPlc9ij3yUp2fsA nylOKTfePFlGPkT9P9Q06qvwLFNRRYnItuoX4elorhP38iJNinhGvDOFqmULBVi8/s18Xs mN2JppwDdNl6lnipQzVUvXy80iok5PObJ21p8wyVJy207V6z5kFhNnEjq3tLN1uf4oGuwc idWXfX97eA6m/DYTFdTANMsUR75BUUWIhIN7VBMkQwTacVqPkg/D9lwZvvNiRpfOjRLLIT y6P8vq6NmZ1mOcXJSGPjfYct2b4eu+z4IroCZQw+N5mViD9zfsNe8Zn8j96Zhg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1669389335; a=rsa-sha256; cv=none; b=TYDiq3zdQj6xoie24lSNuYyfydorkvTJcvfaHmD3XTO7Z/gzhplqmCNnue629StYujrHZc w+EDHbEgapC4/JwsevXJy4SMdz9Az6b3IC2oZhpbrNTdstJSihIDmQSbm9XIjsJpSSNwEU jiUMWMTSgd+17+C5YelL8fP6OSjOKRb/Tu557fWk9anCq5x1pllCzuBl9us8R2MmqmTtn5 xUW4Ix0mzn1dC1HF7qrWOqeNug7gMWRAsPnr1KRAzXJtCsTPUvbESUd8HqhHuZeWFM7qGy 5HkSgRhIF8hNGnQIzUxqV9aEIZXGV+Fo4d8CIw4Wy9gt/TsOrympxisZANNyMg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ThXwoC1l; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.07 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ThXwoC1l; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D09971E011 X-Spam-Score: -6.07 X-Migadu-Scanner: scn0.migadu.com X-TUID: AH3Aj56qOzKd Hi Ludovic, Ludovic Court=C3=A8s writes: > Hi, > > Maxim Cournoyer skribis: > >> Ludovic Court=C3=A8s writes: [...] >> Ah! Thanks for pointing my silly mistake. Then the argument would >> become... if it's good for define-configuration, it should have been >> good for define-record-type* the same (why the discrepancy?). > > =E2=80=98define-record-type*=E2=80=99 is generic; there=E2=80=99s no reas= on for it to add a > =E2=80=98location=E2=80=99 field. > >> After your new documentation in place to guide users to DTRT with >> regards to matching records, if you think %location should be the first >> field, then we should make it so in both instances, perhaps? > > =E2=80=98%location=E2=80=99 only appears in =E2=80=98define-configuration= =E2=80=99; what did you mean by > =E2=80=9Cboth instances=E2=80=9D? Hmm, that's right. Nevermind, I thought the later had a %location "special" field too. >> Oops! Another point to add to our future coding style guidelines :-). > > In the end, I guess the lesson is that, indeed, not all the design > choices and rationales are properly documented. That=E2=80=99ll always b= e the > case to a large extent though, so changes =E2=80=9Cclose to the core=E2= =80=9D require > more careful review and discussion to fully understand the implications > of the change=E2=80=94it might look innocuous but have broader implicatio= ns than > expected. Agreed. I'll try to make better use of the etc/teams.scm script in the future to ping the right people for such changes. --=20 Thanks, Maxim