From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id CBolLJVdo2NBLQAAbAwnHQ (envelope-from ) for ; Wed, 21 Dec 2022 20:25:09 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id uAkcLJVdo2P80wAAauVa8A (envelope-from ) for ; Wed, 21 Dec 2022 20:25:09 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 78B522B191 for ; Wed, 21 Dec 2022 20:25:09 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p84i9-0004vE-5s; Wed, 21 Dec 2022 14:25:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p84i7-0004v4-DM for guix-patches@gnu.org; Wed, 21 Dec 2022 14:25:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p84i7-0001ZN-4X for guix-patches@gnu.org; Wed, 21 Dec 2022 14:25:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p84i6-0001Sb-Ho for guix-patches@gnu.org; Wed, 21 Dec 2022 14:25:02 -0500 Subject: bug#60055: [PATCH] scripts: system: Skip initrd modules check when using --target. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Wed, 21 Dec 2022 19:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 60055 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 60055-done@debbugs.gnu.org Mail-Followup-To: 60055@debbugs.gnu.org, maxim.cournoyer@gmail.com, maxim.cournoyer@gmail.com Received: via spool by 60055-done@debbugs.gnu.org id=D60055.16716506695593 (code D ref 60055); Wed, 21 Dec 2022 19:25:02 +0000 Received: (at 60055-done) by debbugs.gnu.org; 21 Dec 2022 19:24:29 +0000 Received: from localhost ([127.0.0.1]:53521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p84hZ-0001S8-8n for submit@debbugs.gnu.org; Wed, 21 Dec 2022 14:24:29 -0500 Received: from mail-qt1-f172.google.com ([209.85.160.172]:39463) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p84hX-0001S1-4x for 60055-done@debbugs.gnu.org; Wed, 21 Dec 2022 14:24:27 -0500 Received: by mail-qt1-f172.google.com with SMTP id s9so14472017qtx.6 for <60055-done@debbugs.gnu.org>; Wed, 21 Dec 2022 11:24:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=qhCiKaDnC4MyVEKTslORmzE2V0EqmHFaFc/qwFcx4DY=; b=dOwoDrje2Hk7WioCqzItEj6pSXFi6Rzm9R7UDdBBGWl7fUYdhjpiVE0hnKHevz4rLp C4+AoBbr+IloR068SW9TeCftOKjIMRk4Hci1r4pvs/IIEeQ4OyrujWG3lAdpgyb7ygw1 8FXD4wISevZ0VjKr9sDf/zywE0sM06j797RdFJGG0GU9eYL3OQ7+HDtwND7Lt9x3AsrP MZkUd4W0MlAWsaVhiXZm1uF/gqhF/NL81Qnlh4jz4D7atPLv760j0PH5mE2oPndMl0W1 mFJ3B39TFQttIFnT/qQT9m8HnIIm9NR3KU/8mXJ/+aNd++hr+cZ4fkKySBl1Qho4ROYs TJew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qhCiKaDnC4MyVEKTslORmzE2V0EqmHFaFc/qwFcx4DY=; b=HV+TQwxsXld0IRjBmT5toXu41n/ANu+h4/uj/Rk66yrn7fU29zQ5tPck7AzZsqNBdV 5PLe+1k5KviVX0I5DzwWvlgnSOJ4fTE53GRP8hI8tbcAa4imJCUxlAiJBfkCnEV/Vve5 6NCFuDlvQTcrrSL0V6Tvy4JAojIHuUCMOVKMBeieeV9bv3gP+0VX9EzoABjHwvluHr5z aIVlWMDUrz2CDPxfqIwMsIGclvKSIwdE29yoghKbQCJpMLinPmlCamkpEkn2hqoFrBbL Qp08gePbO6TqEoubnBm3JNhtT1Z9eHafud2yG+9lR79YfrVfIoo1uEHPIrxtvcGs+GYV KaHg== X-Gm-Message-State: AFqh2krvMXiSAd1Gf4b3GOu4pyTScCtIcyKC1/e087OjEwAnOy4TTIFe Eb+BpdgaYvXsJUcqeHni5hEu+SxwN0iJIg== X-Google-Smtp-Source: AMrXdXs7GM+sQvX2XWfrROt7fDvI5cf/xxEJn/0AKZj3E76/D7UgsZ1+Jc9eq+ZJzO0WzMtbLO9t5A== X-Received: by 2002:ac8:70d0:0:b0:3a5:1ea1:bae2 with SMTP id g16-20020ac870d0000000b003a51ea1bae2mr3185749qtp.34.1671650661039; Wed, 21 Dec 2022 11:24:21 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1002]) by smtp.gmail.com with ESMTPSA id v18-20020a05620a0f1200b006cf38fd659asm11675464qkl.103.2022.12.21.11.24.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Dec 2022 11:24:20 -0800 (PST) From: Maxim Cournoyer References: <20221214015303.18991-1-maxim.cournoyer@gmail.com> <87wn6k518n.fsf@gnu.org> Date: Wed, 21 Dec 2022 14:24:19 -0500 In-Reply-To: <87wn6k518n.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Wed, 21 Dec 2022 14:34:48 +0100") Message-ID: <87zgbg36ho.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1671650709; a=rsa-sha256; cv=none; b=Avoix2b48FCXLs3b6uBM0tdbH0KE1BlgZODBUXwiWYYcb3tm23LxPYePuV6eFCHvOuE15u /e99FvEsHKJPzieOiV/wt1dnsGW2+ZLkm50dm2CVF7H16CyOQmwiVEEyCXrhckBn4VKzBr +R2P5MEq6Csv9jGbIIxyQ9xKPOdqrmgYTcFPNHZCQzIClGsk2ZFiKELSe6Ih53bGisqm8V 5PrzE+7/6mSQ0EVjubI/MBpFwSMoQxYg7QKtnJBam0fKAjsvWdCCNsqwSr+q7UE8GdCPQC Y75kxEZQRIAQO8vcvKQs37dygcwVM1asgR7Co7DcLSiKXymGf+ihp1urXXd1oQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=dOwoDrje; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1671650709; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=qhCiKaDnC4MyVEKTslORmzE2V0EqmHFaFc/qwFcx4DY=; b=nPvTqXhHa4EZdN6SH2kOYFTR5cmX+VGXnPZAG8/ldvMhK0XsKuhq2pJgalU8aIWUonzhBX aTtd/YmdxUjxMGJpY8TL8QgfL1jElXtwgdD4h9JUsI2SYpaAkLPiNfe0p9+L30iw2RPorf vlTqofF8x1pDKckh2EfACt/bwbnbpJBo7JbqBX3riPH90TudU7glo+MKlnlmWA/D3ij1oZ 3TJSr1OZVrheodvPUl3e2NLOHhwxAMZUABM5e/+o6dOvCLPp9xtPkQaBOVhvMaLSC6iPl1 +Na5564svV5rUhnEsxT6TN+55TFD35zUZSZQL1yKOojKpD+LnJlTi4LUXM4H0g== X-Spam-Score: -2.20 X-Migadu-Queue-Id: 78B522B191 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=dOwoDrje; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -2.20 X-TUID: 1P9n6/xzD6fF Hello, Ludovic Court=C3=A8s writes: > Hi, > > Maxim Cournoyer skribis: > >> * guix/scripts/system.scm (perform-action): Do not call CHECK-INITRD-MOD= ULES >> when the %current-target-system parameter is set. > > [...] > >> + (unless (%current-target-system) >> + ;; Skip the check if the user is making use of --target, as it = doesn't >> + ;; make sense in this context. >> + (check-initrd-modules os)))) > > s/doesn=E2=80=99t make sense.*/cannot be checked against the running kern= el./ > > Otherwise LGTM, thanks! Thanks for precising the comment. Applied with the suggestion! --=20 Thanks, Maxim