From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 6NTgAsmqrWOpCQEAbAwnHQ (envelope-from ) for ; Thu, 29 Dec 2022 15:57:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id yBzIAsmqrWNR4QAAauVa8A (envelope-from ) for ; Thu, 29 Dec 2022 15:57:13 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B0461344A6 for ; Thu, 29 Dec 2022 15:57:12 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pAuLF-00058R-35; Thu, 29 Dec 2022 09:57:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAuL9-00057Y-Cu for guix-patches@gnu.org; Thu, 29 Dec 2022 09:57:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pAuL8-0006cX-N5 for guix-patches@gnu.org; Thu, 29 Dec 2022 09:57:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pAuL8-0008DI-Fu for guix-patches@gnu.org; Thu, 29 Dec 2022 09:57:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60358] [PATCH v2 2/2] gnu: guile-gnutls: Update to 3.7.11. Resent-From: Simon Josefsson Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 29 Dec 2022 14:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60358 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 60358@debbugs.gnu.org Cc: vivien@planete-kraus.eu X-Debbugs-Original-To: Vivien Kraus via Guix-patches via X-Debbugs-Original-Cc: 60358@debbugs.gnu.org, Vivien Kraus Received: via spool by 60358-submit@debbugs.gnu.org id=B60358.167232576931329 (code B ref 60358); Thu, 29 Dec 2022 14:57:02 +0000 Received: (at 60358) by debbugs.gnu.org; 29 Dec 2022 14:56:09 +0000 Received: from localhost ([127.0.0.1]:60628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAuKF-00088m-OB for submit@debbugs.gnu.org; Thu, 29 Dec 2022 09:56:09 -0500 Received: from uggla.sjd.se ([178.174.241.107]:38426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAuK9-00084G-Qc for 60358@debbugs.gnu.org; Thu, 29 Dec 2022 09:56:06 -0500 DKIM-Signature: v=1; a=ed25519-sha256; q=dns/txt; c=relaxed/relaxed; d=josefsson.org; s=ed2110; h=Content-Type:MIME-Version:Message-ID:In-Reply-To :Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding :Content-ID:Content-Description; bh=aI5aUmd73L8r8V262fYTzlxYg3AL+vLXjNoaILIV5xc=; t=1672325761; x=1673535361; b=nikd4nqQJjQoVYv1MNrMtEp+xW4aYEO7g0h3F44HG0hn4RQOGvhFAurMWdyf7pb6RQcqs43W239 +twMEMas+CA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=josefsson.org; s=rsa2110; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=aI5aUmd73L8r8V262fYTzlxYg3AL+vLXjNoaILIV5xc=; t=1672325761; x=1673535361; b=Dyble/tJ2ezTj2tKmpraDD+D0oORz6wJ9JXn2WjuY0M3WwohNTRudu3E7HIp0jJCQ6fDslDKhm9 OKCfPGEn5Ri2M81/Wzbtlla6t8bf5gMqSrHynf578E7l5AnAyjawdH8Bh0mnE4ytN530MRQ9zlF6e a0TicVXf7SnEng/Zjrcm9ff2H3X3tv8ijfxIw99EINPwm7NotPdghp9amzTJclJRwmFsw9WNs7jT0 +o3mAIaekflmftmSAps4Tj/ss+e0n3lII26cJtl6O1aXBx+0B4oggArzQNHTjBIGSBcTFb/ubeNzl d2tV2PQjIDKIUBxg1capqMCum/36L1ASZRZEQ0yFZpiSoldaDeP/4abP9VjaW3OfpPcLGw8vWRtaW uIzfs1bN8/7tRDA/1FfI4+lmtRBJasy4T9btdaoKTCFtGvKOh724Ip7Pn1LYUoJS6O5DOsxTW; Received: from [2001:9b1:41ac:ff00:be83:be22:3e7e:fd91] (port=48512 helo=kaka) by uggla.sjd.se with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pAuK7-009Jdq-HG; Thu, 29 Dec 2022 15:55:59 +0100 References: <5c64afba3acb7820763eb5a4bf2567fc4b12ad77.camel@gmail.com> <865c55e780549ba03e66c7012965253a45da05fe.camel@planete-kraus.eu> <96ae1a284e7f34c506a63d1cd76aecabe6e1399a.camel@planete-kraus.eu> OpenPGP: id=B1D2BD1375BECB784CF4F8C4D73CF638C53C06BE; url=https://josefsson.org/key-20190320.txt X-Hashcash: 1:22:221229:vivien@planete-kraus.eu::NnCRZO/jccTS2dsQ:0e6x X-Hashcash: 1:22:221229:guix-patches@gnu.org::z4RBraWaPGEhS48n:6+5a X-Hashcash: 1:22:221229:60358@debbugs.gnu.org::C9ee1BcGDQdRsUpu:Ch+T Date: Thu, 29 Dec 2022 15:55:59 +0100 In-Reply-To: <96ae1a284e7f34c506a63d1cd76aecabe6e1399a.camel@planete-kraus.eu> (Vivien Kraus via Guix-patches via's message of "Wed, 28 Dec 2022 03:50:32 +0100") Message-ID: <87zgb6gsxs.fsf@josefsson.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Simon Josefsson X-ACL-Warn: , Simon Josefsson via Guix-patches From: Simon Josefsson via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1672325832; a=rsa-sha256; cv=none; b=g9TtPH+hgTX+cjMBLzheLNUDJa6mHFz6EdS8HOZUP8GHaOu6sTiWXIwPRCl+XB1r055cwr mfDWAyxNVGWwAWbSRJf+YWc116AfPpsEMQ6Xf+55SFcrIIHLY27f0bwrIvmg+V6DXmpDOk /hvkiSqhZAWWmT/jJTFgt0mWAQl7MIwXTjuihEGnEgakzresngixJKmIXxLlA/gIV33L5P 9kyxy/3dSI51u2Ws9IrBjZadh0MJPxa8sOTdvGswBEadK97XpCWmbAgurRyKq+rv7Xs5rp cMbIQQfJLaMu9L+Zk+SWlN71fUgxCMIVb6R/tZIsrPQ4oSXNMith3dqWrOZtHQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers eddsa verify failed") header.d=josefsson.org header.s=ed2110 header.b=nikd4nqQ; dkim=fail ("headers rsa verify failed") header.d=josefsson.org header.s=rsa2110 header.b="Dyble/tJ"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1672325832; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature:openpgp:openpgp; bh=aI5aUmd73L8r8V262fYTzlxYg3AL+vLXjNoaILIV5xc=; b=OrvJvx1ZPYoPxRFvDm//d/wZiWVdhllvDDASZQT+B3h7GeSxjnw5yaDF8vrVn87gG5oYcG NrSoYpYTW16nz+z6hgc1vw+fDm65ABrB9phmFBShZd/bATbjWv5sXWAh2nmzwCocGEAwtV Q5E8U+R3XaviODTBE7zvCvdKqzE3xhnalYc7C7zVeaQ5UwIzUnSFJvvcDt3QFtuFTjjoCv uh2qs0w5Zku1uENZEvPoWOfpFEJ/589kQWyA4q2UPR0K0vLxmcrO4dWoG/OUv758WBCQ7h LeqFyXb/I0h7MQTUuzSjXXNGCk4UyZhSA2eTGbAswtYI+872ZNVw5ji/CO4oVw== X-Spam-Score: -4.83 X-Migadu-Queue-Id: B0461344A6 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers eddsa verify failed") header.d=josefsson.org header.s=ed2110 header.b=nikd4nqQ; dkim=fail ("headers rsa verify failed") header.d=josefsson.org header.s=rsa2110 header.b="Dyble/tJ"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -4.83 X-TUID: cWjzdNWQKgTe --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Vivien Kraus via Guix-patches via writes: > Le mercredi 28 d=E9cembre 2022 =E0 03:20 +0100, Vivien Kraus a =E9crit=A0: >> * gnu/packages/tls.scm (guile-gnutls) [phases]: Patch-shebang >> autopull.sh and >> autogen.sh. >> * gnu/packages/tls.scm (guile-gnutls) [native-inupts]: Add gnulib and >> git. >> --- >> =A0gnu/packages/tls.scm | 37 ++++++++++++++++++++++++------------- >> =A01 file changed, 24 insertions(+), 13 deletions(-) > > This is not required, but it shows that the gnulib package works. Thanks for providing an example package that would use the Guix gnulib package! I don't think it actually does what you would want it to do: your resulting build of guile-gnutls will likely NOT use the exact same version of gnulib that was used when preparing and tagging the guile-gnutls release. That's why this approach uses GNULIB_SRCDIR to force a different gnulib version than the intended one. Since gnulib doesn't offer backwards/future compatibility, this will just cause the guile-gnutls 3.7.11 build to break at some point, or even introduce subtle unintended bugs, when the gnulib package is updated. However, if the 'gnulib' package in Guix would provide a copy of the git repository, and set GNULIB_REFDIR instead, I believe it would work as intended: ./bootstrap will pick the gnulib commit from the local copy of gnulib. This should always work and is future-proof, as long as the Guix gnulib package provides all historic gnulib git commits forever. Taking a step back, I think it boils down to two approaches when building projects: 1) Download git submodules when download git repository of projects that use gnulib. This consumes a lot of bandwidth, but will set up the project the way most developers build the project. 2) Don't fetch the gnulib git submodule (other git submodules will probably be required, though, depending on project) and add a dependency to a Guix 'gnulib' package that ships the entire git repository, and modify the ./bootstrap call to do ./bootstrap --gnulib-refdir=3D...'. Approach 2) is less well tested but I think it would work, and effectively what it achieves compared to 1) is to reduce the bandwidth requirements and avoid a dependence on an online Savannah. Is this really worth the complexity? Or is there some other advantage that I'm missing? Thanks for caring about how gnulib is used in projects! It is a complicated situation, and has tricky bill-of-material and security consequences. /Simon --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIoEARYIADIWIQSjzJyHC50xCrrUzy9RcisI/kdFogUCY62qfxQcc2ltb25Aam9z ZWZzc29uLm9yZwAKCRBRcisI/kdFovCdAQDiPGkhdo5eN7ZHdgdYp68VK7t18RqF nzkgOFQQVPub0QD/QtCl0YvGBahwrlj3moTSeC/8O1n39YuoOq4DdJB2UgQ= =w7jV -----END PGP SIGNATURE----- --=-=-=--