From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id cGYFOAcPvGMRVQAAbAwnHQ (envelope-from ) for ; Mon, 09 Jan 2023 13:56:39 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 2DPaNwcPvGOH3wAAauVa8A (envelope-from ) for ; Mon, 09 Jan 2023 13:56:39 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B185E173C8 for ; Mon, 9 Jan 2023 13:56:39 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pEr9T-00007J-4e; Mon, 09 Jan 2023 07:21:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEr9D-0008Se-9X for guix-patches@gnu.org; Mon, 09 Jan 2023 07:21:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pEr9C-0003tB-TI for guix-patches@gnu.org; Mon, 09 Jan 2023 07:21:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pEr9C-0005Zf-Hg for guix-patches@gnu.org; Mon, 09 Jan 2023 07:21:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59092] [PATCH] gnu: Add motif Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 09 Jan 2023 12:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59092 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andy Tai Cc: 59092@debbugs.gnu.org Received: via spool by 59092-submit@debbugs.gnu.org id=B59092.167326683421365 (code B ref 59092); Mon, 09 Jan 2023 12:21:02 +0000 Received: (at 59092) by debbugs.gnu.org; 9 Jan 2023 12:20:34 +0000 Received: from localhost ([127.0.0.1]:35954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEr8j-0005YS-KK for submit@debbugs.gnu.org; Mon, 09 Jan 2023 07:20:33 -0500 Received: from mail-wm1-f46.google.com ([209.85.128.46]:54005) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEr8d-0005XO-SB for 59092@debbugs.gnu.org; Mon, 09 Jan 2023 07:20:28 -0500 Received: by mail-wm1-f46.google.com with SMTP id ja17so6117391wmb.3 for <59092@debbugs.gnu.org>; Mon, 09 Jan 2023 04:20:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=StSgsPA3kNuR3akYxwcNde+1oWprQE6caJy6oiLbB1U=; b=OMG9G+a8QsRkgVCs98Xzh0YMmN8aO+P6sEA01tGCpV32mIrS2EiBkTrKwcnMbCd2En GL1a1/cHCfHIt5w57ndGCSPDyBPXHlI1eymXf2f8lciuIyxzEgO46qq9sPRSZny2QjkE YZntpgxm/neBChfucK+hWAlBV0W8r9T48z4gCH6NGBec+3XHQMakZ3H4zF6L4ZX7QHRw 9fnt40/Wl77COuageXEa9dZ6gPb4KHspSqEs2oyVah6Nj1UXwuUkExxgz0mNWEOeBX0m Lrf2jYoUoTus8uVZ+1+OYiFgYQAItO/zMpXdtF9kr3nQu0yXqlWgR1LIP3Wl5PDmTj1b yprg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=StSgsPA3kNuR3akYxwcNde+1oWprQE6caJy6oiLbB1U=; b=ndG3v/HYDNMCVNwZyGSRi78NsYs7bSsJJO6MANzDBcnqMvkPBcHTrQG1IsFgqUCafo Dca3oVrHiKjOC+ae7LaJiceaqRb8wWJtz86ub5qqiz0DvIYMIOVexDlOCOdNmhvgqpb9 NtPK1KnwsQk8rW7JowoCMQSb0LDlzi0/5s3o1qGxN4bexLefHrviUyF3cwnbdYCxY03d pMy8RDL+QrgTMjZZaj7NWqW6GZkgn0cM/fQ+JL9A2IHAkAVlAv2Qk2KlPaFwDcxmm3W2 JGI6qGY7C6Hr26iu7al20vHOTeJ7n61AihMKkYqqr9G5s9FoejrUUhZiROw5F+gCKbL9 TtfQ== X-Gm-Message-State: AFqh2krWzkWbf1wFPoxdUbRZrlC+vHzqn8T4YnkFqj13xHCowZLMp+2R /LIl6nSFqCEQXuhbGxCF1YkkRuENh7M= X-Google-Smtp-Source: AMrXdXv1GV/gU5IXcHa8OsdvvHfMP6WSkDFL7k4imIL2tMf7UJGuhcVk7JgBZEHXBTZbUSuW2292Yw== X-Received: by 2002:a05:600c:3b05:b0:3d3:5a4a:9125 with SMTP id m5-20020a05600c3b0500b003d35a4a9125mr13569420wms.1.1673266822330; Mon, 09 Jan 2023 04:20:22 -0800 (PST) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id m5-20020a056000024500b00267bcb1bbe5sm8523970wrz.56.2023.01.09.04.20.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 04:20:21 -0800 (PST) From: Simon Tournier References: Date: Mon, 09 Jan 2023 13:19:02 +0100 In-Reply-To: (Andy Tai's message of "Thu, 22 Dec 2022 22:34:35 -0800") Message-ID: <87zgaryk7d.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673268999; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=StSgsPA3kNuR3akYxwcNde+1oWprQE6caJy6oiLbB1U=; b=khWkzgKt52zdH944B20rZ8PeXol27d/fuPskmNJ2/mdCdcqNW9PYThVXJVJTRZUQS06k53 KlvSdKoy7pakz1wKnDQTFb6objFYBMnovczOTCaaCldkruzmoIpoHG6e8Qb10zzQDEnIWs qhyWlZ2hELQneDVOPaTJtRRawDau5/f6mjoUNkzqyV5cs1frhHZOTcqwtBG82cc0P1Uuw+ HWx1IJGYovngLfxKXHw2Go/kplafXGGMzkmphe+IIFqlxB7v1kvbQLcDjeAOIMpYNpqcVp hp1Y6AKZ16qDcvhzul8MysdZNtCaTDBR3dhOc+PTRwWvy692UiLasuCAW0ssTQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=OMG9G+a8; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673268999; a=rsa-sha256; cv=none; b=eFKM7WsQpeaymMasiuejp1Oxgg7tB9imZRdXSSMFmSQGAWBNRPoPbVMSj81ipiE8ok99nn NFgnSfQgsXz7twJ0RxNUwZWsFkxgYys5YgR+amjrN29rdMmBxspRGFwq9Cd8wNhNJ76veT Rzxu2zu7SwPNKG2MqOPwOwGbzTOyOqHJ4dKke6hPEaVubebVN4ZTghjd0BpuqrNYrwp9Pz ZFF3Wugf2XSQUCd6doF4n/Ci2YAjQyIPbNhYs7U2VvP1xBZxq4pWZVWEZFcZnPf4RXFmn1 XS04PwIzLv0Jj0kvehrj+jVzzGLrbrRzkXPGNSRArmHb91U/koEt7SlD7rQzgQ== X-Spam-Score: 5.93 X-Migadu-Queue-Id: B185E173C8 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=OMG9G+a8; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: 5.93 X-TUID: htQvTYiPaSCH Hi, The recipe LGTM but 1. I have not tried to build it, 2. I have not given a quick look to the source. =20 On jeu., 22 d=C3=A9c. 2022 at 22:34, Andy Tai wrote: > +(define-public motif > + (let ((commit "59858b0811e8d9dfaeb142f2b5a96f55482be1ed") > + (revision "0")) > + (package > + (name "motif") > + (version (git-version "2.3.8" revision commit)) Maybe it could helpful for later update to mention with a comment why this commit is required and the release version is not enough. > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://git.code.sf.net/p/motif/code") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0yycq0vzga9qmgbfzn2d02ilpwxixwdv2j1d8sddl4dripcrg21m"))= )) > + (build-system gnu-build-system) > + (inputs > + (list libx11 xorgproto)) > + (propagated-inputs > + (list fontconfig freetype libxext libxft libxpm libxt xbitmaps= )) > + (native-inputs > + (list autoconf automake byacc flex libtool pkg-config)) --^ Extra space Here, an extra space. :-) > + (home-page "https://motif.ics.com/motif") > + (synopsis "Motif toolkit for the X window system") > + (description "Motif is the industry standard graphical user inte= rface, (as Usually, we try to avoid such =E2=80=9Cthe industry=E2=80=9D and instead on= ly =E2=80=9CMotif is a standard graphical user interface, =E2=80=A6=E2=80=9D And the linter [1] complains about =C2=ABdescription Validate package descriptions sentences in description should be followed by two spaces; possible infractions at 155, 343=C2=BB. 1: Cheers, simon