From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 4C7mLVIdBmRbhQEASxT56A (envelope-from ) for ; Mon, 06 Mar 2023 18:05:22 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yDwULVIdBmQ6BwAAG6o9tA (envelope-from ) for ; Mon, 06 Mar 2023 18:05:22 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 921D6311EA for ; Mon, 6 Mar 2023 18:05:22 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZEGx-0000YA-1J; Mon, 06 Mar 2023 12:05:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZEGk-0008Vq-J8 for guix-patches@gnu.org; Mon, 06 Mar 2023 12:05:06 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZEGk-0002f8-7e for guix-patches@gnu.org; Mon, 06 Mar 2023 12:05:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pZEGj-0006C7-NS for guix-patches@gnu.org; Mon, 06 Mar 2023 12:05:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60847] [PATCH] Enable cross-compilation for the pyproject-build-system. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 06 Mar 2023 17:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60847 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: Josselin Poiret , Christopher Baines , Simon Tournier , Mathieu Othacehe , 60847@debbugs.gnu.org, Tobias Geerinckx-Rice , Lars-Dominik Braun , Ricardo Wurmus , jgart Received: via spool by 60847-submit@debbugs.gnu.org id=B60847.167812229023789 (code B ref 60847); Mon, 06 Mar 2023 17:05:01 +0000 Received: (at 60847) by debbugs.gnu.org; 6 Mar 2023 17:04:50 +0000 Received: from localhost ([127.0.0.1]:43515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZEGX-0006Bd-Ox for submit@debbugs.gnu.org; Mon, 06 Mar 2023 12:04:49 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZEGW-0006BR-JS for 60847@debbugs.gnu.org; Mon, 06 Mar 2023 12:04:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZEGQ-0002cG-PW; Mon, 06 Mar 2023 12:04:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=4HyrjNlKU/X046YF+Kbdn7btcX1CPUo0/R9EZoZuGGA=; b=H14vT1+dWkU7t3j8zzdO Scy5yjT1cSdjdmU1hL9nPJTd6w9mdfpN4jCZU1zoQ0x9hEc/xPNUFmTdh+Jtd667LRCNG/d3c/Mcr F2wt+741xsoO1y1naYRlsd2ioHrzgRZhIlFVjeqN3Z3zmBMeXWOyJL+P7IlJEOR5hubW08WJtKmyq oCq0cLkgtKCu7bdqhQsu0P3/cx3WOLo0jwCB4kZ7a9uLLe2BLtDMu9p9l2fVChUj4YHCXy32PqfNc MpBaNhBxXHbJZ4J2E8giYhFPRGc7uSXXQ7zW1Ym2dw8hDruBJY+RBsSI22tCzuwaYbBCcXnYs0wNh jWsDJXsAuBDWyQ==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZEGN-0005Ou-FI; Mon, 06 Mar 2023 12:04:40 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20230123133217.318-1-maxim.cournoyer@gmail.com> <20230123133217.318-2-maxim.cournoyer@gmail.com> Date: Mon, 06 Mar 2023 18:04:35 +0100 In-Reply-To: <20230123133217.318-2-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Mon, 23 Jan 2023 08:32:16 -0500") Message-ID: <87zg8p7qvw.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-TUID: tJUFvf9sTc1B Hello, Maxim Cournoyer skribis: > +++ b/guix/packages.scm > @@ -1864,28 +1864,30 @@ (define* (bag->derivation bag #:optional context) [=E2=80=A6] > + (let ((builder-name (procedure-name (bag-build bag)))) > + (if (or (bag-target bag) > + (eq? 'pyproject-build builder-name)) > + (bag->cross-derivation bag) This one part is a showstopper to me, for two reasons: 1. We cannot rely on =E2=80=98procedure-name=E2=80=99 (it=E2=80=99s a deb= ugging aid and it=E2=80=99s not guaranteed to return something useful). 2. Special-casing build systems here is not okay: the bag and build system abstractions exist to maintain separation of concerns. I understand there=E2=80=99s an actual bug to fix and the desire to fix a m= ore common issue, but I think this one approach is not the way forward. I hope that makes sense! Ludo=E2=80=99.