From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id WArJGlYKfmT0KwAASxT56A (envelope-from ) for ; Mon, 05 Jun 2023 18:16:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id OAaTGlYKfmRMTQEAauVa8A (envelope-from ) for ; Mon, 05 Jun 2023 18:16:22 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EF1AA2D637 for ; Mon, 5 Jun 2023 18:16:21 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q6CsJ-00072W-1E; Mon, 05 Jun 2023 12:16:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6CsE-00070y-0O for guix-patches@gnu.org; Mon, 05 Jun 2023 12:16:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q6CsD-0007m6-OV for guix-patches@gnu.org; Mon, 05 Jun 2023 12:16:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q6CsD-00047Q-Jb for guix-patches@gnu.org; Mon, 05 Jun 2023 12:16:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63900] [PATCH] gnu: Add emacs-fb2-reader. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 05 Jun 2023 16:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63900 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Adam Kandur <4164616d.4b616e647572@gmail.com> Cc: 63900@debbugs.gnu.org Received: via spool by 63900-submit@debbugs.gnu.org id=B63900.168598175915823 (code B ref 63900); Mon, 05 Jun 2023 16:16:01 +0000 Received: (at 63900) by debbugs.gnu.org; 5 Jun 2023 16:15:59 +0000 Received: from localhost ([127.0.0.1]:50132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6CsB-000479-6e for submit@debbugs.gnu.org; Mon, 05 Jun 2023 12:15:59 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:39311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6Cs8-00046s-3j for 63900@debbugs.gnu.org; Mon, 05 Jun 2023 12:15:56 -0400 X-GND-Sasl: mail@nicolasgoaziou.fr X-GND-Sasl: mail@nicolasgoaziou.fr Received: by mail.gandi.net (Postfix) with ESMTPSA id 7728DFF809; Mon, 5 Jun 2023 16:15:49 +0000 (UTC) From: Nicolas Goaziou References: <20230604163021.5163-1-4164616d.4b616e647572@gmail.com> Date: Mon, 05 Jun 2023 18:15:47 +0200 In-Reply-To: <20230604163021.5163-1-4164616d.4b616e647572@gmail.com> (Adam Kandur's message of "Sun, 4 Jun 2023 19:30:21 +0300") Message-ID: <87zg5ddgwc.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1685981782; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=QxQBheE3kL9JfqZ8lTzPqAZBvIPKyNp8xLDpFBWeUSw=; b=ZdAbWsSRztsWchzwslnBwEjp+h1tRT6aseTU2k9r/iJW7F0YFm7pe9UYzF8wjVkFTWZY+0 BU9DislAqocMN1zdlpcnkowSESwYYs+cF8yUqciB38RdNwuAyskHsllmtQyAk5UUZt7141 HkiCOFaU83JzGK4CKd8a4rQBpk8B/pfGbRGV1qzw+k9m/STdkDyDqhEfJkD+ElWMb6bfZR Ms9Jb76VDEXYPVqbaJ9Lt8i5Y299xPrR4F76RGuuZt5729V02WPEKHWLDVhv+RPH6inzA1 lqDQp4fKqWHabQRobyFMjNbcbfRTLocaUjtVO5kFjkd58qPY0hk5Q3FfAeIzWw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1685981782; a=rsa-sha256; cv=none; b=bLcxrLVAdKg6poWE3+qCnuLVQGx/2B1h3aFWNTUCbMxCMIRGkC1GeCvBwJ40IBb9Z2w/9G QRouK9Rr4AgNvr702Z0GA5TmK46qCdirrQxld/yR59T6v8hvQC5WfN0cmBNwvvTjV62Sn9 XKc65/npHJ67mmYMNVmd5PXLrOkO3eoR+y18FvuqRnA9A/WgJYBrmyOXYY8jm058DJFQ4W GemC3skgF8H1mEXNzwXHTjB/SAJht9cElYJmubidBQQaX6xH9Pz5fJaRVxZAoCZsfDntxC DPzZswdqXJZ4ePm3hxqWaUbExG+iUBfUfxHbpJi4bGi9hnRHlNkUpZfHUqn7Rg== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -3.29 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: EF1AA2D637 X-Spam-Score: -3.29 X-TUID: CC9W/cS01EQH Hello, Adam Kandur <4164616d.4b616e647572@gmail.com> writes: > * gnu/packages/emacs-xyz.scm (emacs-fb2-reader): New variable. Thank you. Some comments follow. > +(define-public emacs-fb2-reader > + (let ((revision "0") > + ;; named branch is outdated > + (commit "9836db284749e0cef4c43c2cb5358c82ae9b8589")) This exactly matches version 0.1.1 so you should add "; version bump" comment at the end of the line, and use 0.1.1 as the version. > + (native-inputs > + (list emacs-buttercup > + emacs-dash > + emacs-s > + emacs-async)) There are tests, could you try running them? Note that inputs should be ordered alphabetically. > + (propagated-inputs > + (list emacs-visual-fill-column > + emacs-f > + unzip)) Likewise. Also, unzip should be an input rather than a propagated input, and "fb2-reader.el" should be patched accordingly (i.e., replacing "unzip" with (search-input-files inputs "/bin/unzip")) > + (home-page "https://github.com/jumper047/fb2-reader") > + (synopsis "Emacs plugin to read .fb2 and .fb2.zip ebooks") I suggest: Emacs plugin to read FictionBook2 ebooks > + (description "This package allows users to read fb2 books > +whithout quiting Emacs.") What about: FB2 Reader provides a major mode for reading FictionBook2 (@file{.fb2} and @file{.fb2.zip} files) ebooks. > + (license license:gpl3)))) License is actually gpl3+, as mentioned in the main file. Could you send an updated patch? Regards, -- Nicolas Goaziou