From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id +uVwNVEhlGToOwEASxT56A (envelope-from ) for ; Thu, 22 Jun 2023 12:24:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id wNutM1EhlGQ4cQEAG6o9tA (envelope-from ) for ; Thu, 22 Jun 2023 12:24:17 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 78DC7294BC for ; Thu, 22 Jun 2023 12:24:17 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qCHU0-0001hD-0h; Thu, 22 Jun 2023 06:24:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCHTv-0001gj-HG for guix-patches@gnu.org; Thu, 22 Jun 2023 06:24:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qCHTu-0001Ae-Su for guix-patches@gnu.org; Thu, 22 Jun 2023 06:24:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qCHTu-0003HY-Bx for guix-patches@gnu.org; Thu, 22 Jun 2023 06:24:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64203] [PATCH] guix: node-build-system: Delete from peerDependencies too. Resent-From: Jelle Licht Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 22 Jun 2023 10:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64203 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Lars-Dominik Braun Cc: 64203@debbugs.gnu.org Received: via spool by 64203-submit@debbugs.gnu.org id=B64203.168742943512602 (code B ref 64203); Thu, 22 Jun 2023 10:24:02 +0000 Received: (at 64203) by debbugs.gnu.org; 22 Jun 2023 10:23:55 +0000 Received: from localhost ([127.0.0.1]:34942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCHTn-0003HB-IH for submit@debbugs.gnu.org; Thu, 22 Jun 2023 06:23:55 -0400 Received: from mail1.fsfe.org ([217.69.89.151]:39614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCHTk-0003H1-Ka for 64203@debbugs.gnu.org; Thu, 22 Jun 2023 06:23:53 -0400 From: Jelle Licht DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fsfe.org; s=2021100501; t=1687429430; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ggvc9tJwTDZ/wsIrAHOhVjQunLYb9habD8oAH0kA0ro=; b=fUc+ZCfynGUwHBwPYnu7QSM6uj9XGZc/P2s9G7+phF3C4gF1/h0G+CAt7XHFw6aNJvdUSB gWyjP/K+3XUuRCUEWFYrVTCvx0gDIpVPAvdYC6SRqY0L1brp7pQGxeLmoXinOLMdQKXt/F JtLJkX0d6g/cGueuAkTp4pcLd3zhGJk= In-Reply-To: References: <6bc6fc29681881be3ce767c51a7dd8886b97c169.1687336553.git.lars@6xq.net> <875y7f7sl1.fsf@fsfe.org> Date: Thu, 22 Jun 2023 12:23:49 +0200 Message-ID: <87zg4r6bii.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1687429457; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Ggvc9tJwTDZ/wsIrAHOhVjQunLYb9habD8oAH0kA0ro=; b=eoFkjtIj++Q3fLDlRrhDeQ49qZSFIuaIxBizr7UgEmYX9tENFpFBXH2yQy8oF9P+ywRQOH c3OTjmSrLsVckPXlLNGyfUm+Pqyt5nfnJRQxfAVuhyiweokZb17447N1db83lJjV+zd83g 79UP/YUUXuxQOBQbkLRlwSJGNZTzOLnfP2FfDlxpo26k1WD/BdNRGFDaNjKciqYnit9Q7C VgZh47ZYWfF8JtvLG72bjvW8ybdIYvNqmYOaX3nWVqUQpmtLZMNX0fPKpC/UT8rQb+reOr ws9vk6yEgKX5Aa6580HaiYSugWL4LgOcSis2cO9+Zz2hr0W37Zyh6/sUfNWk7A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=fsfe.org header.s=2021100501 header.b=fUc+ZCfy; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fsfe.org (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1687429457; a=rsa-sha256; cv=none; b=TeTv1Th3yoJzdAWVThdKqVvp5QzXQF8NKAEZHOBG7jRJurgsn4Ps9Q52KTQhTCCUMsRYQp +7I2v31C+RZqayMfCujN49qKwmiWGHImg2+/KYO2vn9w7iUPkALWv69ufba4C/4YLvJ/Ki DB0Ht0inPEo9GH6cT7I0dU0+zYQw6bUjm12f4NnlBA7u6FD53n67gZhO8nSnaTAs2uk2QU kH2ILzlEArBuyUt+WUdnpCMjC2Tu6r1LdO5Kktec88QR8F2+TqPGctsNYuJquSKNGwO89M 5MBtzw4vGfKgemckg+OyYxUsnY2ih+61D+Db/LbdkIB+jJzwPZk5bpq1Eu7knw== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -0.65 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=fsfe.org header.s=2021100501 header.b=fUc+ZCfy; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fsfe.org (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 78DC7294BC X-Spam-Score: -0.65 X-TUID: LlXf/2EdSDcc Lars-Dominik Braun writes: > Hi, > >> LGTM. You can consider adding a note to the commit message that thix >> needed due to a change in how more recent npm versions deal with >> peerDependencies. > > I don=E2=80=99t know anything about that change in npm unfortunately =E2= =80=93 this > is purely based on observations of failed builds. Do you have further > information on this? The previous version of node we had packaged guix was v14, which came with npm v6. The most recent version of node we have packaged in guix is v18, which comes with npm v9. >From [1]: "In npm versions 3 through 6, peerDependencies were not automatically installed, and would raise a warning if an invalid version of the peer dependency was found in the tree. As of npm v7, peerDependencies are installed by default." HTH! - Jelle [1]: https://docs.npmjs.com/cli/v9/configuring-npm/package-json#peerdepende= ncies: