From: Jelle Licht <jlicht@fsfe.org>
To: Lars-Dominik Braun <lars@6xq.net>
Cc: 64203@debbugs.gnu.org
Subject: [bug#64203] [PATCH] guix: node-build-system: Delete from peerDependencies too.
Date: Thu, 22 Jun 2023 12:23:49 +0200 [thread overview]
Message-ID: <87zg4r6bii.fsf@fsfe.org> (raw)
In-Reply-To: <ZJQc-bJAjr5nYmMK@noor.fritz.box>
Lars-Dominik Braun <lars@6xq.net> writes:
> Hi,
>
>> LGTM. You can consider adding a note to the commit message that thix
>> needed due to a change in how more recent npm versions deal with
>> peerDependencies.
>
> I don’t know anything about that change in npm unfortunately – this
> is purely based on observations of failed builds. Do you have further
> information on this?
The previous version of node we had packaged guix was v14, which came
with npm v6. The most recent version of node we have packaged in guix is
v18, which comes with npm v9.
From [1]: "In npm versions 3 through 6, peerDependencies were not
automatically installed, and would raise a warning if an invalid version
of the peer dependency was found in the tree. As of npm v7,
peerDependencies are installed by default."
HTH!
- Jelle
[1]: https://docs.npmjs.com/cli/v9/configuring-npm/package-json#peerdependencies:
next prev parent reply other threads:[~2023-06-22 10:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 8:38 [bug#64203] [PATCH] guix: node-build-system: Delete from peerDependencies too Lars-Dominik Braun
2023-06-22 9:29 ` Jelle Licht
2023-06-22 10:05 ` Lars-Dominik Braun
2023-06-22 10:23 ` Jelle Licht [this message]
2023-06-22 11:04 ` bug#64203: " Lars-Dominik Braun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zg4r6bii.fsf@fsfe.org \
--to=jlicht@fsfe.org \
--cc=64203@debbugs.gnu.org \
--cc=lars@6xq.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.