From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id wCoJNO/UIGVO+QAAG6o9tA:P1 (envelope-from ) for ; Sat, 07 Oct 2023 05:48:00 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id wCoJNO/UIGVO+QAAG6o9tA (envelope-from ) for ; Sat, 07 Oct 2023 05:47:59 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1DF6752FC8 for ; Sat, 7 Oct 2023 05:47:59 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tilde.club header.s=mail header.b=OJnrGgxr; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tilde.club (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1696650479; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=IuV/SlyIsKBl68eOYLv/ShnOl8CU86KZyFkTTAU+oW4=; b=GxUN6SQ5khwm2m/C7ZD241E3iBCpKnbiwbq1M0zbIb/KQIW3xTXWFW8vn9t3Q03h2OGrPe e0NPKYo1H63dddCEUr9SIxTIzucKerGdmPf3Rrj0W0q/L0fnocP4G5YJoAVWe1s/svC8Pp R96oxi+i0dvyY4oDh5ZfRPMGUGl8vjIfru9P5jjMtmUJs/P5TRlTXuq4hgH7ZHIYSEk3BD SlrNQKvEf6qA8tRVQI2fFtOrXxyR/LrIAIBzSJerkIviCwaLvqC6FkC3e51qw7O07pjOEy naWJKvUWDkqo9/4HGsp6YKHlN6F1ESkGfcf5+rbI3EryqfLcYfpxLSN75Gj2wA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tilde.club header.s=mail header.b=OJnrGgxr; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tilde.club (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1696650479; a=rsa-sha256; cv=none; b=HurQa0lZwJqLvLk8vcjmQrTKv5h0CThdkypvQMGYP/9ezqzNPvUYpMLvOb0VfBcOucGW1b NFUcAxXMvZhlSAiEoPLM/rIyN60ptf5K0ldD0sibcwqtVWgJSKP3RVDEfzwxjwMAEdW4ys dTfjcMYp2sZEWghUSpubP4iTxFLCVWi1L8/cmw8Mq05P1ocoWUiBiGWAOCF8UE9KiJaQGA hk2vhE1etV6TQxytt9GZGEuMzNwAUV4QZ+hGAKbZTTnZhIDDwaPOJJ4ZXNkxNB3t7KCJZP 7OKvIogn+fehnIDxwfNngt/ZawGF9vKKFlpczuepP7K4XwPpX2u8P1eZsS+k1Q== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qoyI4-0001Cc-QC; Fri, 06 Oct 2023 23:47:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoyI3-0001CR-2v for bug-guix@gnu.org; Fri, 06 Oct 2023 23:47:43 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qoyI2-0004aa-R3 for bug-guix@gnu.org; Fri, 06 Oct 2023 23:47:42 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qoyIL-0005DX-U1 for bug-guix@gnu.org; Fri, 06 Oct 2023 23:48:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#65665: [PATCH] Really get all the implicit inputs. Resent-From: Ulf Herrman Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 07 Oct 2023 03:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65665 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ulf Herrman Cc: Maxim Cournoyer , 65665@debbugs.gnu.org Received: via spool by 65665-submit@debbugs.gnu.org id=B65665.169665047520016 (code B ref 65665); Sat, 07 Oct 2023 03:48:01 +0000 Received: (at 65665) by debbugs.gnu.org; 7 Oct 2023 03:47:55 +0000 Received: from localhost ([127.0.0.1]:53132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoyIE-0005Cj-OS for submit@debbugs.gnu.org; Fri, 06 Oct 2023 23:47:55 -0400 Received: from tilde.club ([2607:5300:204:4340::114]:48596 ident=postfix) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoyIB-0005CR-SY for 65665@debbugs.gnu.org; Fri, 06 Oct 2023 23:47:52 -0400 Received: by tilde.club (Postfix, from userid 5378) id 507DE2202A79C; Sat, 7 Oct 2023 03:47:30 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 tilde.club 507DE2202A79C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tilde.club; s=mail; t=1696650450; bh=j0JtlAPnyKL7qMEJndsfFdz6aU+kyfK9Sx/DHzXPSVE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=OJnrGgxrdsNmegji7Icsv2fFJig22qD1OyEXWXRMnW/biqthMrlMR2g81g9K3IzWE D2RDESwLagOrL6uwtmX7LBYbUFSMLMkYzJJjeml18pqHpmtjniOhxw4nC6XEF8nyaL Uvezm2T6wmnHohQG1a418nAT7KfSTBaprUSqZsSw= From: Ulf Herrman References: <87h6ofufy5.fsf@tilde.club> <87msxmqwng.fsf@tilde.club> <87a5swlbnp.fsf@gmail.com> <874jj45hhl.fsf@tilde.club> Date: Fri, 06 Oct 2023 22:47:04 -0500 In-Reply-To: <874jj45hhl.fsf@tilde.club> (Ulf Herrman's message of "Fri, 06 Oct 2023 02:37:26 -0500") Message-ID: <87zg0v3xhj.fsf@tilde.club> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 1.66 X-Spam-Score: 1.66 X-Migadu-Queue-Id: 1DF6752FC8 X-Migadu-Scanner: mx2.migadu.com X-TUID: RqxOK/RGcIGj --=-=-= Content-Type: text/plain Ulf Herrman writes: > Anyway, I've since forgotten exactly what happened and why (I didn't > actually write the commit message until quite some time later), but I > do know that this patch fixed it. > > I might try to rediscover what the problem was later, but thought it > would be good to make you aware of this so as to hopefully consolidate > world rebuilds. I've since done some more checking to recall what the problem actually was, and it indeed manifested as a combination of an icecat and mesa problem: the wrap-program phase of icecat-minimal uses `this-package-input' to get the mesa to point LD_LIBRARY_PATH to. However, it then stuffs the resulting package inside a object, which we don't currently recurse through, so it ends up compiling with one mesa and using another at runtime, which somehow causes a segmentation fault. Having looked at it again, I'm not sure that rebinding `this-package' is the best solution - it's certainly not a general solution, since any old package could be shoved into a object (or really any declarative file-like object) and thereby be hidden from transformations. My understanding is that packaging guidelines already discourage directly substituting top-level package references, preferring instead tools like `this-package-input' so as to work nicely with transformations. If those guidelines are adhered to, the aforementioned patch should fix issues of this nature. I'm not sure what the best way of handling objects like and such is, but as long as package references go through `this-package', it should only matter for implicit inputs, and I don't think any of them use declarative file-like objects other than . After thinking about it some more, I think it would be good if we had a way of testing to make sure that every package is "transformable": that is, if you apply a deep transformation to it, and lower the result to a derivation, at no point within the dynamic extent of that lowering is a derivation from an untransformed package introduced. This would allow for testing for transformability en masse, and could be added to 'guix lint'. - Ulf --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHIBAEBCAAyFiEEn6BUn0yca1D9JsMa1lV76sJM9mgFAmUg1LkUHHN0cmluZXNz QHRpbGRlLmNsdWIACgkQ1lV76sJM9mjWFwwAq+08T2FDh1u+Hb6DHC/7Pexfe4G2 l7geedz0yRFFtbZ8BD593yA+TLGwdsNE05F7D6gLmQdsz3OIHmTEHxk0yaO3SqAI GFRaue5btZ2gmbeQiNy2CLwX8lDGqyjO40IrDNntQ4iG7WqKKp066pWGpVj0jLvR JifEjneB937IJrqo3MwwLiBUGAEMAnBbR3S4p4qGRAIyzBhrW204iXdMaRLgUgXN kbm7hlrOFHi9ixOoc4abO+esywzLya8qyfyFh/0lENuKszszOUGgWUnqfMyxma73 Nzf67nG1fT69X5c+nfUx1vRt5YiZCu5y949S8pFHABUvSqo8/tcK4bYVIu+umcj+ 9lOerIYRshInWPCrxipKnmkt0azBxz7I4PA0tCgfCrrmd7yvWY+sWpd6+kGDoAne drWIeGAsXK8+0bYp4ENyoGlywZw04dZSEAwwplqFfIRMtE5Pk6SwOJsR0pe+Eu7O sU6doFqccPWZkyYSZola9q4uzG5tv/kmYP+m =fgOf -----END PGP SIGNATURE----- --=-=-=--