From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id QIoYO6c/z2X1EQAAqHPOHw:P1 (envelope-from ) for ; Fri, 16 Feb 2024 11:57:44 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id QIoYO6c/z2X1EQAAqHPOHw (envelope-from ) for ; Fri, 16 Feb 2024 11:57:44 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=lassieur.org header.s=fm3 header.b=EKRatMKB; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=B366O+mq; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1708081063; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=39rY8ICF521b/x++Sf4Kir9q+5DD+S5BaXByDIp3+R8=; b=kNuMB4bJHgV8DP74F4AX8oYPM08UyR7ETCVDGUXx5SLkbrkH0jyjxKaDLQyJN7n2h7+fd1 8uqooEtbHmKTWQ5N5Xh8SI6i9PtDSNJdj86+U78N/NbWj8Dny2ZQVAcDyS41b7otD9jxzM 8kf+6Il9zJ3iNuunZjI2Hd8IDlVOnZ3GfaqUCHydDUjcfGB+7SaDdaQmRPXh0cHJdCst5e VP2qlypDz01jiT76qnucmKXnzACyxL3rrj+RIgbx3N593tf1I5hzrjv0xXW3tqr9HszOMA rnWo/fTv9MlLPXANH3DY4n9A8BsbvysuT+wb4LyPAXdvlgTi1ov+xiMsGXZMUg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=lassieur.org header.s=fm3 header.b=EKRatMKB; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=B366O+mq; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1708081063; a=rsa-sha256; cv=none; b=BcaC1J6fXGf9FWLFj9dpdFRqp0NR5sj6XJT19vHDItHmFhF8NoeznOLHEAflyoPifbieSm dRDmGO3EtP8KxP8WM3nXtiD+Hf/IINQGJtknT+P8Fln1+vUdwpk1W4JEnIgBQcngjOyecl 9zOaY1U4XbOcN86keN6AT0ICUoNeHW2zbUoLLeMHFOGrYV/h39JwAZiTlmMXl6To3u50eY Puzq/H2nDFNg7EQROzqEc5bH+KNhw6PABN+gTUM3PBuAABfQqGfWhhbIr7iux4Qr1EvKuv O95SutXbE7fJO4SxUbeFBNfmkjHAmOo+SdYdhSpw6yU6jH8pPYuNMKE8rkBsUg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0B002F42D for ; Fri, 16 Feb 2024 11:57:43 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ravtz-0001gM-Hl; Fri, 16 Feb 2024 05:57:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ravtv-0001L7-Ai; Fri, 16 Feb 2024 05:57:03 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ravts-0007p5-Dd; Fri, 16 Feb 2024 05:57:03 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 4DD96320077A; Fri, 16 Feb 2024 05:56:54 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 16 Feb 2024 05:56:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1708081013; x=1708167413; bh=39rY8ICF52 1b/x++Sf4Kir9q+5DD+S5BaXByDIp3+R8=; b=EKRatMKBvZHgzSfHzU10ldVxYN ofu39t2dfsahu+8UQDlGh7uGYi7nO3BMHBQVP0xnKu3pOdhilQxs25fWr49HMQT3 1eUvGsU3SHSytSAJUJ29YCcbj+9aQEYZz+iBFU8kiywCZ5g2GbHQvxjY11fCHMS3 DsE5qA0DCe0XHwe50SPnlPovxLqj+wEkNLulcBxMrI+NL3ceGVqee7h8dClTijTn 67mjFtcn00k1rWZ6m4F5qJf0s3TClaBbP85VO6G9mThrd8koa4ns0DERgSYj/GpU CaGWdWZy9yYHAqIIVwfGZFapHAbu30St8bDcC4K9hyxjWcEexqo3fHDKZlTA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1708081013; x=1708167413; bh=39rY8ICF521b/x++Sf4Kir9q+5DD +S5BaXByDIp3+R8=; b=B366O+mqEuEZqBurv6fPeFYHlBiakh8ktAaq6cZSEW13 WeLp4Hx75xXkOGGCpOlpZ7OrqrsU51GbQnY/mYGMjvhcNDT5dqcYRov+wnBG3m6+ hxj3zivjB8250kdlhMYe3ScpSdU2Q5RB6AOYho9xFCAxY86WBArKx7tCL15L79Cu 0P+5V4pNoMZ4qIcrdYXUA/2xCPxZfyp9WJgW7ysLoZ+CiJKtQ0QswEaGUUwsbG+e /wggY0xHPhFNV/WASvfG2+N6oqHXtrMZEiKBdoQoJvY22Dxo57gImMPtXUPQfwBT XMC72qm/gR0wfxagCe3NNO8YfLhJEtTNEEA8CVH6IQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddvgddvudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufgjfhffkfgfgggtsehttdertddtreejnecuhfhrohhmpeevlhormhgv nhhtucfnrghsshhivghurhcuoegtlhgvmhgvnhhtsehlrghsshhivghurhdrohhrgheqne cuggftrfgrthhtvghrnhepheevudduvddttefgkefgheehieehgeetgeffieejheettefg fefguedvgeeuhfffnecuffhomhgrihhnpehgnhhurdhorhhgnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomheptghlvghmvghntheslhgrshhsihgv uhhrrdhorhhg X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 16 Feb 2024 05:56:52 -0500 (EST) From: =?utf-8?Q?Cl=C3=A9ment_Lassieur?= To: Suhail Cc: Steve George , Edouard Klein , guix-devel@gnu.org, help-guix@gnu.org Subject: Re: Guix Days: Patch flow discussion In-Reply-To: <35786.5440238797$1707248619@news.gmane.org> (suhail@bayesians.ca's message of "Tue, 06 Feb 2024 19:42:39 +0000") References: <35786.5440238797$1707248619@news.gmane.org> Date: Fri, 16 Feb 2024 11:56:50 +0100 Message-ID: <87zfw0llsd.fsf@lassieur.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=64.147.123.21; envelope-from=clement@lassieur.org; helo=wout5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -8.30 X-Spam-Score: -8.30 X-Migadu-Queue-Id: 0B002F42D X-TUID: p37L20yEGfkE On Tue, Feb 06 2024, Suhail wrote: > Steve George writes: > >> elsewhere in the thread someone mentions some tags we could use >> consistently so maintainers can find patches that have been reviewed >> easily. > > It seems on the [dev manual] we already have "reviewed-looks-good" > documented. Thus, I'd like to propose the below *mutually exclusive* > Debbugs tag set: > > - "not-yet-reviewed" :: automatically set for all submissions > - "reviewed-needs-fix" :: set explicitly by the reviewer > - "needs-another-review" :: automatically set if there's a revised > patch, unless "not-yet-reviewed" (in which case no change) > - "reviewed-looks-good" :: set explicitly by the reviewer Would it makes sense to have a "does-not-apply" tag too? I believe that would help sorting old those old patches that don't apply anymore. > In addition to the above, it might also help for there to be an > additional tag of "might-not-need-review" (or simpler, > "review-not-needed") which gets automatically set, provided we implement > a way to label some changes (for some packages) as being "trivial enough > that they're okay as long as build succeeds". > > On a related note, is it possible for a reviewer who isn't a committer > to set debbugs tags? > > [dev manual]: > >> It would be great to agree those - try them for a bit - and document >> them in a 'howto' so that everyone uses the same process. > > In addition to documenting the tags in the "Debbugs Usertags" section of > the manual, it would help for there to be a "howto" which focuses more > on the transition between the tags (i.e., the contribution workflow).