From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 8D3rGI7O2GU8MAAAe85BDQ:P1 (envelope-from ) for ; Fri, 23 Feb 2024 17:57:50 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 8D3rGI7O2GU8MAAAe85BDQ (envelope-from ) for ; Fri, 23 Feb 2024 17:57:50 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=lkuToiJi; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1708707470; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=mkDAxAgsRoUtZP/HjjCc2bPYrwgPnvqsnyi9iFWGD5E=; b=VZCX9/F1nXjzJNuV5cmqTmm0C3m+u3HFWejP+pSJlxpGZT/ng6qmqNZy0RjT7IN4dF7fIL 8eu/uqG+01N+wtfX41Q4wdAfZmNdvrS2ZFy1jEg19cPg9wb+fqyvI5tZ2c/o6yoPSRqlrw y1i8a9xjSopZoOxc8l1FAz+6KWeuL78KHtXtO1mO7icryOzohmGIhNQvVl3wZRUgfIdsAt 8U0QwF6VkJi7gaT6U69m/MY7qkwJ+wi2O1Lh8Z414LkZFggdU8LCq1WlkuH/BzJq72ZTtZ SARn7C/fVKZG8zBAD/06r6rSY4V/64PiHcH1JRpU3rq0KqGBPIIL1+SHJZUPTQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=lkuToiJi; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1708707470; a=rsa-sha256; cv=none; b=PqGFV/zFZ+OXV/sCXdIA++6ujUCQRPJhjcr/i012AIM7XmZVmWBXYM7Q1mF8JgTQwoiBeN iPcjOGlHGcRR+E0D9mAiXVWRtQAt9qmwkv9MbXUVFj5IY+FLywrtcZG0InSe/vhcsAat0w UfNpS2eZwp0VWgKlRKUX0gF/44hHFVrBwDeMHbOiCwMQ10YvM+dcMc85IB9yuDkB2ZbCL3 F9UcgTm2k+Yq1mo7yowzeMuIsqI7Tt+lxwUarF7nPb7k0ODEowCmbA3rwOVtUUNs9VwisC VlOSPTFgl0W/ytEw2VeAX+2YTM7GvJ4Wbs6rfQjTSO+Q6VbA6wn5v98Pqj2FWA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4547C1325A for ; Fri, 23 Feb 2024 17:57:50 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rdYqL-0007uJ-6p; Fri, 23 Feb 2024 11:56:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdYeA-00051e-KC for guix-patches@gnu.org; Fri, 23 Feb 2024 11:43:38 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rdYeA-0001KT-Ae for guix-patches@gnu.org; Fri, 23 Feb 2024 11:43:38 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rdYeX-0004lK-S9 for guix-patches@gnu.org; Fri, 23 Feb 2024 11:44:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69292] [PATCH 6/6] store: database: Rename a couple of procedures. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 23 Feb 2024 16:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69292 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , 69292@debbugs.gnu.org, Christopher Baines Received: via spool by 69292-submit@debbugs.gnu.org id=B69292.170870662718263 (code B ref 69292); Fri, 23 Feb 2024 16:44:01 +0000 Received: (at 69292) by debbugs.gnu.org; 23 Feb 2024 16:43:47 +0000 Received: from localhost ([127.0.0.1]:52770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdYeJ-0004kU-6s for submit@debbugs.gnu.org; Fri, 23 Feb 2024 11:43:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdYeG-0004jz-I9 for 69292@debbugs.gnu.org; Fri, 23 Feb 2024 11:43:45 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdYdm-0001IC-E7; Fri, 23 Feb 2024 11:43:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=mkDAxAgsRoUtZP/HjjCc2bPYrwgPnvqsnyi9iFWGD5E=; b=lkuToiJizOmECiepKqeQ QgBDfeEN7HIUv/o9qQEkRjQQfvR/uH0Oq+/1IM+F/1ovWzvxHvOOu9ZQnnrOZsHJSNUpANl0GoJ/+ qviUpL07CMv8qlgXJXOP5pKa3JFt4wE/nPi7JdNozlppNC9M2E1g5LeYnB6w8054vMDQNFbPNjjbG 02ryGyjRMa0t67fSXPOvF7E3gMlwDhYVTwEu0CPbbFSPyJkwb6l3vGcPGDMBO7tjj1HHrJCVCwty/ XY0U3bRJS16zbj1MwzhmgFFn1z2lGudAB+S0pVs3ZRFpaNACT+uMiqhKr/jOmF2jXwb9++vkKS58I +ct0TknklsaG1w==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <12f872394c84039fa553e50381d040de24f24d3e.1708457946.git.mail@cbaines.net> (Christopher Baines's message of "Tue, 20 Feb 2024 19:39:06 +0000") References: <4b6a268daab5e0b307dff2229d551a47c9fe1ebc.1708457946.git.mail@cbaines.net> <12f872394c84039fa553e50381d040de24f24d3e.1708457946.git.mail@cbaines.net> Date: Fri, 23 Feb 2024 17:43:11 +0100 Message-ID: <87zfvrdtcw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -3.10 X-Spam-Score: -3.10 X-Migadu-Queue-Id: 4547C1325A X-Migadu-Scanner: mx13.migadu.com X-TUID: b7fCrvoleoLy Christopher Baines skribis: > These names should be more descriptive. > > * guix/store/database.scm (path-id): Rename to select-valid-path-id. > (sqlite-register): Rename to register-valid-path. > (register-items): Update accordingly. > > Change-Id: I6d4a14d4cde9d71ab34d6ffdbfbfde51b2c0e1db OK for =E2=80=98register-valid-path=E2=80=99. For =E2=80=98path-id=E2=80=99 my preference would be =E2=80=98valid-path-id= =E2=80=99 or keeping =E2=80=98path-id=E2=80=99; =E2=80=98select=E2=80=99 looks odd as nothing=E2= =80=99s being =E2=80=9Cselected=E2=80=9D here in the non-SQL sense of the word. Ludo=E2=80=99.