From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id +I2eF0NNXWb9RAAAqHPOHw:P1 (envelope-from ) for ; Mon, 03 Jun 2024 06:57:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id +I2eF0NNXWb9RAAAqHPOHw (envelope-from ) for ; Mon, 03 Jun 2024 06:57:39 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="DEfq/ScO"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1717390659; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=nDBkRgKZQtrIIq+mAUKmOOXJxHWLhB16mPWOBbcX4J0=; b=Q6cqtGDOPRu0uOfO6ZvnpVcQMS33xlMQaTixk4TNG3rpAt7CJs6JuOvFyqsZg3T9LHsxsm pqeQUONn+o+sCwz67Md+QZ78H6fJ0p2F1mS7v04IDcFsDdbBfdMsLMgSWbg3cP2uR52ZKK 9/dTdqNroTgjy7yDNfHlM948DWnZLaTgOANtSjzytwm+cRPs0Aww7T5SNbPqWbiVn9Ev3W sR1Efo465wZIpd5Mz7Ds5jQpG6m4KQdra3pshnWiZxR+kw2ZJnPA974zLrDe/+7BQPKP3v MUuX7Q3jdFhWdPXerXecNT0Y9DrF9VlSPv61TQhXwSLWXA4wxyDE/ZsPnZJB6A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="DEfq/ScO"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1717390659; a=rsa-sha256; cv=none; b=SM04GVHop8z1iKCD7W4BiYao5Epbk9xVuJ1WzuqxHAX6kzmIk7f68r1kb7Sr8YV/caz+Vo PuA9yljWU72Xu4/xL/Gbbqx7Db6rS5yPb0SBL6YyC42LT3IVULANIlMmycDA8TvUcMFNUR RFa2JpzOKhtLsa2B5JL7FbXYY5XvA8XdCrKoc+w7F4Ql3HsHpBqIYq5trWOyklVJM4lp2N yPP4J62UF4cWW6ZZS+3F7xMATlfPlCyB3BALGNSYD2MictFt5H/PAyAP+RfU7g0qYP4aQE Z/tJHW5ojwuYNQwOTTkimyNIOcmObdDz2GVXX0sOARMrmFvqU59HQP74oaBgrg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2144A61EB3 for ; Mon, 3 Jun 2024 06:57:39 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sDxxy-0000nq-0P; Sun, 02 Jun 2024 23:02:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDxxu-0000kL-Rr for guix-patches@gnu.org; Sun, 02 Jun 2024 23:02:30 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sDqNt-0000Wm-SX for guix-patches@gnu.org; Sun, 02 Jun 2024 14:56:49 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sDqO6-0007hY-7g for guix-patches@gnu.org; Sun, 02 Jun 2024 14:57:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71064] [PATCH 7/7] gnu: services: nscd: add Nsncd optional support. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 02 Jun 2024 18:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71064 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: picnoir@alternativebit.fr Cc: 71064@debbugs.gnu.org Received: via spool by 71064-submit@debbugs.gnu.org id=B71064.171735457729554 (code B ref 71064); Sun, 02 Jun 2024 18:57:02 +0000 Received: (at 71064) by debbugs.gnu.org; 2 Jun 2024 18:56:17 +0000 Received: from localhost ([127.0.0.1]:60280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDqNM-0007gb-MP for submit@debbugs.gnu.org; Sun, 02 Jun 2024 14:56:16 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDqNL-0007gQ-GS for 71064@debbugs.gnu.org; Sun, 02 Jun 2024 14:56:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDqN3-0000Tz-DV; Sun, 02 Jun 2024 14:55:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=nDBkRgKZQtrIIq+mAUKmOOXJxHWLhB16mPWOBbcX4J0=; b=DEfq/ScOjAjFpDRtlF2l dMC4Anqbr7xqlF2Ay8ywY5As+N0eekHxPOOt8vyey9cbH67u2RveiW9HsGioxXtS61+HeOjci110S uqAIcvUmnrB2ldel92Aa9ajX66eHrh2OmQEvz9nKgELKR0cSUDo0kCXti0E8N5w2Tup7In49ycQO5 0TrHXia5NPfJOrAddH1dM+Pv++zr4ORoGQqjlsx1+LTj7wTNTtWUEwQbxPnyqNOzaFcT69NxeV0Jz fP2yWJiL8dfwezlCZw3/SoTdjSboKFEWMj8huv8hXnWqVk+7zacUl5+EvuuvaIHxNugWt/2K57BnB iUGj5HihOtiouw==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: (picnoir@alternativebit.fr's message of "Sun, 19 May 2024 14:46:27 +0200") References: Date: Sun, 02 Jun 2024 20:55:54 +0200 Message-ID: <87zfs3jhs5.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -7.24 X-Spam-Score: -7.24 X-Migadu-Queue-Id: 2144A61EB3 X-Migadu-Scanner: mx13.migadu.com X-TUID: d9l0v/d/yS1l Hi, picnoir@alternativebit.fr skribis: > From: Picnoir > > * gnu/services/base.scm (services: nscd: add Nsncd optional support): Add= a > new nscd-use-nscd? field in the Nscd configuration record. When set to #t= , the > nscd service will use Nsncd in place of the Glibc's Nscd. I'm not 100% su= re > adding this to the existing Nscd service is a good idea, it's however the= most > convenient option for now. Or is it? :) Well, there needs to be a flag somehow. :-) Nitpick: could you describe the changes at a syntactic level in the commit log? I know our conventions aren=E2=80=99t common today, so whoever commits it can eventually tweak it on your behalf if needed. > + (use-nsncd? nscd-use-nsncd? ;boolean > + (default #t)) I=E2=80=99m tempted to make it: (implementation nscd-implementation (default 'glibc)) And thus 'nsncd would be the other supported value. Do you think that makes sense? Anyhow, could you adjust doc/guix.texi to mention the new field? Apart from that, the patch looks good to me. Could you send an updated version? Thanks! Ludo=E2=80=99.