From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id gFqgKuol12bbOAEAe85BDQ:P1 (envelope-from ) for ; Tue, 03 Sep 2024 15:06:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id gFqgKuol12bbOAEAe85BDQ (envelope-from ) for ; Tue, 03 Sep 2024 17:06:18 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=PI5tZKOl; dkim=fail ("headers rsa verify failed") header.d=pelzflorian.de header.s=key2 header.b=apw1ss2o; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1725375978; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=z9ZG272si4lbaoR1kBmi0wO0ef5vErKulkFF3topTJQ=; b=iLqjmdE33xCFpL++Pz+L5E2BA75eFl1rhGEms1Mvfwg6TEFh1beHcB1HCAEjZNWh1q5SUW wO7SYnne/WJxKAok6Ye7cD4iEd6XcQN++lCmZOdPdNgSAXqA3V1pEZJde2yrIBi6q8ZbNT CcXNf61jU1jfvzlgrD+lDmmLkW+YRdx+oFVE4P0alkK9LiMd/Fe8IvW4DL10CBPMMHZqFO /Q04FFZCUaXgovCqsq0PVrEcRGAxX5RDvH+5pqsxDT5NdMdwnkPrHStXyRZvqgBOa33+Xc BD3k8QF/tErVv+hAZyUBkc5Kx6WYopbSn2f5s3dPaxWBU1xXgVoEIs4WP9sudw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1725375978; a=rsa-sha256; cv=none; b=WS8F0q1mKdqgHUua9WwyZPd5j0GjGlSSvRbhzACyIdBZDR2abunH+Ff1oKK7m/irykocjX yaMVrlK/FW4W5mf+nxXF8Bb0baYBmmMKdDBA+Xj3OGbXkllQbYzhcEkuKz3bdAN2n5Alql vmbXfb5JJ4YGvjWFluNnG104Ru2rndY9eskBW4m0CzobhLSv771nwPPxVqC7VpdiuUqqeB 6WQAOYeT+1VKtdHDqkZV6+S2vZCpDCBehPiqqcoC/57jEPjjYBh3j9QV9NdebPnpJcDAPM V9lo3EikfID1xihjmo7egDgG+Y3BsG8WAgeGAfLuv3ics4vzK9/5fQ8Wt0TxRQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=PI5tZKOl; dkim=fail ("headers rsa verify failed") header.d=pelzflorian.de header.s=key2 header.b=apw1ss2o; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5EA226150B for ; Tue, 3 Sep 2024 17:06:18 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1slV6b-0003yZ-Qj; Tue, 03 Sep 2024 11:06:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slV6X-0003oC-LW for guix-patches@gnu.org; Tue, 03 Sep 2024 11:06:01 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1slV6V-0000YY-Nc for guix-patches@gnu.org; Tue, 03 Sep 2024 11:06:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=z9ZG272si4lbaoR1kBmi0wO0ef5vErKulkFF3topTJQ=; b=PI5tZKOlksph/MLL7mIn3ScrMWxiagA+nsU05D8vcMgOkHHIySUO2HBHOw8/XpzEZm0nnVABHfUKFEQyQm+LMTirYXLHitLCxXkK5WT6HpjdICg/Lrs4w+UVze5yBOZjxwAMRFKfsQY7+jMQL7nsOy6iQfPpMNsTud9ttsi/OLGNJH6O3zRSlQRhtz3IkPJ+nqBYW8M0DxHjNKg1WKJejkNoWS9MnKOX8f7BGenNOgk5vcRPXP51Jt7bZ+p/1fxF64tuXismUFQCGl9Og54mPlJlizoerzoIYPsyXXKWA4w7l47cB3/a/U4d3UybOYCzX/bMG6mQ2yQfGTmqyIZFIw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1slV7V-00078k-Qm for guix-patches@gnu.org; Tue, 03 Sep 2024 11:07:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72867] [PATCH v3] gexp: Make 'local-file' follow symlinks. Resent-From: "pelzflorian (Florian Pelz)" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 03 Sep 2024 15:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72867 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nigko Yerden Cc: 72867@debbugs.gnu.org Received: via spool by 72867-submit@debbugs.gnu.org id=B72867.172537601927439 (code B ref 72867); Tue, 03 Sep 2024 15:07:01 +0000 Received: (at 72867) by debbugs.gnu.org; 3 Sep 2024 15:06:59 +0000 Received: from localhost ([127.0.0.1]:60532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slV7T-00078T-Fu for submit@debbugs.gnu.org; Tue, 03 Sep 2024 11:06:59 -0400 Received: from relay.yourmailgateway.de ([188.68.63.170]:50211) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slV7P-00078I-RL for 72867@debbugs.gnu.org; Tue, 03 Sep 2024 11:06:57 -0400 Received: from mors-relay8203.netcup.net (localhost [127.0.0.1]) by mors-relay8203.netcup.net (Postfix) with ESMTPS id 4Wyppl4HVPz8Zmm; Tue, 3 Sep 2024 15:05:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=pelzflorian.de; s=key2; t=1725375951; bh=84dsk/8IidU9RSSF6xxOWRqHJc8B8v2Ko5JD6S7p9bo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=apw1ss2oX43cyQyL87QSXVBVbJAVunlgvSUwK0OYEpiKujgaSzbh/HjpGtbeWOyMs /dgZ+5t75UMM9Zgb7HnKgdntHtCKMp9I+11r4AtOnqJErY7sVUldyWuJXjqjIBT0mC ZEQMYxSaof5qAstNaotFJMgWuIeG2qB5AET3+ACHvP1R9XHQYNc5HK2Y1Kf4pjDUIK bYHGmtehktNd7CBoJGyZ57XDd2HHfBjbKThLZFIIYM/ThFNwIksBId3qmu/bP4OTMi I+FnFglfIrBkcGUOvDldF9oF3m+ijmYcxJHfxecTzY1MiGbuaNZLWUjY68xZ/AuIQK GZrDe2NAX+SQQ== Received: from policy01-mors.netcup.net (unknown [46.38.225.35]) by mors-relay8203.netcup.net (Postfix) with ESMTPS id 4Wyppl3Zq3z8ZmB; Tue, 3 Sep 2024 15:05:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at policy01-mors.netcup.net Received: from mxe217.netcup.net (unknown [10.243.12.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by policy01-mors.netcup.net (Postfix) with ESMTPS id 4Wyppl00tfz8scP; Tue, 3 Sep 2024 17:05:50 +0200 (CEST) Received: from florianhp (ipb2186896.dynamic.kabel-deutschland.de [178.24.104.150]) by mxe217.netcup.net (Postfix) with ESMTPSA id 536FD83F42; Tue, 3 Sep 2024 17:05:44 +0200 (CEST) From: "pelzflorian (Florian Pelz)" In-Reply-To: <2d4b593eaea4fed1fb08031a599aaab032442041.1725263612.git.nigko.yerden@gmail.com> (Nigko Yerden's message of "Mon, 2 Sep 2024 12:53:32 +0500") References: <2d4b593eaea4fed1fb08031a599aaab032442041.1725263612.git.nigko.yerden@gmail.com> Date: Tue, 03 Sep 2024 17:05:44 +0200 Message-ID: <87zfoord4n.fsf@pelzflorian.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 536FD83F42 X-Rspamd-Server: rspamd-worker-8404 X-NC-CID: cBUpGpW9i2cOUM2Ogld/M59O4a7S4TXpbkhI7gBSO1trr1sNgFxDL01P X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 5EA226150B X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -9.02 X-Spam-Score: -9.02 X-TUID: 6qlDIpq2tS0s Hello Nigko. Nigko Yerden writes: > This patch is the result of collective work of > Florian Pelz and > Nigko Yerden Thanks for the credit, but it would be unusual to mention me in the commit message, where discussion does not count. Please do not put me in the commit message; I made no code contribution. I also would favor to simplify `current-source-directory' and not add an optional follow-symlinks? argument. I believe processing profiles is the only reasonable case that unconditionally following symlinks would break, and people do not do profile processing in outside code. > * tests/gexp.scm ("local-file, load through symlink"): New test. This one is a good test; but it tests only half, namely the rare-in-practice case of `local-file' when loading a Scheme file. Here, `current-source-directory' evaluate file-name to "/tmp/guix-directory.VxrxZT/dir/link-to-code.scm", which has a slash as prefix, so absolute-dirname is not called. The original issue is that the package in a channel according to cookbook=E2=80=99s =E2=80=9CThe Repository as a Channel=E2=80=9D cannot be = built when the load-path is set up in the usual way. There, absolute-dirname gets called. I think we would need a (very similar) test that covers this. Instead of primitive-load, we would need to invoke Guile on a file in a channel or in the GUILE_LOAD_PATH, or set %load-path. I may be wrong here and do not know how, but we definitely should cover when `file-name' in is not prefixed with a slash. Regards, Florian