bug#73905: guix shell changes default sigaction for SIGPIPE

bug#73905: guix shell changes default sigaction for SIGPIPE

[Tomas Volf]

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]


Guix shell changes the default handler for SIGPIPE for the command it
runs.  Can be demonstrated using the following:

--8<---------------cut here---------------start------------->8---
$ guix shell guile -- guile -c '(pk (sigaction SIGPIPE))'

;;; ((1 . 0))
$ guile -c '(pk (sigaction SIGPIPE))'

;;; ((0 . 0))
--8<---------------cut here---------------end--------------->8---

Have a nice day,
Tomas Volf

-- 
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 853 bytes --]

bug#73905: [PATCH] environment: Restore action for SIGPIPE.

[Tomas Volf]

Code in `ui.scm' in `initialize-guix' procedure changes the handling of
SIGPIPE to SIG_IGN.  So restore the handling to SIG_DFL so that process
executed will have the usual action.  Technically we should record what the
handling was, and restore it to the previous value, but that would be much
more invasive change.

Always setting it to SIG_DFL is at least less surprising than always setting
to SIG_IGN.

* guix/scripts/environment.scm (launch-environment): Restore default action
for SIGPIPE.

Change-Id: Ifabae1d3e71aa44e63078cea5bd3824b8f61ba14
---
 guix/scripts/environment.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/guix/scripts/environment.scm b/guix/scripts/environment.scm
index a219b2ac89..79eb7f3f30 100644
--- a/guix/scripts/environment.scm
+++ b/guix/scripts/environment.scm
@@ -499,6 +499,8 @@ (define* (launch-environment command profile manifest
   ;; Properly handle SIGINT, so pressing C-c in an interactive terminal
   ;; application works.
   (sigaction SIGINT SIG_DFL)
+  ;; Restore original action for SIGPIPE.
+  (sigaction SIGPIPE SIG_DFL)
   (load-profile profile manifest
                 #:pure? pure? #:white-list-regexps white-list)
 
-- 
2.46.0