From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 4JD0IW7QTmd7EwAAqHPOHw:P1 (envelope-from ) for ; Tue, 03 Dec 2024 09:33:34 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 4JD0IW7QTmd7EwAAqHPOHw (envelope-from ) for ; Tue, 03 Dec 2024 10:33:34 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=cWciz6yf; dkim=fail ("headers rsa verify failed") header.d=burningswell-com.20230601.gappssmtp.com header.s=20230601 header.b=d9TF+Vj5; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1733218414; a=rsa-sha256; cv=none; b=hLuXLC5dVXL6euPgoYY5FCv6uHyoLnbWLvCSjJhiHSPcWqoUiagbgAlEKNSzeUMQrd5zIN TFht0OOdprgMERX48hPe0/yBZh2NH8kIAOrJXqJzYtwG5YorxDRilBsi2UJUdDC3EQ8AmI xVmZxvu1XBDkRLh7DVvJuffnyxg6EINosVQC3A+LKeF/0p1BYO4Z1EBFVJr/Ap2wRB8VCi LvjoCJKDdKP4JPb8+ZCWCl/ulbCJXCaDdPmgtVL18musfK6L/Il4sbfcriakya+BKNAMYD zsaEcKQzrMWB+Rihf8CTArb91PdFEtcEMXRmC/R5ZTQnJEO9bm3VTXP7XUf75w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=cWciz6yf; dkim=fail ("headers rsa verify failed") header.d=burningswell-com.20230601.gappssmtp.com header.s=20230601 header.b=d9TF+Vj5; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1733218414; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=JoF/4+nI7lMrHf3YgDSfEBKL7aX9vqOG/lHMu7e0ns8=; b=Os3A2UJJ9zjhqLhrY71MiPz24gBzSUEVxxDfBRmG1GU5W0SaiaI3r1T3P1xjLuPPoV3HMA bQg1qFJekLfJcxTVuzlDZczowvO3Iit8dXHguhm8Lw4hAFyTmLPEPy71s3gSsN17C6G5TV RjSan8HyxSK//eCKLOFCCgALg8U90yuBWwtgjKIV5JMXwL2R5s5fdhj7UGg18G2ZJHM9pI Nkse7JYlkhWKyJ6xSLUPVCMsppKtuqwd0QNGYoQL7dPNZPY+Y0EmpnlMPxrPIwYzfylo5Z BNJBE3LcsZiYWH6gZaQbf4gpusu4WEYmFuaWSiIQuL1xvVsEeXrMCAy9C9eiiA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 530CE1A1D1 for ; Tue, 03 Dec 2024 10:33:34 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tIPHM-0004Xt-BE; Tue, 03 Dec 2024 04:33:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIPHC-0004Xd-Qd for guix-patches@gnu.org; Tue, 03 Dec 2024 04:33:05 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tIPHC-0003zU-Dj for guix-patches@gnu.org; Tue, 03 Dec 2024 04:33:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=JoF/4+nI7lMrHf3YgDSfEBKL7aX9vqOG/lHMu7e0ns8=; b=cWciz6yftv6CGYbmii/kZn00VKhwvzwHBzK3sfJA1K3otuktqXVtEHfYYEkFcAQvFAYjfxMwMcwf8Wxm9QknI90wA3/7pAHUSbtToiNxanzOP1FT7GqikoWPHMjNp9fxAZS94YUZVPRyliekydddKHRW1r52VmBpqoHp2DpEJuwd30gQFTFG1HPxGgpfah6Cuksgft5022jLQl3dyhFoJWwO4KmkUDuDEsfSOHw1EeteKHxrTa8VOFI/x8yo8+FPws+SfCU+nAb0vQ5sXw8qY+lFxcQwB4pAt3udx0QjXMInXnjB7dpNf/qNpgfFYRyDv6Y/AFYbo5/5j/50XSBCpw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tIPHB-0003Lb-Tn for guix-patches@gnu.org; Tue, 03 Dec 2024 04:33:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74648] [PATCH] gnu: librewolf: Add %u to Exec option to open URLs. Resent-From: Roman Scherer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 03 Dec 2024 09:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74648 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ian Eure Cc: =?UTF-8?Q?Andr=C3=A9?= Batista , Mark H Weaver , Roman Scherer , Jonathan Brielmaier , 74648@debbugs.gnu.org Received: via spool by 74648-submit@debbugs.gnu.org id=B74648.173321833712801 (code B ref 74648); Tue, 03 Dec 2024 09:33:01 +0000 Received: (at 74648) by debbugs.gnu.org; 3 Dec 2024 09:32:17 +0000 Received: from localhost ([127.0.0.1]:58287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIPGS-0003KP-T2 for submit@debbugs.gnu.org; Tue, 03 Dec 2024 04:32:17 -0500 Received: from mail-ej1-f41.google.com ([209.85.218.41]:60704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIPGQ-0003K9-5Q for 74648@debbugs.gnu.org; Tue, 03 Dec 2024 04:32:15 -0500 Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a9a0ef5179dso764585366b.1 for <74648@debbugs.gnu.org>; Tue, 03 Dec 2024 01:32:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=burningswell-com.20230601.gappssmtp.com; s=20230601; t=1733218268; x=1733823068; darn=debbugs.gnu.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=JoF/4+nI7lMrHf3YgDSfEBKL7aX9vqOG/lHMu7e0ns8=; b=d9TF+Vj5/AD/vMuPLgyB5hUJNeAPtpj/5vKyVp+rFF9fHlbOk21TZmVXtx4Np5Vj3m eqLrnNOxu8RgNY6Q9cXly7E+2at83+YaD/3A9btspNHEiwfh4ZsdS1dFCzd9uU88nr3v NSq4QCuT5MjxvH/OnlUUH7vQae+y7rThgwUS1ak6ZRT9Irgr9rDi4QCIV3PjL32OTcox kWKW9BdvDnmw12OjlDOZBbM/E6yY/PSRYxi2SL99QMRpbufDZAMqRBqJyeP28zyhnwbh VHPB91n7B4JD3gwPjBa4GseaVHXkAkuqcp6/BYqe8IG7xLCsGb4fCYWpyCI0uxOETalb kKEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733218268; x=1733823068; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JoF/4+nI7lMrHf3YgDSfEBKL7aX9vqOG/lHMu7e0ns8=; b=aLbqWUBqv25ArkGhaSr7Rk+QUZQehbo2b5gard+H067O3X/YAsVgwHpkrz3zdmipKm M3tYOEftRR1XoYuu+Wl3+BgDEcpiAGO++lLtvV4Vy89rhq2E5icbAh0dYnF2J177Vbul Ot6tm02eAcZg5Jhdgghhedbb2ouQB4tvuTJzUnExJFBrHRZoEK6Ec6qGsMhx0B3iWFdT fXHgPp9Ag3a6aJw+nrivZb+/XchSs0jG7l4ghOlRxwhHi4rXR0LhiG5+0AliXq9t0UQu xsga75WczvS443EO6nmqxRK3vbVuUCO+N9V3jFKA5sSbhbnqW7U1YP62Yx9Uuxpciknn Zl6w== X-Forwarded-Encrypted: i=1; AJvYcCWGRBxbkMqDGGmdV8NHh8WSYXDewrf66+RLjGy8CytaTc//Ckda795MC8RXSC6u+wGO6w+eag==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyOqCbbhHcrTgi4/TeGI/VBc8oJzqOyKuPXHLxIUkocET/M9CYN PR5Ud+XpiRXj8CxBFGSJ7iZml6/wL95FdTwaG8k5rh4PRyqU20Vdl+drbqIc8S4= X-Gm-Gg: ASbGncsCIoPz15QjdEan1hWn2MtfFAQThFIRBLYHDy0pnPj6R0FRe7aB2hf7wYS1W3s DIsZ7C2k57m5qUGXjm0GNh1ZusfLK9ocC+nZN2xHwvkrq70lVoazLmIg+6R0HQgAQxYBVUjr7sO KLuKI2EBG/Uk544Mrc7BrsY2TD6ZYM9zVbaL453DCtWctNWNi6AoECwgKUZXsLzM1+xNM/GzaMe 2/6oy7fYYvYU9Ly+nKKsEtwNPC6Z2/5NefHXX0cKzFDTUbakTK7YvP4NMzG2hwfUBGzq9k9r1D7 vjewfzTwCQ== X-Google-Smtp-Source: AGHT+IF54A0MVRzmLpUlyVVc8ixSzUEIn5MOkxAvbNLGxbrM/7LI1iosuaf4wS6tv5FiBVX8mEn64w== X-Received: by 2002:a17:906:1bb1:b0:aa1:e695:f60 with SMTP id a640c23a62f3a-aa5f7eef9dbmr121571666b.41.1733218268189; Tue, 03 Dec 2024 01:31:08 -0800 (PST) Received: from precision (tmo-084-10.customers.d1-online.com. [80.187.84.10]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa5998e64c4sm592759066b.97.2024.12.03.01.31.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2024 01:31:07 -0800 (PST) From: Roman Scherer In-Reply-To: <87cyiam4iz.fsf@retrospec.tv> (Ian Eure's message of "Mon, 02 Dec 2024 08:30:12 -0800") References: <875xo2f6ii.fsf@burningswell.com> <87cyiam4iz.fsf@retrospec.tv> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Tue, 03 Dec 2024 10:31:05 +0100 Message-ID: <87zflddsfa.fsf@burningswell.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -11.80 X-Spam-Score: -11.80 X-Migadu-Queue-Id: 530CE1A1D1 X-Migadu-Scanner: mx10.migadu.com X-TUID: 38o5Cl0nCv0F --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ian Eure writes: Ok, thanks for the summary Ian. Looking forward for the patch to be applied. Thanks, Roman. > Hi Roman, Andr=C3=A9, > > Roman Scherer writes: > >> Andr=C3=A9 Batista writes: >> >> Hi Andr=C3=A9, >> >> thanks for taking a look. So this is fixing a security issue? Which >> one >> exactly? Is it this one? >> > > This isn=E2=80=99t a security issue, the concern was created in a change = which > also had security updates. The current nature of the browser > ecosystem means nearly every Firefox update contains security fixes, > so presence of them isn=E2=80=99t a very useful signal. > >> >>> Hi Roman, >>> >>> seg 02 dez 2024 =C3=A0s 13:20:20 (1733156420), roman@burningswell.com >>> enviou: >>>> * gnu/packages/librewolf.scm (librewolf): Add %u to Exec option to >>>> open URLs. >>>> >>>> Change-Id: I8cf5d3886eaf7805209cf12eae0cc875bef6d5dd >>>> --- >>>> gnu/packages/librewolf.scm | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/gnu/packages/librewolf.scm >>>> b/gnu/packages/librewolf.scm >>>> index 5d432cfad8..42d212e9f9 100644 >>>> --- a/gnu/packages/librewolf.scm >>>> +++ b/gnu/packages/librewolf.scm >>>> @@ -605,7 +605,7 @@ (define-public librewolf >>>> (substitute* desktop-file >>>> (("^Exec=3D@MOZ_APP_NAME@") >>>> (string-append "Exec=3D" >>>> - #$output >>>> "/bin/librewolf")) >>>> + #$output >>>> "/bin/librewolf %u")) >>>> (("@MOZ_APP_DISPLAYNAME@") >>>> >>> >>> This was its previous state and was removed on commit >>> 280aa6b57d7b741a7d8b076e1afa3dff23569332. See also #74070. >>> >>> Copying Ian, who was the author of that change and has been >>> maintaining >>> Librewolf. >>> > > The context behind this change is that Firefox used to ship a > taskcluster/docker/firefox-snap/firefox.desktop file which had an Exec > line like this: > > Exec=3D@MOZ_APP_NAME@ %u > > The Guix package would use that file, replacing the token with the > path to the binary. The presence of %u in the package definition is > because the substitute* regexp is sloppy and replaces the whole line > instead of @MOZ_APP_NAME@ only. For reasons unknown to me, Firefox > stopped shipping this file and deleted it from their repo. I looked > around the repo and found > toolkit/mozapps/installer/linux/rpm/mozilla.desktop, for the rpm > package. Its Exec line is: > > Exec=3D@MOZ_APP_NAME@ > > So I updated the package to use that, and the regexp to match. > > The patch in #74648 looks fine to me, and I think it should be pushed. > > Thanks, > > =E2=80=94 Ian --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFLBAEBCAA1FiEE0iajOdjfRIFd3gygPdpSUn0qwZkFAmdOz9oXHHJvbWFuQGJ1 cm5pbmdzd2VsbC5jb20ACgkQPdpSUn0qwZltUwgAylZfrGjCIqUv6sfwVyQr1tlp KfMYqbGRhzBwO1af04s7mjzzj4YlVKSK4pCO8MHcLmyDyzCwwFUsB0SyV/YbQZI6 9APQb8E/ixsVE6Fzn6/TmeMe7aFY5i+atPZOlP1bLuSause8uht0/DsTeNxB3n8h R4QvqcIzPq1e6bQfwTfIgOlC4X9Cr/D2h1xaai88XyDLsC87zIPBdnXgl/b95jbF CzzMhZa/bXFNMe0kMU4V0ZTpN2QkiHHnx9kQwJtFYhrYx10JNrKDZryMLZQ4dl6g j37ZIScYfgu8y9YonjIVztaD+g+gtGvMihcK+8dJ8v3Gw16jChPgjQ6XPuVQPg== =uDiC -----END PGP SIGNATURE----- --=-=-=--