From: Divya Ranjan via Guix-patches via <guix-patches@gnu.org>
To: 75243@debbugs.gnu.org
Cc: mail@nicolasgoaziou.fr
Subject: [bug#75243] [PATCH] gnu: Add emacs-binder.
Date: Thu, 02 Jan 2025 04:59:30 +0000 [thread overview]
Message-ID: <87zfk93j65.fsf@subvertising.org> (raw)
In-Reply-To: <877c7ebi84.fsf@nicolasgoaziou.fr> (Nicolas Goaziou via Guix-patches via's message of "Wed, 01 Jan 2025 17:40:27 +0100")
Also, Nicholas I forgot to include the Copyright signature in my patch, could you just include it yourself? "Divya Ranjan Pattanaik <divya@subvertising.org>".
Nicolas Goaziou via Guix-patches via <guix-patches@gnu.org> writes:
> Hello,
>
> Divya Ranjan via Guix-patches via <guix-patches@gnu.org> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-binder): New variable.
>
> Thank you. Some comments follow.
>
>> +(define-public emacs-binder
>> + (package
>> + (name "emacs-binder")
>> + (version "20241023.1154")
>
> Version should be "0.5.0", as set in "binder.el".
>
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (string-append "https://melpa.org/packages/binder-" version ".tar"))
>
> Guix does not use MELPA as upstream because tarballs are not reliable.
> Please use Codeberg repository instead.
>
>> + (sha256
>> + (base32 "1nvsmmg9wwan5y38dpcpffzxxvivi4708ri64f03gwcq66g1k49m"))))
>> + (build-system emacs-build-system)
>> + (home-page "https://codeberg.org/divyaranjan/binder")
>> + (synopsis
>> + "Binder is a global minor mode to facilitate working on multiple files")
>> + (description "Primarily, Binder provides a global minor mode
>> binder-mode.
>
> "binder-mode" -> "Binder mode".
>
>> +This allows working with files in the current
>> binder-project-directory.
>
> "binder-project-directory" -> "@code{binder-project-directory}".
>
>> +Data concerning these files is saved in a .binder.el file in the
>> project directory.")
>
> I don’t think the last sentence is useful in the description as it
> merely describes the internals of the package. I suggest to remove it.
> If you absolutely want to keep it, I suggest to apply proper markup:
> ".binder.el" -> "@file{.binder.el}".
>
> Could you send an updated patch?
>
> Regards,
--
Divya Ranjan,
Philosophy, Mathematics, Libre Software.
PGP Fingerprint: F0B3 1A69 8006 8FB8 096A 2F12 B245 10C6 108C 8D4A
next prev parent reply other threads:[~2025-01-02 5:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-01 15:29 [bug#75243] [PATCH] gnu: Add emacs-binder Divya Ranjan via Guix-patches via
2025-01-01 16:40 ` Nicolas Goaziou via Guix-patches via
2025-01-01 20:13 ` Divya Ranjan via Guix-patches via
2025-01-02 4:59 ` Divya Ranjan via Guix-patches via [this message]
2025-01-03 11:02 ` Nicolas Goaziou via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfk93j65.fsf@subvertising.org \
--to=guix-patches@gnu.org \
--cc=75243@debbugs.gnu.org \
--cc=divya@subvertising.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.