From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 2D3UFX9reWeTHgEAqHPOHw:P1 (envelope-from ) for ; Sat, 04 Jan 2025 17:10:23 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 2D3UFX9reWeTHgEAqHPOHw (envelope-from ) for ; Sat, 04 Jan 2025 18:10:23 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=E0YK0dME; dkim=fail ("headers rsa verify failed") header.d=muradm.net header.s=mail header.b=KvT0aWmu; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=muradm.net (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1736010623; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=E39Rn3r8ZjzD3tN7A0cc7kqRWmA5d0OuIFm7g74Yarg=; b=XkuYcyYd5c9CLny881vx7uiznUkVyWWsyJbwdf02JKyKDR7aGCIAPaeW+6aV6OWpFAWgEk VUf5QZ5IxBkh7EtJF2NHJkR+SUP3+kKr4cJphmMXpZ3Cth5Entsq85e6aL17/4R+H3ekvL 0hEd+kWjUAkA7lZqtS2xi1Rerl7yBK0gDWo73P+rccCqxUxnb7KLyZo9eHdI/JNilqv1Up qN2fWjlf0AAkFaIStR0xNFvoNmhOkWDd7lk2lU07+ODJLbU6qw7hm+mAtkO966mw5/orKi yWVfdwOIv+CTgQvCiM6WIXZA8hIP0p9f1WM6HOrV5G5XEgwaZyRJTP3yqknY+A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=E0YK0dME; dkim=fail ("headers rsa verify failed") header.d=muradm.net header.s=mail header.b=KvT0aWmu; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=muradm.net (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1736010623; a=rsa-sha256; cv=none; b=Y0+nZ4vPhaXo1wUhYVkbYBXPGNOk0A1Ompxp1UBXITkl+riJwyeqek0djtXs/WAEZ4KAQX WRmAsQK4KHCdeQFcBPKGvoUMlEJCbkHTXq5wQsMT90tZ+J/4FoLiXAkmfarvMz01gdVhn8 8sqAV2H6Y3zks4h5f2MoapIynYhvHcRqamHb4+n5C9MuhwAEyzKwq9haUYRKqtWMVOsLSf BVm8RbQJj/9UKcc+4Xnhz8WQyFqn9Coxw2BG7cqfjLx1DsYN8osBZVn5hrm2XAibPgusQK b5lHvGg1RL91TSnIwiD97R5t8tQvPIsLt01loDIgd6fl1kyy76W2kSHxxpdhFQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2D0FA7BFAE for ; Sat, 04 Jan 2025 18:10:23 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tU7f4-0005dx-Pr; Sat, 04 Jan 2025 12:10:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU7f1-0005bg-0N for guix-patches@gnu.org; Sat, 04 Jan 2025 12:10:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tU7f0-00032m-Np for guix-patches@gnu.org; Sat, 04 Jan 2025 12:10:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=E39Rn3r8ZjzD3tN7A0cc7kqRWmA5d0OuIFm7g74Yarg=; b=E0YK0dMEvkRv5icvmoHF/PfI/9XB33AgrSd8K6BwF4d04I/PyC0NmX9GsxBQOOqZnvy9L/7T8YOvNgZKrWTmQ64+zkFDB55zshm8D2T02MbWy+m40Wu5+S8pkHx9XOPiOVGAtOjZT1WtzByfV1D6pqbAtQs3tr2vX++z3utyzS9RiTob2ur285SygAnhywHAGFSXOtoPx/EBL+cGEN2pkRT9PK38RX2fe9GdbXsBvCCt73NV5Q+ZKJEkCT0LOtPdYi/ju12MTMVg4T6r9c73iGwS61ZaXkV/bk41yPjyfOYOrgCcjqJ9SjsH3SHTXEWmozxSV531YN2ln9gXLKrhnQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tU7f0-0002WK-46 for guix-patches@gnu.org; Sat, 04 Jan 2025 12:10:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#70318] [PATCH] Fix unitentional creation of greeter's home directory Resent-From: muradm Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 04 Jan 2025 17:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70318 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Graves Cc: 70318@debbugs.gnu.org, lgcoelho@disroot.org Received: via spool by 70318-submit@debbugs.gnu.org id=B70318.17360105539621 (code B ref 70318); Sat, 04 Jan 2025 17:10:01 +0000 Received: (at 70318) by debbugs.gnu.org; 4 Jan 2025 17:09:13 +0000 Received: from localhost ([127.0.0.1]:57003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU7eD-0002V6-2z for submit@debbugs.gnu.org; Sat, 04 Jan 2025 12:09:13 -0500 Received: from nomad-cl1.muradm.net ([139.162.159.157]:54966) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tU7e7-0002UR-3S for 70318@debbugs.gnu.org; Sat, 04 Jan 2025 12:09:10 -0500 Received: from localhost ([127.0.0.1]:49294) by nomad-cl1.muradm.net with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.1) (envelope-from ) id 1tU7aH-0001vT-2S; Sat, 04 Jan 2025 17:05:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=muradm.net; s=mail; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=E39Rn3r8ZjzD3tN7A0cc7kqRWmA5d0OuIFm7g74Yarg=; b=KvT0aWmunX9QgPkxHhL7UZx+BR 2Exdhl6S+NcaYvVO8+QOWOeoyaLmwDf7P6M2tnDcQC4Q1hiKx+PnZrkpID5ljvDYEtH49JSRzTUuV JHYLFSJH+S7cMPcr5qF47YscdQwkytdHB8HJKbcz1OuEqKNMdoGmxt8aexP+k7lofXSfREE0sd1iR thKJHcBN0G7zDFXI9XJOiSR7hd+++EuAm6jK0Cr59nBfsQ3RVtpQGybHV9M4chRPUjpYKdSG/DUQ1 /SUzQMc7JYuqhfhAgsoXpoHCg2WgbigHEQzrGuZWnRf2yJbTi1AvtFprZxiPQZFsCBljZcuG5NOxC B30c3k1PxJhgfGju/TWoeNEoRCwPMyFZy/nmaDH76r/MJK+3WoHTbQmfZ3/zeqkHjW6n1+LZdjy0h o9K4yTFiodbTlzU38fs/Mr9DeZGWcQkTEHFrV7heIFug4gZDmVr/X+Sh8S/bsIy3v7GikOAuIUCAE TEgUfMyUNPVYK/TCLBHP136z; Received: from muradm by localhost with local (Exim 4.98) (envelope-from ) id 1tU7dy-000000003uv-45Lp; Sat, 04 Jan 2025 20:08:58 +0300 From: muradm In-Reply-To: <878qrqr54i.fsf@muradm.net> (muradm's message of "Sat, 04 Jan 2025 18:05:49 +0300") References: <87msg73h8x.fsf@muradm.net> <87o70mzn9b.fsf@ngraves.fr> <878qrqr54i.fsf@muradm.net> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Sat, 04 Jan 2025 20:08:58 +0300 Message-ID: <87zfk6o6ad.fsf@muradm.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: -2.76 X-Spam-Score: -2.76 X-Migadu-Queue-Id: 2D0FA7BFAE X-TUID: zM3SWVmvyReq --=-=-= Content-Type: text/plain; format=flowed muradm writes: >> >> Then maybe we can make it conditional on agreety? >> >> If all greetd-configuration-terminals have their >> greet-default-session-command being an greetd-agreety-session?, >> we >> could >> set it to #f. >> >> Something like this could work: >> (create-home-directory? (not (every greetd-agreety-session? >> (map >> greetd-default-session-command (greetd-configuration-terminals >> config))))) >> >> WDYT? > > 2 of 3 greeters needs home. With improvements implemented by > 75270 > `greetd-terminal-configuration` is detached from details of its > `default-session-command`. By this, any user can workout its > greeter. > If we hardcode implementation of greeter in terminal user may > loose > such flexibility. Also once you implement such condition, you > will > have to maintain with any other greeter added in the future. > > One way would be to carry this flag into `greetd-configuration`, > IMHO > will uneccessarily complicate the things. Is there any good > reason for > doing that? > > What is the problem with having home directory for greeter user? After some more meditation, I remembered that originally I also did not like idea of having extra user home directory and considering changes introduced by #75270, it became obvious that sway specific environment can be setup within `make-greetd-sway-greeter-command`. Further greeters may either improve on it, or provide their own entry point commands as they see fit. v2 of 75270 includes this change, and adjusts the environment accordingly. This issue can be closed in favor if 75270. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEESPY5lma9A9l5HGLP6M7O0mLOBeIFAmd5ayoACgkQ6M7O0mLO BeJVUxAA2h5kx1b+6EBOXS3RjhfUZEo8BqJjWxQtSCR0Oto3NpyidUb6aLjyk1Km 5TXpUst8f4Tuc1PPyCkVkT8rsQ/fh9ijx/JwtP7vWUiUBYC30OWVsfZOY8P6nTpb eqb6e6i2qaJQySh5WY/djg+M43wMcIhwAw9/BKpA2De4PM5HrTXe0PG9XEUoiCyI MF5v3uWLBqgB4WAC7l605SSqFdqHhub/dbX2oyHndORjO685eoRytHAUA1ITkP5W uAX2oQ2bVjdtGENW67937Gl0/LR1RFRNku3oYlurNGfc3y7QTHxYdIfgFgFCRoKz Wvl2QQby9xc1MAocszGmnUkbL6tUVB/w4/If2OfYBBO5eP1RCnEp04zI3Lfu5cT8 N6EiUK69654X+Mizng0ZMXlM6enzSBLkKS8qRNX7UkdHb3Fs+SdD9/smFbu6cxSr CSkJHRcqB2Xx28tjCehmxwnxvoEhgIgUBwvtHHyvnFNxYv+tyTxwBIPzKzQBE+ZO hPMN3oEnUhMUGRsfQDIN/lRLsKyzsE+Ly2+gJhaQTyP/TRZj4OZmptlqOVR0uICN JcgooIo6elJwTeHjfRYA6dwfi43kHAxgyMXmmKLWF0s6qcMRrXi86UgoGGi5oY9F xYuMP2ToyJkchGuKwjqEB9sZRxNu87fFNbHAL15wVkR9trnKBo8= =TaIj -----END PGP SIGNATURE----- --=-=-=--