[PATCH] Various issues

[PATCH] Various issues

[John Darrington]

[-- Attachment #1.1: Type: text/plain, Size: 465 bytes --]

Attached are several patches addressing cross-compilation issues,
culminating in a large patch affecting lots of files, moving 
various "inputs" to "native-inputs".

It's possible that I may have made a few errors here, but I think
the overall effect is a positive one.


J'


-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


[-- Attachment #1.2: guix-xcompile-patches.tar --]
[-- Type: application/x-tar, Size: 146821 bytes --]

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Cross-compilation fixes

[Ludovic Courtès]

John Darrington <john@darrington.wattle.id.au> skribis:

> Attached are several patches addressing cross-compilation issues,
> culminating in a large patch affecting lots of files, moving 
> various "inputs" to "native-inputs".

Could you send them inline, one message per patch?  That would
significantly ease review.

(‘git format-patch’ and ‘git send-email’ can be used for that, as noted
in HACKING.)

> It's possible that I may have made a few errors here, but I think
> the overall effect is a positive one.

:-)

Thanks in advance!

Ludo’.

Re: Cross-compilation fixes

[John Darrington]

[-- Attachment #1: Type: text/plain, Size: 927 bytes --]

On Sat, Dec 14, 2013 at 05:55:53PM +0100, Ludovic Courtès wrote:
     John Darrington <john@darrington.wattle.id.au> skribis:
     
     > Attached are several patches addressing cross-compilation issues,
     > culminating in a large patch affecting lots of files, moving 
     > various "inputs" to "native-inputs".
     
     Could you send them inline, one message per patch?  That would
     significantly ease review.

I'll see what I can do.
     
     (‘git format-patch’ and ‘git send-email’ can be used for that, as noted
     in HACKING.)

I can't find any mention of "git send-email" in HACKING, and there appears
to be no such command.  At least not in the git that I have installed (1.7.10.4)

J'

     

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: Cross-compilation fixes

[Cyril Roelandt]

On 12/14/2013 06:22 PM, John Darrington wrote:
> On Sat, Dec 14, 2013 at 05:55:53PM +0100, Ludovic Courtès wrote:
>       John Darrington <john@darrington.wattle.id.au> skribis:
>
>       > Attached are several patches addressing cross-compilation issues,
>       > culminating in a large patch affecting lots of files, moving
>       > various "inputs" to "native-inputs".
>
>       Could you send them inline, one message per patch?  That would
>       significantly ease review.
>
> I'll see what I can do.
>
>       (‘git format-patch’ and ‘git send-email’ can be used for that, as noted
>       in HACKING.)
>
> I can't find any mention of "git send-email" in HACKING, and there appears
> to be no such command.  At least not in the git that I have installed (1.7.10.4)
>
> J'
>

Depending on your distribution, it might be part of another package 
(git-email in Debian, for instance). It is an extremely nice tool. You 
can generate a patch series by doing:

$ git format-patch <commit>


This will generate a bunch of files called 0001-commit-title, 
0002-commit-title and so on. Then just do:

$ git send-email --to guix-devel@gnu.org --in-reply-to <message-id of 
your first message> 000*.patch

And we'll get all your patches in a nice thread :)


I'll take a look at the HACKING file and add the necessary instructions.


Cyril.

Re: Cross-compilation fixes

[Ludovic Courtès]

John Darrington <john@darrington.wattle.id.au> skribis:

> On Sat, Dec 14, 2013 at 05:55:53PM +0100, Ludovic Courtès wrote:

[...]

>      (‘git format-patch’ and ‘git send-email’ can be used for that, as noted
>      in HACKING.)
>
> I can't find any mention of "git send-email" in HACKING,

Right.

> and there appears to be no such command.  At least not in the git that
> I have installed (1.7.10.4)

It’s in the ‘git-email’ package on Debian and derivatives, apparently.

Ludo’.