From: ludo@gnu.org (Ludovic Courtès)
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: Guix-devel@gnu.org
Subject: Re: [PATCH] gnu: hurd: Add Hurd Minimal.
Date: Sun, 25 May 2014 01:12:01 +0200 [thread overview]
Message-ID: <87y4xq4vr2.fsf@gnu.org> (raw)
In-Reply-To: <CAFtzXzMAf8xfCKmaZFNawcuECR3Y1zv6MR9BEdUN_8Mu-QwQuQ@mail.gmail.com> (Manolis Ragkousis's message of "Sat, 24 May 2014 19:57:37 +0000")
Manolis Ragkousis <manolis837@gmail.com> skribis:
> This patch adds Hurd minimal package which builds 'libihash.a' and a
> patch which disables linking of libihash against glibc. Next is the
> glibc/hurd package, but I will send it later/tomorrow cause there is
> something I need to ask the Hurd guys first.
Great, keep up the good work. :-)
> From 137cb57dfb6b983521f758992a4424301acb4281 Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <manolis837@gmail.com>
> Date: Sat, 24 May 2014 17:17:49 +0000
> Subject: [PATCH] gnu: hurd: Add Hurd Minimal.
>
> * gnu/packages/hurd.scm (hurd-minimal): New variable.
> * gnu/packages/patches/hurd-minimal.patch: New patch.
> * gnu-system.am (dist_patch_DATA): Add it.
[...]
> +(define-public hurd-minimal
> + (package
> + (name "hurd-minimal")
> + (version "0.5")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "git://git.savannah.gnu.org/hurd/hurd")
> + (commit "353fe33eb2481a14dc324c7c2e52b2032df86465")))
It may be OK currently if the version of hurd-headers does not match
that of the actual hurd, but we’ll have to be cautious.
Eventually we should consider changing hurd-headers to use the same
source (and hurd-minimal and hurd would just use (package-source
hurd-headers).)
> + (outputs '("out"))
Can be omitted (it’s the same as the default value.)
> + (arguments
> + `(#:out-of-source? #t
> + #:phases (alist-replace
> + 'install
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((out (assoc-ref outputs "out")))
> + ;; We need to copy libihash.a to the output folder manually,
> + ;; since there is no target for that in the makefile
> + (copy-recursively "libihash"
> + (string-append out "/libihash"))
This creates
/gnu/store/.../libihash/{libihash.a,Makefile,ihash.c,ihash.o,...}. Is
it really what’d intended?
I would expect that the intent is to create
/gnu/store/.../{lib/libihash.a,include/ihash.h}, no?
> + (lambda* (#:key inputs source #:allow-other-keys)
> + (let ((glibc (assoc-ref inputs "glibc-hurd-headers")))
> + (zero? (system* "autoreconf" "-vif"))
> + #t))
Can be simplified to:
(lambda _
(zero? (system* "autoreconf" "-vfi")))
Note that the effect of the trailing #t above was to ignore the result
of ‘system*’, which means ignoring errors when they occur.
> --- /dev/null
> +++ b/gnu/packages/patches/minimal-hurd.patch
Please add a line or two in the patch saying what it does, and linking
to the original discussion.
> @@ -0,0 +1,47 @@
> +diff --git a/configure.ac b/configure.ac
> +index ecabfdf..7ede6db 100644
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -83,6 +83,13 @@ AC_PROG_INSTALL
> + AC_PROG_AWK
> + AC_PROG_SED
> +
> ++if test "x$cross_compiling" = "xyes"; then
> ++ # It may be that we don't have a working libc yet, for instance
> ++ # because we're bootstrapping the cross-compilation tool chain.
> ++ # Thus, use this undocumented Autoconf macro designed for this.
> ++ AC_NO_EXECUTABLES
> ++ echo done
> ++fi
I gather that this works as advertised, but could you confirm by
replying to
<http://lists.gnu.org/archive/html/bug-hurd/2014-04/msg00139.html>?
That would allow us to push the patch upstream.
> +-# Check if libc contains getgrouplist and/or uselocale.
> +-AC_CHECK_FUNCS(getgrouplist uselocale)
> ++# We do not need to check if libc contains getgrouplist
> ++# and/or uselocale for now.
> ++# AC_CHECK_FUNCS(getgrouplist uselocale)
I’ve just posted a patch for that, we’ll see.
> +-# Check for Sun RPC headers and library.
> ++# Check only for Sun RPC headers. We do not need the library yet.
> + AC_CHECK_HEADER([rpc/types.h], [HAVE_SUN_RPC=yes], [HAVE_SUN_RPC=no])
> +-AC_SEARCH_LIBS([clnt_create], [], [:], [HAVE_SUN_RPC=no])
> ++# AC_SEARCH_LIBS([clnt_create], [], [:], [HAVE_SUN_RPC=no])
> + AC_SUBST([HAVE_SUN_RPC])
What’s the problem that’s addressed here?
Thanks,
Ludo’.
next prev parent reply other threads:[~2014-05-24 23:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-24 19:57 [PATCH] gnu: hurd: Add Hurd Minimal Manolis Ragkousis
2014-05-24 22:05 ` Nikita Karetnikov
2014-05-24 22:42 ` Ludovic Courtès
2014-05-24 23:12 ` Ludovic Courtès [this message]
[not found] ` <CAFtzXzMEQnzdvSV5+6NNjEZizoRyoJf4PhBGXqXeTeu7vjU_mg@mail.gmail.com>
2014-05-26 8:24 ` Fwd: " Manolis Ragkousis
2014-05-26 9:22 ` Ludovic Courtès
2014-05-29 20:55 ` Manolis Ragkousis
2014-05-30 16:06 ` Ludovic Courtès
2014-06-01 14:45 ` Manolis Ragkousis
2014-06-01 15:20 ` Manolis Ragkousis
2014-06-01 22:00 ` Ludovic Courtès
2014-06-02 16:28 ` Andreas Enge
2014-06-02 16:31 ` Manolis Ragkousis
2014-06-02 21:30 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4xq4vr2.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=Guix-devel@gnu.org \
--cc=manolis837@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.