From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add wmctrl.
Date: Sat, 06 Dec 2014 15:15:38 +0100
Message-ID: <87y4qk27at.fsf@gnu.org>
References: <87oaridzoj.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53573)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XxG9D-0005Wz-FR
	for guix-devel@gnu.org; Sat, 06 Dec 2014 09:15:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XxG97-0001DN-HM
	for guix-devel@gnu.org; Sat, 06 Dec 2014 09:15:47 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:49714)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1XxG97-0001DC-AK
	for guix-devel@gnu.org; Sat, 06 Dec 2014 09:15:41 -0500
In-Reply-To: <87oaridzoj.fsf@gmail.com> (Alex Kost's message of "Fri, 05 Dec
	2014 15:54:52 +0300")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org

Alex Kost <alezost@gmail.com> skribis:

> - I took the patch for fixing 64-bit bug from
>   <https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/X11/wmctrl/64-=
bit-data.patch>.
>   Should the header comment be changed?

I think this one is OK.

> - I tested it only on 32-bit machine so I don't really know how it works
>   on 64-bit.

It works for me (except that ratpoison seems not to be NetWM-compliant.)

> - Is it ok to make "wmctrl.scm" or would it be more appropriate to put
>   it into "xdisorg.scm"?

xdisorg.scm would seem preferable to me.

> +  gnu/packages/patches/wmctrl-64-fix.patch

Missing backslash.
> +    (synopsis "Command-line tool to control X Window Manager")

=E2=80=9Cto control X11 window managers=E2=80=9D

> +    (description
> +     "Wmctrl allows to interact with an X Window Manager that is compati=
ble
> +with the EWMH/NetWM specification.  It can query the Window Manager for

=E2=80=9Cwindow manager=E2=80=9D (lower case.)

OK to push with these adjustments.

Thanks,
Ludo=E2=80=99.