From: ludo@gnu.org (Ludovic Courtès)
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add wmctrl.
Date: Sat, 06 Dec 2014 15:15:38 +0100 [thread overview]
Message-ID: <87y4qk27at.fsf@gnu.org> (raw)
In-Reply-To: <87oaridzoj.fsf@gmail.com> (Alex Kost's message of "Fri, 05 Dec 2014 15:54:52 +0300")
Alex Kost <alezost@gmail.com> skribis:
> - I took the patch for fixing 64-bit bug from
> <https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/X11/wmctrl/64-bit-data.patch>.
> Should the header comment be changed?
I think this one is OK.
> - I tested it only on 32-bit machine so I don't really know how it works
> on 64-bit.
It works for me (except that ratpoison seems not to be NetWM-compliant.)
> - Is it ok to make "wmctrl.scm" or would it be more appropriate to put
> it into "xdisorg.scm"?
xdisorg.scm would seem preferable to me.
> + gnu/packages/patches/wmctrl-64-fix.patch
Missing backslash.
> + (synopsis "Command-line tool to control X Window Manager")
“to control X11 window managers”
> + (description
> + "Wmctrl allows to interact with an X Window Manager that is compatible
> +with the EWMH/NetWM specification. It can query the Window Manager for
“window manager” (lower case.)
OK to push with these adjustments.
Thanks,
Ludo’.
next prev parent reply other threads:[~2014-12-06 14:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 12:54 [PATCH] gnu: Add wmctrl Alex Kost
2014-12-06 14:15 ` Ludovic Courtès [this message]
2014-12-06 19:42 ` Alex Kost
2014-12-06 22:29 ` Ludovic Courtès
2014-12-07 6:24 ` Alex Kost
2014-12-09 20:53 ` Alex Kost
2014-12-09 21:14 ` Ludovic Courtès
2014-12-07 9:28 ` Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4qk27at.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=alezost@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.