From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: [PATCH] gnu: Add urwid Date: Mon, 02 Feb 2015 00:42:41 -0500 Message-ID: <87y4ogdg32.fsf@netris.org> References: <87bnlddowe.fsf@netris.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58692) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YI9mX-0006bP-Dk for guix-devel@gnu.org; Mon, 02 Feb 2015 00:42:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YI9mU-0000hg-30 for guix-devel@gnu.org; Mon, 02 Feb 2015 00:42:45 -0500 Received: from world.peace.net ([50.252.239.5]:58754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YI9mT-0000hE-W3 for guix-devel@gnu.org; Mon, 02 Feb 2015 00:42:42 -0500 In-Reply-To: (Omar Radwan's message of "Sun, 1 Feb 2015 20:57:33 -0800") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Omar Radwan Cc: guix-devel Omar Radwan writes: > Here's a patch that does all the changes you requested to the previous > patch file A few problems here: (1) This new version doesn't even compile, because of several typos. Please always test before sending patches. (2) Instead of sending a patch that assumes the first version of your patch has been applied, please send a patch that can be applied by itself. (3) In the description, don't put two spaces between every two words, just between sentences. (4) In the source URI specification, please follow our Scheme indentation and spacing conventions, as I showed in my last message in this thread. Can you send an updated patch? Mark