From: Mark H Weaver <mhw@netris.org>
To: Omar Radwan <toxemicsquire4@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: Add urwid
Date: Mon, 02 Feb 2015 00:42:41 -0500 [thread overview]
Message-ID: <87y4ogdg32.fsf@netris.org> (raw)
In-Reply-To: <CAMwaQAKHsVOAJebZkxts_h9cxD2U67fG8ecS_YU6Mn1Z0Y+CTA@mail.gmail.com> (Omar Radwan's message of "Sun, 1 Feb 2015 20:57:33 -0800")
Omar Radwan <toxemicsquire4@gmail.com> writes:
> Here's a patch that does all the changes you requested to the previous
> patch file
A few problems here:
(1) This new version doesn't even compile, because of several typos.
Please always test before sending patches.
(2) Instead of sending a patch that assumes the first version of your
patch has been applied, please send a patch that can be applied by
itself.
(3) In the description, don't put two spaces between every two words,
just between sentences.
(4) In the source URI specification, please follow our Scheme
indentation and spacing conventions, as I showed in my last message
in this thread.
Can you send an updated patch?
Mark
next prev parent reply other threads:[~2015-02-02 5:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-01 22:56 [PATCH] gnu: Add urwid Omar Radwan
2015-02-01 23:23 ` Omar Radwan
2015-02-02 0:14 ` Omar Radwan
2015-02-02 2:32 ` Mark H Weaver
2015-02-02 4:57 ` Omar Radwan
2015-02-02 5:42 ` Mark H Weaver [this message]
2015-02-02 17:46 ` Omar Radwan
2015-02-02 17:59 ` Andreas Enge
2015-02-03 3:37 ` Omar Radwan
2015-02-03 4:42 ` Mark H Weaver
2015-02-03 4:48 ` Omar Radwan
2015-02-03 5:37 ` Mark H Weaver
2015-02-03 17:20 ` Omar Radwan
2015-02-03 21:07 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4ogdg32.fsf@netris.org \
--to=mhw@netris.org \
--cc=guix-devel@gnu.org \
--cc=toxemicsquire4@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.