From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] gnu: Add tvtime. Date: Thu, 07 May 2015 18:51:03 +0300 Message-ID: <87y4l0s7x4.fsf@gmail.com> References: <87pp6oc8hg.fsf@gmail.com> <87bni7e0vu.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35327) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqO4v-0004OS-AD for guix-devel@gnu.org; Thu, 07 May 2015 11:51:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YqO4r-00034K-GY for guix-devel@gnu.org; Thu, 07 May 2015 11:51:13 -0400 Received: from mail-la0-x235.google.com ([2a00:1450:4010:c03::235]:36556) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqO4r-00033u-8G for guix-devel@gnu.org; Thu, 07 May 2015 11:51:09 -0400 Received: by lagv1 with SMTP id v1so33830775lag.3 for ; Thu, 07 May 2015 08:51:07 -0700 (PDT) Received: from leviafan ([217.107.192.170]) by mx.google.com with ESMTPSA id o8sm546642lal.2.2015.05.07.08.51.06 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 May 2015 08:51:06 -0700 (PDT) In-Reply-To: <87bni7e0vu.fsf@gmail.com> (Alex Kost's message of "Wed, 29 Apr 2015 12:31:49 +0300") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: guix-devel@gnu.org Alex Kost (2015-04-29 12:31 +0300) wrote: > Eric Bavier (2015-04-29 01:14 +0300) wrote: > >> On 2015-04-28 15:18, Alex Kost wrote: >>> From dcc331e7ab3fd0687c5a4ef8f084bc0bf4ca1cef Mon Sep 17 00:00:00 2001 >>> From: Alex Kost >>> Date: Tue, 28 Apr 2015 22:21:37 +0300 >>> Subject: [PATCH] gnu: Add tvtime. >>> >>> * gnu/packages/tvtime.scm, >>> gnu/packages/patches/tvtime-gcc41.patch, >>> gnu/packages/patches/tvtime-pngoutput.patch, >>> gnu/packages/patches/tvtime-videodev2.patch, >>> gnu/packages/patches/tvtime-xmltv.patch: New files. >>> * gnu-system.am (GNU_SYSTEM_MODULES): Add package. >>> (dist_patch_DATA): Add patches. >> >> Perhaps we could name the file "tv.scm", in anticipation of other >> TV-related code? > > Indeed, I think it would be better, thanks! > >>> + (inputs >>> + `(("libx11" ,libx11) >>> + ("libxt" ,libxt) >>> + ("libxtst" ,libxtst) >>> + ("libxinerama" ,libxinerama) >>> + ("libxv" ,libxv) >>> + ("libxxf86vm" ,libxxf86vm) >>> + ("libpng" ,libpng) >>> + ("libxml2" ,libxml2) >>> + ("freetype" ,freetype) >>> + ("zlib" ,zlib))) >> >> I think we were lately trying to stay away from aligning inputs like >> this (ISTR Ludo requesting it not be done on some other patch reviews). >> Not sure where the consensus is yet. > > OK, I'm going to remove the aligning. > >>> + (synopsis "High quality television application") >> >> How about "Television viewer"? > > I don't mind. Synopsis/description is always the hardest part for me :-) > >> Otherwise the rest look good to me. > > Thanks for reviewing. I'm going to commit it (taking into account Eric's notes), If no one objects. -- Alex