From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH] gnu: Add ruby-nokogiri
Date: Tue, 14 Jul 2015 16:25:39 +0200
Message-ID: <87y4iihl3w.fsf@elephly.net>
References: <20150713130956.GC28969@thebird.nl> <877fq4i41n.fsf@elephly.net>
	<20150714090613.GA1523@thebird.nl>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45117)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1ZF19f-000779-VE
	for guix-devel@gnu.org; Tue, 14 Jul 2015 10:25:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1ZF19Z-0002VA-MD
	for guix-devel@gnu.org; Tue, 14 Jul 2015 10:25:55 -0400
Received: from sender163-mail.zoho.com ([74.201.84.163]:25933)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1ZF19Z-0002Tw-89
	for guix-devel@gnu.org; Tue, 14 Jul 2015 10:25:49 -0400
In-reply-to: <20150714090613.GA1523@thebird.nl>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Pjotr Prins <pjotr.public12@thebird.nl>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>

> +    (arguments
> +     '(#:tests? #f  ;; test fails because nokogiri can only test with
> +                    ;; an installed extension (now part of install
> +                    ;; phase

You should use a single semicolon for each line here or convert the
comment to not share a line with ‘#:tests?’.

> +       #:gem-flags (list "--use-system-libraries"
> +                     (string-append "--with-xml2-include="
> +                       (assoc-ref %build-inputs "libxml2")
> +                       "/include/libxml2" ))

The alignment here is wrong.  ‘(string-append’ should be aligned with
‘"--use-system-libraries"’ and ‘(assoc-ref’ should be aligned with
‘"--with-xml2-include="’, if I’m not mistaken.

> +       #:phases
> +         (modify-phases %standard-phases
> +           (replace 'build
> +                    (lambda _
> +                      ;; calling rake gem 2x begets a gem. The first time
> +                      ;; only the build-dir is created

If this is so, could we not just create the build directory before
running rake?

> +                      (zero? (begin
> +                               (system* "rake" "gem")
> +                               (system* "rake" "gem"))))))))
> +    (native-inputs
> +     `(("ruby-hoe" ,ruby-hoe)
> +       ("ruby-rake-compiler", ruby-rake-compiler)))
> +    (inputs
> +     `(("zlib" ,zlib)
> +       ("libxml2" ,libxml2)
> +       ("libxslt" ,libxslt)))
> +    (synopsis "Nokogiri (鋸) is an HTML, XML, SAX, and Reader parser")
> +    (description "Nokogiri parses and searches XML/HTML very quickly,
> +and also has correctly implemented CSS3 selector support as well as
> +XPath 1.0 support.")
> +    (home-page "http://www.nokogiri.org/")
> +    (license license:x11)))
> +

~~ Ricardo