Re: [PATCH] gnu: Add ruby-nokogiri

[Ricardo Wurmus <rekado@elephly.net>]

> +    (arguments
> +     '(#:tests? #f  ;; test fails because nokogiri can only test with
> +                    ;; an installed extension (now part of install
> +                    ;; phase

You should use a single semicolon for each line here or convert the
comment to not share a line with ‘#:tests?’.

> +       #:gem-flags (list "--use-system-libraries"
> +                     (string-append "--with-xml2-include="
> +                       (assoc-ref %build-inputs "libxml2")
> +                       "/include/libxml2" ))

The alignment here is wrong.  ‘(string-append’ should be aligned with
‘"--use-system-libraries"’ and ‘(assoc-ref’ should be aligned with
‘"--with-xml2-include="’, if I’m not mistaken.

> +       #:phases
> +         (modify-phases %standard-phases
> +           (replace 'build
> +                    (lambda _
> +                      ;; calling rake gem 2x begets a gem. The first time
> +                      ;; only the build-dir is created

If this is so, could we not just create the build directory before
running rake?

> +                      (zero? (begin
> +                               (system* "rake" "gem")
> +                               (system* "rake" "gem"))))))))
> +    (native-inputs
> +     `(("ruby-hoe" ,ruby-hoe)
> +       ("ruby-rake-compiler", ruby-rake-compiler)))
> +    (inputs
> +     `(("zlib" ,zlib)
> +       ("libxml2" ,libxml2)
> +       ("libxslt" ,libxslt)))
> +    (synopsis "Nokogiri (鋸) is an HTML, XML, SAX, and Reader parser")
> +    (description "Nokogiri parses and searches XML/HTML very quickly,
> +and also has correctly implemented CSS3 selector support as well as
> +XPath 1.0 support.")
> +    (home-page "http://www.nokogiri.org/")
> +    (license license:x11)))
> +

~~ Ricardo