From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: [PATCH 1/2] gnu: fuse: Update to 2.9.4. Date: Tue, 29 Dec 2015 22:34:53 -0500 Message-ID: <87y4ccmwwy.fsf@netris.org> References: <87fuykofs0.fsf@netris.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35751) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aE7XV-0001Qj-JR for guix-devel@gnu.org; Tue, 29 Dec 2015 22:35:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aE7XR-0001k3-K9 for guix-devel@gnu.org; Tue, 29 Dec 2015 22:35:05 -0500 Received: from world.peace.net ([50.252.239.5]:33031) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aE7XR-0001jo-GO for guix-devel@gnu.org; Tue, 29 Dec 2015 22:35:01 -0500 In-Reply-To: <87fuykofs0.fsf@netris.org> (Mark H. Weaver's message of "Tue, 29 Dec 2015 21:02:07 -0500") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Leo Famulari Cc: guix-devel@gnu.org Mark H Weaver writes: > Leo Famulari writes: > >> * gnu/packages/patches/fuse-CVE-2015-3202.patch: Delete file. >> * gnu-system.am (dist_patch_DATA): Remove it. >> * gnu/packages/linux.scm (fuse): Update to 2.9.4. >> [source]: Remove patch. > > This patch broke the build on all platforms, because the source URI > returns 404 "Not Found". See: > > http://hydra.gnu.org/build/905375/nixlog/1/tail-reload > > Starting download of /gnu/store/1yv745ixmy5r5mf5pnlppd31pz0qnqab-fuse-2.9.4.tar.gz > From https://github.com/libfuse/libfuse/releases/download/2_9_4/fuse-2.9.4.tar.gz... > ERROR: download failed "https://github.com/libfuse/libfuse/releases/download/2_9_4/fuse-2.9.4.tar.gz" 404 "Not Found" > failed to download "/gnu/store/1yv745ixmy5r5mf5pnlppd31pz0qnqab-fuse-2.9.4.tar.gz" from "https://github.com/libfuse/libfuse/releases/download/2_9_4/fuse-2.9.4.tar.gz" > > Can you look into it? I went ahead and fixed this myself, after realizing that this problem would cause attempts to build systems that use %base-services to fail, which I expect is almost all of them. The reason is that %base-services includes 'fuse' here: ;; The LVM2 rules are needed as soon as LVM2 or the device-mapper is ;; used, so enable them by default. The FUSE and ALSA rules are ;; less critical, but handy. (udev-service #:rules (list lvm2 fuse alsa-utils crda)) Mistakes in source URIs like this are likely to go undetected for those who use "guix download" to download the source, which is why I never do that. I always use "wget" to download the source, and then "guix hash" to compute the hash (after checking the signature), and finally "guix build -K" to test the updated 'source' field by downloading the source a second time before building the package. Regards, Mark