From mboxrd@z Thu Jan 1 00:00:00 1970 From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=) Subject: Re: [PATCH 2/2] gnu: zita-convolver: Drop the '-march=native' optimization. Date: Thu, 07 Jan 2016 11:58:34 +0800 Message-ID: <87y4c2qbv9.fsf@member.fsf.org> References: <1452095330-14147-1-git-send-email-iyzsong@gmail.com> <874meq5s30.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aH1j9-000861-Bb for guix-devel@gnu.org; Wed, 06 Jan 2016 22:59:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aH1j6-0001rs-4a for guix-devel@gnu.org; Wed, 06 Jan 2016 22:59:07 -0500 Received: from smtp20.openmailbox.org ([62.4.1.54]:58471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aH1j5-0001rd-VD for guix-devel@gnu.org; Wed, 06 Jan 2016 22:59:04 -0500 In-Reply-To: <874meq5s30.fsf@elephly.net> (Ricardo Wurmus's message of "Wed, 06 Jan 2016 22:13:55 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel@gnu.org Ricardo Wurmus writes: >> + (snippet >> + ;; Don't optimize for a specific processor architecture. >> + '(substitute* "libs/Makefile" >> + (("^CXXFLAGS \\+=3D -march=3Dnative") ""))) >> + (modules '((guix build utils))) > > Is this to avoid that packages are optimised for the CPU of the build > slave? Yes, using that from hydra will crash guitarix for me. Same as: . > If so, could we instead pass different optimisation flags for > different architectures? For a convolver I=E2=80=99d prefer to have *som= e* > optimisation, even if it=E2=80=99s just the greatest common divisor. I don't familiar with optimization flags, but according to: I think '-march=3Dnative' should be dropped definitely, it enable all the CPU specified instruction set when building on the slave. And it's not clear to me what *some* flags are, suppose we don't want any CPU specified (-msse3, -msse4, etc.) thing.