From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mathieu Lirzin Subject: Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers. Date: Mon, 25 Jan 2016 22:41:42 +0100 Message-ID: <87y4bd2v6x.fsf@gnu.org> References: <1453666771-16869-1-git-send-email-mthl@gnu.org> <1453666771-16869-5-git-send-email-mthl@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNotS-000882-SH for guix-devel@gnu.org; Mon, 25 Jan 2016 16:41:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNotN-0008BY-TQ for guix-devel@gnu.org; Mon, 25 Jan 2016 16:41:50 -0500 In-Reply-To: (David Thompson's message of "Mon, 25 Jan 2016 09:04:28 -0500") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: "Thompson, David" Cc: guix-devel "Thompson, David" writes: > Does the fact that so many files needed to be edited indicate the need > for a single specification string constructor? If this had already > been the case, then this patch would have only needed to change 1 or 2 > procedures. I don't know if such string constructor would help here. My change log is maybe a bit misleading. Most of the files changed are for documentation and tests which require inevitably to be updated manually for such interface change. Some noise is introduced because now the canonical package full name (with '@') is not a factor of the store file names anymore (which still uses '-'). Maybe there can be some improvements on this side? Finally, There is some code redundancy for the emacs UI but If I remember correctly there is a reason for that. (Alex?) -- Mathieu Lirzin