From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roel Janssen Subject: Re: [PATCH] gnu: Add cppcheck. Date: Wed, 02 Mar 2016 14:46:20 +0100 Message-ID: <87y4a1vvpv.fsf@gnu.org> References: <87ziuhvz5e.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51637) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ab76b-0004Rr-Kl for guix-devel@gnu.org; Wed, 02 Mar 2016 08:46:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ab76X-0007yy-LJ for guix-devel@gnu.org; Wed, 02 Mar 2016 08:46:21 -0500 In-reply-to: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-gnu-Add-cppcheck.patch Content-Transfer-Encoding: 8bit >From 543a8db3f7cee85968c140ee28f047383f89593a Mon Sep 17 00:00:00 2001 From: Roel Janssen Date: Wed, 2 Mar 2016 14:42:16 +0100 Subject: [PATCH] gnu: Add cppcheck. * gnu/packages/check.scm (cppcheck): New variable. --- gnu/packages/check.scm | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm index 21ecd84..c612a2a 100644 --- a/gnu/packages/check.scm +++ b/gnu/packages/check.scm @@ -4,6 +4,7 @@ ;;; Copyright © 2015 Eric Bavier ;;; Copyright © 2015 Andreas Enge ;;; Copyright © 2016 Efraim Flashner +;;; Copyright © 2016 Roel Janssen ;;; ;;; This file is part of GNU Guix. ;;; @@ -172,3 +173,24 @@ different compilers. Cmocka supports several different message output formats like Test Anything Protocol, Subunit, xUnit XML or the original cmockery output format.") (license asl2.0))) + +(define-public cppcheck + (package + (name "cppcheck") + (version "1.72") + (source (origin + (method url-fetch) + (uri (string-append "https://github.com/danmar/cppcheck/archive/" + version ".tar.gz")) + (sha256 + (base32 "0zxaixhqi4vmj7xj56gzadggcbjhbjjm6abyr86qlan23sg98667")) + (file-name (string-append name "-" version ".tar.gz")))) + (build-system cmake-build-system) + (home-page "http://cppcheck.sourceforge.net") + (synopsis "Static C/C++ code analyzer") + (description "Cppcheck is a static code analyzer for C and C++. Unlike +C/C++ compilers and many other analysis tools it does not detect syntax errors +in the code. Cppcheck primarily detects the types of bugs that the compilers +normally do not detect. The goal is to detect only real errors in the code +(i.e. have zero false positives).") + (license gpl3+))) -- 2.5.0 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Hello Ricardo, Thank you for your quick review. > thank you, this looks good. I would add one sentence to the description > to start with what Cppcheck is, rather than what it is not. > > Cppcheck is a static code analyzer for C and C++. Unlike C/C++ ... > > If that’s okay I’ll push it with this change and with a copyright line > for you. I've attached a patch with these changes. I noticed that the other packages in check.scm don't use the license: prefix, so I also left that out. Kind regards, Roel Janssen --=-=-=--