Re: [PATCH] gnu: Add cppcheck.

[Roel Janssen <roel@gnu.org>]

[-- Attachment #1: 0001-gnu-Add-cppcheck.patch --]
[-- Type: text/x-patch, Size: 1897 bytes --]

From 543a8db3f7cee85968c140ee28f047383f89593a Mon Sep 17 00:00:00 2001
From: Roel Janssen <roel@gnu.org>
Date: Wed, 2 Mar 2016 14:42:16 +0100
Subject: [PATCH] gnu: Add cppcheck.

* gnu/packages/check.scm (cppcheck): New variable.
---
 gnu/packages/check.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
index 21ecd84..c612a2a 100644
--- a/gnu/packages/check.scm
+++ b/gnu/packages/check.scm
@@ -4,6 +4,7 @@
 ;;; Copyright © 2015 Eric Bavier <bavier@member.fsf.org>
 ;;; Copyright © 2015 Andreas Enge <andreas@enge.fr>
 ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
+;;; Copyright © 2016 Roel Janssen <roel@gnu.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -172,3 +173,24 @@ different compilers.  Cmocka supports several different message output formats
 like Test Anything Protocol, Subunit, xUnit XML or the original cmockery output
 format.")
     (license asl2.0)))
+
+(define-public cppcheck
+  (package
+    (name "cppcheck")
+    (version "1.72")
+    (source (origin
+      (method url-fetch)
+      (uri (string-append "https://github.com/danmar/cppcheck/archive/"
+                          version ".tar.gz"))
+      (sha256
+       (base32 "0zxaixhqi4vmj7xj56gzadggcbjhbjjm6abyr86qlan23sg98667"))
+      (file-name (string-append name "-" version ".tar.gz"))))
+    (build-system cmake-build-system)
+    (home-page "http://cppcheck.sourceforge.net")
+    (synopsis "Static C/C++ code analyzer")
+    (description "Cppcheck is a static code analyzer for C and C++.  Unlike
+C/C++ compilers and many other analysis tools it does not detect syntax errors
+in the code.  Cppcheck primarily detects the types of bugs that the compilers
+normally do not detect.  The goal is to detect only real errors in the code
+(i.e. have zero false positives).")
+    (license gpl3+)))
-- 
2.5.0


[-- Attachment #2: Type: text/plain, Size: 527 bytes --]

Hello Ricardo,

Thank you for your quick review.

> thank you, this looks good.  I would add one sentence to the description
> to start with what Cppcheck is, rather than what it is not.
>
>    Cppcheck is a static code analyzer for C and C++.  Unlike C/C++ ...
>
> If that’s okay I’ll push it with this change and with a copyright line
> for you.

I've attached a patch with these changes.

I noticed that the other packages in check.scm don't use the license: prefix,
so I also left that out.

Kind regards,
Roel Janssen