From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roel Janssen Subject: Re: [PATCH] gnu: Add 4store. Date: Tue, 29 Mar 2016 08:54:40 +0200 Message-ID: <87y491vknj.fsf@gnu.org> References: <8760wd5lqt.fsf@gnu.org> <20160328161624.GA7959@jasmine> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59800) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aknXt-0006In-BJ for guix-devel@gnu.org; Tue, 29 Mar 2016 02:54:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aknXm-0004Ii-6u for guix-devel@gnu.org; Tue, 29 Mar 2016 02:54:31 -0400 In-reply-to: <20160328161624.GA7959@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Leo Famulari Cc: guix-devel@gnu.org Dear Leo, Thank you for taking the time to review my patch. Leo Famulari writes: > On Wed, Mar 23, 2016 at 03:09:46PM +0100, Roel Janssen wrote: >> * gnu/packages/databases.scm (4store): New variable. >> * gnu/packages/patches/4store-fix-buildsystem.patch: New file. >> * gnu-system.am (dist_patch_DATA): Add patch file entry. > > [...] > >> +(define-public 4store >> + (let ((commit "c5a56d7c7504551a1f2fff6c16c4d9a440e4a317")) >> + (package >> + (name "4store") >> + (version (string-append "1.1.6-0." (string-take commit 7))) > > Why use this commit instead of the last release? I like especially these subtle changes/fixes: - run-time configurable HTTP log directory: commit 1725502cf01130ee80cf9b72249bbfc0f61f17fb - Fix for potential pointer arithmetic error: commit 6e2b4a70d4934484706a67b688ac30f3ca7baf98 The changes between the official release and this version are not that large. It probably isn't a problem to package the latest official release either, if that is preferable. >> Dear Guix, >> >> I would like to add 4store. The official website is currently offline, >> but there is an effort going on to get it back on line: >> https://github.com/garlik/4store/issues/137 >> >> Therefore, I would like to propose to keep the dead website link as this >> should sort itself out in time. > > I think this makes sense. Try to remember to follow up on the resolution > of that bug report :) Ok, I will try to remember that. :) Thanks again for your time. Kind regards, Roel Janssen