From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: powertop: Patch absolute file names.
Date: Mon, 25 Apr 2016 23:52:12 +0200
Message-ID: <87y4819x0z.fsf@gnu.org>
References: <1461013301-13196-1-git-send-email-mthl@gnu.org>
	<87twitf0u0.fsf@netris.org> <87shyccyn4.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51802)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1auoQW-0002WF-3h
	for guix-devel@gnu.org; Mon, 25 Apr 2016 17:52:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1auoQV-00061b-6x
	for guix-devel@gnu.org; Mon, 25 Apr 2016 17:52:20 -0400
In-Reply-To: <87shyccyn4.fsf@gnu.org> (Mathieu Lirzin's message of "Sat, 23
	Apr 2016 14:12:15 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Mathieu Lirzin <mthl@gnu.org>
Cc: guix-devel@gnu.org

Mathieu Lirzin <mthl@gnu.org> skribis:

> From efb3e50fe4c86b1bf25fee50a481b45d28c5ff45 Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <mthl@gnu.org>
> Date: Mon, 18 Apr 2016 17:00:44 +0200
> Subject: [PATCH] gnu: powertop: Patch absolute file names.
>
> * gnu/packages/linux.scm (powertop)[inputs]: Add kmod.
> [arguments]: Patch absolute file names.

[...]

> +               (substitute* (find-files "src" "\\.cpp$")
> +                 (("/sbin/modprobe") (string-append kmod "/bin/modprobe"=
))

Maybe with a comment saying =E2=80=9CGive the right =E2=80=98modprobe=E2=80=
=99 file name so that
essential modules such as msr.ko can be loaded.=E2=80=9D

> +                 ;; These programs are only needed to calibrate, so using
> +                 ;; relative file names avoids adding extra inputs.  Whe=
n they
> +                 ;; are missing powertop gracefully handles it.
> +                 (("/usr/bin/hcitool") "hcitool")       ;XXX:not package=
d yet
> +                 (("/usr/bin/xset") "xset")
> +                 (("/usr/sbin/hciconfig") "hciconfig")) ;XXX:not package=
d yet

I think this is fine too, but regardless, please commit the patch in
this form since it fixes the IMO important modprobe issue above.  :-)

Thanks!

Ludo=E2=80=99.