Re: [PATCH] gnu: powertop: Patch absolute file names.

[ludo@gnu.org (Ludovic Courtès)]

Mathieu Lirzin <mthl@gnu.org> skribis:

> From efb3e50fe4c86b1bf25fee50a481b45d28c5ff45 Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <mthl@gnu.org>
> Date: Mon, 18 Apr 2016 17:00:44 +0200
> Subject: [PATCH] gnu: powertop: Patch absolute file names.
>
> * gnu/packages/linux.scm (powertop)[inputs]: Add kmod.
> [arguments]: Patch absolute file names.

[...]

> +               (substitute* (find-files "src" "\\.cpp$")
> +                 (("/sbin/modprobe") (string-append kmod "/bin/modprobe"))

Maybe with a comment saying “Give the right ‘modprobe’ file name so that
essential modules such as msr.ko can be loaded.”

> +                 ;; These programs are only needed to calibrate, so using
> +                 ;; relative file names avoids adding extra inputs.  When they
> +                 ;; are missing powertop gracefully handles it.
> +                 (("/usr/bin/hcitool") "hcitool")       ;XXX:not packaged yet
> +                 (("/usr/bin/xset") "xset")
> +                 (("/usr/sbin/hciconfig") "hciconfig")) ;XXX:not packaged yet

I think this is fine too, but regardless, please commit the patch in
this form since it fixes the IMO important modprobe issue above.  :-)

Thanks!

Ludo’.