From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mathieu Lirzin <mthl@gnu.org>
Subject: Re: [PATCH] guix: use '@' in package-full-name instead of '-'
Date: Thu, 28 Apr 2016 10:23:16 +0200
Message-ID: <87y47yuop7.fsf@gnu.org>
References: <1461810323-21018-1-git-send-email-tipecaml@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60365)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mthl@gnu.org>) id 1avhEL-0005TY-JT
	for guix-devel@gnu.org; Thu, 28 Apr 2016 04:23:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mthl@gnu.org>) id 1avhEH-0000w8-JG
	for guix-devel@gnu.org; Thu, 28 Apr 2016 04:23:25 -0400
In-Reply-To: <1461810323-21018-1-git-send-email-tipecaml@gmail.com> (Cyril
	Roelandt's message of "Thu, 28 Apr 2016 04:25:23 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org

Cyril Roelandt <tipecaml@gmail.com> writes:

> * guix/packages.scm (package-full-name): Use '@' instead of '-'.
> ---
>  guix/packages.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix/packages.scm b/guix/packages.scm
> index d62d1f3..e33791e 100644
> --- a/guix/packages.scm
> +++ b/guix/packages.scm
> @@ -346,7 +346,7 @@ name of its URI."
>=20=20
>  (define (package-full-name package)
>    "Return the full name of PACKAGE--i.e., `NAME-VERSION'."
> -  (string-append (package-name package) "-" (package-version package)))
> +  (string-append (package-name package) "@" (package-version package)))
>=20=20
>  (define (%standard-patch-inputs)
>    (let* ((canonical (module-ref (resolve-interface '(gnu packages base))

Unfortunately, changing this is not as simple.

When implementing the '-' to '@' thing, I have proposed to switch
=E2=80=98package-full-name=E2=80=99.  While I still think it would make sen=
se for it to
use '@', it would require a full rebuild of every package + extra care.
For example among other things the tests will not be happy for =E2=80=98guix
graph=E2=80=98 IIRC, and the Guix website uses it to access Hydra links.

It would be great if you manage to solve this issue.  :)

Thanks,

--=20
Mathieu Lirzin