all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [PATCH] guix: use '@' in package-full-name instead of '-'
@ 2016-04-28  2:25 Cyril Roelandt
  2016-04-28  3:03 ` Eric Bavier
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Cyril Roelandt @ 2016-04-28  2:25 UTC (permalink / raw)
  To: guix-devel

* guix/packages.scm (package-full-name): Use '@' instead of '-'.
---
 guix/packages.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix/packages.scm b/guix/packages.scm
index d62d1f3..e33791e 100644
--- a/guix/packages.scm
+++ b/guix/packages.scm
@@ -346,7 +346,7 @@ name of its URI."
 
 (define (package-full-name package)
   "Return the full name of PACKAGE--i.e., `NAME-VERSION'."
-  (string-append (package-name package) "-" (package-version package)))
+  (string-append (package-name package) "@" (package-version package)))
 
 (define (%standard-patch-inputs)
   (let* ((canonical (module-ref (resolve-interface '(gnu packages base))
-- 
2.6.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] guix: use '@' in package-full-name instead of '-'
  2016-04-28  2:25 [PATCH] guix: use '@' in package-full-name instead of '-' Cyril Roelandt
@ 2016-04-28  3:03 ` Eric Bavier
  2016-04-28  8:23 ` Mathieu Lirzin
  2016-04-28  8:46 ` Alex Kost
  2 siblings, 0 replies; 5+ messages in thread
From: Eric Bavier @ 2016-04-28  3:03 UTC (permalink / raw)
  To: Cyril Roelandt; +Cc: guix-devel

On Thu, 28 Apr 2016 04:25:23 +0200
Cyril Roelandt <tipecaml@gmail.com> wrote:

> * guix/packages.scm (package-full-name): Use '@' instead of '-'.
> ---
>  guix/packages.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/guix/packages.scm b/guix/packages.scm
> index d62d1f3..e33791e 100644
> --- a/guix/packages.scm
> +++ b/guix/packages.scm
> @@ -346,7 +346,7 @@ name of its URI."
>  
>  (define (package-full-name package)
>    "Return the full name of PACKAGE--i.e., `NAME-VERSION'."

Could you replace the '-' here too? --------------^

> -  (string-append (package-name package) "-" (package-version package)))
> +  (string-append (package-name package) "@" (package-version package)))
>  
>  (define (%standard-patch-inputs)
>    (let* ((canonical (module-ref (resolve-interface '(gnu packages base))

LGTM!

`~Eric

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] guix: use '@' in package-full-name instead of '-'
  2016-04-28  2:25 [PATCH] guix: use '@' in package-full-name instead of '-' Cyril Roelandt
  2016-04-28  3:03 ` Eric Bavier
@ 2016-04-28  8:23 ` Mathieu Lirzin
  2016-04-28 12:07   ` Ludovic Courtès
  2016-04-28  8:46 ` Alex Kost
  2 siblings, 1 reply; 5+ messages in thread
From: Mathieu Lirzin @ 2016-04-28  8:23 UTC (permalink / raw)
  To: Cyril Roelandt; +Cc: guix-devel

Cyril Roelandt <tipecaml@gmail.com> writes:

> * guix/packages.scm (package-full-name): Use '@' instead of '-'.
> ---
>  guix/packages.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix/packages.scm b/guix/packages.scm
> index d62d1f3..e33791e 100644
> --- a/guix/packages.scm
> +++ b/guix/packages.scm
> @@ -346,7 +346,7 @@ name of its URI."
>  
>  (define (package-full-name package)
>    "Return the full name of PACKAGE--i.e., `NAME-VERSION'."
> -  (string-append (package-name package) "-" (package-version package)))
> +  (string-append (package-name package) "@" (package-version package)))
>  
>  (define (%standard-patch-inputs)
>    (let* ((canonical (module-ref (resolve-interface '(gnu packages base))

Unfortunately, changing this is not as simple.

When implementing the '-' to '@' thing, I have proposed to switch
‘package-full-name’.  While I still think it would make sense for it to
use '@', it would require a full rebuild of every package + extra care.
For example among other things the tests will not be happy for ‘guix
graph‘ IIRC, and the Guix website uses it to access Hydra links.

It would be great if you manage to solve this issue.  :)

Thanks,

-- 
Mathieu Lirzin

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] guix: use '@' in package-full-name instead of '-'
  2016-04-28  2:25 [PATCH] guix: use '@' in package-full-name instead of '-' Cyril Roelandt
  2016-04-28  3:03 ` Eric Bavier
  2016-04-28  8:23 ` Mathieu Lirzin
@ 2016-04-28  8:46 ` Alex Kost
  2 siblings, 0 replies; 5+ messages in thread
From: Alex Kost @ 2016-04-28  8:46 UTC (permalink / raw)
  To: Cyril Roelandt; +Cc: guix-devel

Cyril Roelandt (2016-04-28 05:25 +0300) wrote:

> * guix/packages.scm (package-full-name): Use '@' instead of '-'.
> ---
>  guix/packages.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> diff --git a/guix/packages.scm b/guix/packages.scm
> index d62d1f3..e33791e 100644
> --- a/guix/packages.scm
> +++ b/guix/packages.scm
> @@ -346,7 +346,7 @@ name of its URI."
>  
>  (define (package-full-name package)
>    "Return the full name of PACKAGE--i.e., `NAME-VERSION'."
> -  (string-append (package-name package) "-" (package-version package)))
> +  (string-append (package-name package) "@" (package-version package)))
>  
>  (define (%standard-patch-inputs)
>    (let* ((canonical (module-ref (resolve-interface '(gnu packages base))

I recall it was intentionally left untouched.  I don't remember details
but search for 'package-full-name' here:
http://lists.gnu.org/archive/html/guix-devel/2016-01/msg00910.html

Mathieu or Ludovic should know better.

-- 
Alex

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] guix: use '@' in package-full-name instead of '-'
  2016-04-28  8:23 ` Mathieu Lirzin
@ 2016-04-28 12:07   ` Ludovic Courtès
  0 siblings, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2016-04-28 12:07 UTC (permalink / raw)
  To: Mathieu Lirzin; +Cc: guix-devel

Mathieu Lirzin <mthl@gnu.org> skribis:

> Cyril Roelandt <tipecaml@gmail.com> writes:
>
>> * guix/packages.scm (package-full-name): Use '@' instead of '-'.
>> ---
>>  guix/packages.scm | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/guix/packages.scm b/guix/packages.scm
>> index d62d1f3..e33791e 100644
>> --- a/guix/packages.scm
>> +++ b/guix/packages.scm
>> @@ -346,7 +346,7 @@ name of its URI."
>>  
>>  (define (package-full-name package)
>>    "Return the full name of PACKAGE--i.e., `NAME-VERSION'."
>> -  (string-append (package-name package) "-" (package-version package)))
>> +  (string-append (package-name package) "@" (package-version package)))
>>  
>>  (define (%standard-patch-inputs)
>>    (let* ((canonical (module-ref (resolve-interface '(gnu packages base))
>
> Unfortunately, changing this is not as simple.
>
> When implementing the '-' to '@' thing, I have proposed to switch
> ‘package-full-name’.  While I still think it would make sense for it to
> use '@', it would require a full rebuild of every package + extra care.

No no, no full rebuild, only extra care.  :-)

> For example among other things the tests will not be happy for ‘guix
> graph‘ IIRC, and the Guix website uses it to access Hydra links.

Right, there are a few places that sorta expect a hyphen; the thing that
generates <http://gnu.org/s/guix/packages> is the only one that comes to
mind, though.

When discussing the patch series for the @ syntax, we discussed at one
point making the delimiter of ‘package-full-name’ an optional parameter
that would default to @.  It appears in the patch at:

  https://lists.gnu.org/archive/html/guix-devel/2016-01/msg00873.html

I’m not sure why we dropped it, but we should try to reinstate it.

Cyril, can you make the delimiter an optional argument and see whether
‘make check’ passes?

Thanks!

Ludo’.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-04-28 12:07 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-28  2:25 [PATCH] guix: use '@' in package-full-name instead of '-' Cyril Roelandt
2016-04-28  3:03 ` Eric Bavier
2016-04-28  8:23 ` Mathieu Lirzin
2016-04-28 12:07   ` Ludovic Courtès
2016-04-28  8:46 ` Alex Kost

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.