From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roel Janssen Subject: Re: [PATCH] gnu: Add bash-tap. Date: Sat, 07 May 2016 19:12:42 +0200 Message-ID: <87y47l6bcl.fsf@gnu.org> References: <8760wlrst0.fsf@gnu.org> <20160318184342.GB9682@jasmine> <20160318185339.GA20746@solar> <20160318191519.GF9682@jasmine> <87h9ef5sk6.fsf@gnu.org> <20160506180732.GA1772@jasmine> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1az5mg-0002Bs-9Q for guix-devel@gnu.org; Sat, 07 May 2016 13:12:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1az5mc-00062W-08 for guix-devel@gnu.org; Sat, 07 May 2016 13:12:53 -0400 In-reply-to: <20160506180732.GA1772@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org Leo Famulari writes: > On Tue, May 03, 2016 at 12:44:57PM +0200, Roel Janssen wrote: >> * gnu/packages/bash.scm (bash-tap): New variable. > >> + (arguments >> + `(#:tests? #f ; There is no test suite. >> + #:phases >> + (modify-phases %standard-phases >> + (delete 'configure) ; There is no Makefile. >> + (delete 'build) ; There is no Makefile. > > I think these comments don't fully describe the situation. How about > the comment in the attached patch? Even though I'm not sure what comments you are exactly refering to, I think this new patch should be better :) Once again, thanks for your time! Here is the patch: >From f3d6252be65844c22716f388895fc0d82e96e123 Mon Sep 17 00:00:00 2001 From: Roel Janssen Date: Sat, 7 May 2016 19:09:40 +0200 Subject: [PATCH] gnu: Add bash-tap. * gnu/packages/bash.scm (bash-tap): New variable. --- gnu/packages/bash.scm | 42 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/gnu/packages/bash.scm b/gnu/packages/bash.scm index cad66da..c22005b 100644 --- a/gnu/packages/bash.scm +++ b/gnu/packages/bash.scm @@ -318,3 +318,45 @@ without modification.") completion for many common commands.") (home-page "http://bash-completion.alioth.debian.org/") (license gpl2+))) + +(define-public bash-tap + (package + (name "bash-tap") + (version "1.0.2") + (source (origin + (method url-fetch) + (uri (string-append "https://github.com/illusori/bash-tap/archive/" + version ".tar.gz")) + (file-name (string-append name "-" version ".tar.gz")) + (sha256 + (base32 "0qs1qi38bl3ns4mpagcawv618dsk2q1lgrbddgvs0wl3ia12cyz5")))) + ;; There is no compilation process to use this package, however, the bash + ;; scripts installed by this package start with "#!/bin/bash". To fix + ;; these lines, we use the patch-shebangs of the GNU build system. The + ;; project does not use a Makefile. + (build-system gnu-build-system) + (arguments + `(#:tests? #f ; There is no test suite. + #:phases + (modify-phases %standard-phases + ;; Because there is no configure scripts and no Makefile, we + ;; can remove these phases. + (delete 'configure) + (delete 'build) + ;; The installation involves manually copying the files to a location. + ;; To make them easily accessible by setting PATH, we add the scripts + ;; to the "bin" folder. + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let ((bin (string-append (assoc-ref outputs "out") "/bin"))) + (install-file "bash-tap" bin) + (install-file "bash-tap-bootstrap" bin) + (install-file "bash-tap-mock" bin))))))) + (home-page "http://www.illusori.co.uk/projects/bash-tap/") + (synopsis "Bash port of a Test::More/Test::Builder-style TAP-compliant +test library") + (description "Bash TAP is a TAP-compliant Test::More-style testing library +for Bash shell scripts and functions. Along with the Test::More-style testing +helpers it provides helper functions for mocking commands and in-process output +capturing.") + (license expat))) -- 2.7.4