From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matthew Jordan <matthewjordandevops@yandex.com>
Subject: Re: [PATCH] entr-3.5
Date: Wed, 11 May 2016 13:19:04 -0400
Message-ID: <87y47gy0l3.fsf@mailerver.i-did-not-set--mail-host-address--so-tickle-me>
References: <87wpn0ofn8.fsf@mailerver.i-did-not-set--mail-host-address--so-tickle-me>
	<87wpn0sh26.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41542)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <matthewjordandevops@yandex.com>) id 1b0XnU-0005yC-BM
	for guix-devel@gnu.org; Wed, 11 May 2016 13:19:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <matthewjordandevops@yandex.com>) id 1b0XnQ-0005Jt-CF
	for guix-devel@gnu.org; Wed, 11 May 2016 13:19:44 -0400
In-reply-to: <87wpn0sh26.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: Guix-devel <guix-devel@gnu.org>


Thank you for the welcome Ludovic Court=C3=A8s. I just have a couple of
questions.

>   3. Added the file to gnu/local.mk.

Is this file to be updated when a new source file is added?

>   4. Added a ChangeLog-style commit log.

Is there a specific reference/manual on the "ChangeLog-style" I could rev=
iew?

>   2. Added a =E2=80=98remove-fhs-file-names=E2=80=99 phase to remove ha=
rd-coded
>      references to /bin/cat and /usr/bin/clear.

And is =E2=80=98remove-fhs-file-names=E2=80=99 a custom phase? If not, wh=
ich source file
contains the available phases?

Thank you in advance, and sorry for all the noob questions.

Ludovic Court=C3=A8s writes:

> Hello, and welcome!
>
> Matthew Jordan <matthewjordan85@gmail.com> skribis:
>
>> I'm relatively new to guix, spent the first couple
>> days getting used to running it in my VM.  Loving it so far.  Since I'=
m
>> not sure what to expect I decided to package a simple program that I
>> find quite handy. Let me know if I should change anything.
>>
>> Also note that I followed "8.5 Submitting Patches" of the "GNU Guix
>> Reference Manual"
>
> Great!  There=E2=80=99s a couple of things that this section doesn=E2=80=
=99t clearly
> mention, such as copyright notices=E2=80=94there=E2=80=99s room for imp=
rovement.  ;-)
>
>> From 5b33ed530e472008bddf85a2f23b3fa9857b365e Mon Sep 17 00:00:00 2001
>> From: Matthew Jordan <matthewjordandevops@yandex.com>
>> Date: Wed, 11 May 2016 09:25:13 -0400
>> Subject: [PATCH] Added package entr.
>
> Pushed as 5d38aa0 with these minor changes:
>
>   1. Added a copyright notice for you (let me know if you think it=E2=80=
=99s
>      incorrect!).
>
>   2. Added a =E2=80=98remove-fhs-file-names=E2=80=99 phase to remove ha=
rd-coded
>      references to /bin/cat and /usr/bin/clear.
>
>   3. Added the file to gnu/local.mk.
>
>   4. Added a ChangeLog-style commit log.
>
> Thank you!
>
> Ludo=E2=80=99.

Sincerely,

--=20
Matthew Jordan
Sent with my mu4e