From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add guile-gnome
Date: Sat, 28 May 2016 18:06:43 +0200
Message-ID: <87y46ui2uk.fsf@gnu.org>
References: <1464375363-31718-1-git-send-email-patrick.hetu@auf.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60577)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1b6glI-00074C-NH
	for guix-devel@gnu.org; Sat, 28 May 2016 12:06:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1b6glD-000115-4R
	for guix-devel@gnu.org; Sat, 28 May 2016 12:06:51 -0400
In-Reply-To: <1464375363-31718-1-git-send-email-patrick.hetu@auf.org> (Patrick
	Hetu's message of "Fri, 27 May 2016 14:56:03 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Patrick Hetu <patrick.hetu@auf.org>
Cc: guix-devel@gnu.org

Hi!

Patrick Hetu <patrick.hetu@auf.org> skribis:

> * gnu/packages/gtk.scm (guile-gnome): New variables.

This is a long-overdue addition.

Pushed as 9b381643f009025d97dfc0b82d2c00800c204380 with a few minor
changes:

> +(define-public guile-g-wrap

This one is already available in (gnu packages guile).  :-)

> +              (uri
> +               (string-append "http://ftp.gnu.org/pub/gnu/" name

I changed that to mirror://gnu.

> +      `(#:tests? #f

This should be fixed or explained.

> +        #:phases (alist-cons-before

Changed to =E2=80=98modify-phases=E2=80=99.

> +                      (substitute* (find-files "." "^Makefile.am$")

Modified Makefile.in instead so that we don=E2=80=99t need the dependency on
Autoconf, Automake, and Libtool.

> +    (description "Guile wrapper collection for the following GNOME core =
libraries:

Changed to what =E2=80=98guix lint=E2=80=99 recommends.

Thanks!

Ludo=E2=80=99.